New issue
Advanced search Search tips

Issue 668134 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Crash reporter fails to report kernel warnings for kernels >3.10

Project Member Reported by mnissler@chromium.org, Nov 23 2016

Issue description

Reason is that our regular expression matches on "WARNING: at" [1], however the format was change per [2].

I have spot-checked crash data to confirm that we haven't seen any warning reports for board on newer kernels (which is the majority).

We should:

(1) Fix the warning collector to pick up warnings again.
(2) Improve testing to make sure we catch future formatting changes.

[1] https://chromium.googlesource.com/chromiumos/platform2/+/master/crash-reporter/warn_collector.l#40
[2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=dcb6b45254e2281b6f99ea7f2d51343954aa3ba8
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a

commit ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Nov 25 14:01:48 2016

crash: Handle new warning format

The kernel has switched its warning format to include CPU and PID in
the WARNING line per [1] which landed in the 3.11 cycle. Kernels 3.10
and earlier continue to use the old format. Adjust the analyzer to
understand both old and new format. Also update the test to use a
warning message in new format for testing most edge case behavior, but
keep a copy of the old format and make sure it still gets picked up by
the collector.

[1] https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/dcb6b45254e2281b6f99ea7f2d51343954aa3ba8

BUG= chromium:668134 
TEST=FEATURES=test emerge-$BOARD -v1 crash-reporter

Change-Id: I41617d1a112170961d198625caba58d35a5ef385
Reviewed-on: https://chromium-review.googlesource.com/414905
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a/crash-reporter/TEST_WARNING
[add] https://crrev.com/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a/crash-reporter/TEST_WARNING_OLD
[modify] https://crrev.com/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a/crash-reporter/warn_collector.l
[modify] https://crrev.com/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a/crash-reporter/crash-reporter.gyp
[modify] https://crrev.com/ddfc51e8f2b06b9b6d14c31b9cbcae65c9fd880a/crash-reporter/warn_collector_test.sh

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
See kernel_warning crash in 9592.71.0 like : 3147b31904000000 

Sign in to add a comment