New issue
Advanced search Search tips

Issue 668102 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in fclamp

Project Member Reported by ClusterFuzz, Nov 23 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5773807064449024

Fuzzer: libfuzzer_pdf_codec_icc_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  fclamp
  TetrahedralInterpFloat
  _LUTevalFloat
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=430492:430537

Minimized Testcase (0.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96At5fPFl9bGzlg2P44ssv5n8NS3nFMognaRsB_iXFfPbFhAhqqWm_zly56SCswf0JnK0B3SkGTzNRqimuUe6pkrKXju0lJ_-ZCxFIA9EcqvMnNztrh0qOvGvdIrxdHEsN9c_09RRFuQ4zS4a_-C1Mnq5cMxg?testcase_id=5773807064449024

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 23 2016

Labels: M-56
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 23 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 23 2016

Labels: Pri-1
Cc: thestig@chromium.org
Components: Internals>Plugins>PDF
Owner: kcwu@chromium.org
Status: Assigned (was: Untriaged)
Another PDF ICC security bug for you to take a look at. :)

Comment 5 by kcwu@chromium.org, Nov 24 2016

There are "pipeline" (chain of functions) in lcms.

The first stage of pipeline is calling TetrahedralInterpFloat() with nInputs=3, nOutputs=2.
The second stage of pipeline is calling TetrahedralInterpFloat() with nInputs=3, nOutputs=2. 
But previous stage only fill 2. Input[2] is uninitialized.

Need to verify the input and output size of pipeline somewhere.

Project Member

Comment 6 by sheriffbot@chromium.org, Dec 2 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Any updates on this?  We're planning on shipping to Beta tomorrow on 12/8
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to ReleaseBlock-Stable so this still gets tracked in the milestone
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 8 2016

kcwu: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by ClusterFuzz, Dec 18 2016

ClusterFuzz has detected this issue as fixed in range 439303:439328.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5773807064449024

Fuzzer: libfuzzer_pdf_codec_icc_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  fclamp
  TetrahedralInterpFloat
  _LUTevalFloat
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=430492:430537
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=439303:439328

Minimized Testcase (0.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96At5fPFl9bGzlg2P44ssv5n8NS3nFMognaRsB_iXFfPbFhAhqqWm_zly56SCswf0JnK0B3SkGTzNRqimuUe6pkrKXju0lJ_-ZCxFIA9EcqvMnNztrh0qOvGvdIrxdHEsN9c_09RRFuQ4zS4a_-C1Mnq5cMxg?testcase_id=5773807064449024

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Dec 18 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5773807064449024 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 18 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-56 -ReleaseBlock-Stable M-57
Removing RVS since we don't have a chane to merge at this point.
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment