New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 664505
issue 667941
issue 668097



Sign in to add a comment

Any user story failure stop the whole telemetry benchmark from running

Project Member Reported by nedngu...@google.com, Nov 23 2016

Issue description

This seems like a regression to Telemetry's story_runner loop. In  issue 667941  and issue 668097, the failing story make the whole benchmark stopped.

This makes a very serious loss of coverage. So I make this a P1 bug.
 
Blocking: 667941 668097
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)
Blocking: 664505
Telemetry's story_runner should keep running the stories if the exception throw by a run is of type exceptions.Error (see https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/internal/story_runner.py#L230). 

Though I am still puzzled by what happen in issue 668097. Juan: you have the log in which the DevtoolsTargetCrashException will make the whole benchmark stop?
Juan: in the log you showed me, the exception is TracingControllerStoppedError, which could be an unrecoverable exception since failure to stop tracing will make the next test's start tracing fail. In this case, I think it's working as expected.
Ah, I see, I was distracted by the other exception tracebacks below. Will update and add more comments on issue 668097.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ae453ffd64c2a78105e244074c1a7077faee52

commit 97ae453ffd64c2a78105e244074c1a7077faee52
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Nov 23 17:21:40 2016

Roll src/third_party/catapult/ 3cf490467..62505b333 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3cf49046742e..62505b3333dd

$ git log 3cf490467..62505b333 --date=short --no-merges --format='%ad %ae %s'
2016-11-23 nednguyen Raise exceptions.Error when memory dump is None

BUG= 668098 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2529693002
Cr-Commit-Position: refs/heads/master@{#434194}

[modify] https://crrev.com/97ae453ffd64c2a78105e244074c1a7077faee52/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment