New issue
Advanced search Search tips

Issue 668091 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Allow ForeignFetch service workers to intercept HTTP redirects.

Project Member Reported by evn@google.com, Nov 23 2016

Issue description

Version: 54.0.2840.100 (Official Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Install a service worker with foreign fetch on b.com.
(2) HTTP redirect from a.com to b.com.

What is the expected result?
foreignFetch event for b.com should be triggered.

What happens instead?
foreignFetch event for b.com isn't triggered.

Please use labels and text to provide additional information.

 

Comment 1 by evn@google.com, Nov 23 2016

Cc: mek@chromium.org horo@chromium.org

Comment 2 by evn@google.com, Nov 23 2016

Super simple patch to fix this:
https://codereview.chromium.org/2529523004

Comment 3 by evn@google.com, Nov 23 2016

Cc: annevank...@gmail.com
References: https://github.com/whatwg/fetch/issues/362

Comment 4 by evn@google.com, Nov 23 2016

Summary: Allow ForeignFetch service workers to intercept HTTP redirects. (was: Allow ForeignFetch service workers to be intercepted for HTTP redirects.)

Comment 5 by ajha@chromium.org, Nov 24 2016

Labels: M-57
La-belling with M-57, please adjust the milestone if it's not appropriate.
Components: Blink>ServiceWorker
Cc: -mek@chromium.org
Owner: mek@chromium.org
Status: Assigned (was: Untriaged)
How is the current status of this?
Is this blocked by some spec change or is it a bug?

# I assigned to mek for now.

Comment 8 by evn@google.com, Dec 2 2016

I'm not sure, sorry. Assigning to mek@ makes sense.

Comment 9 by evn@google.com, Mar 25 2017

The code changed, now in this line:
https://cs.chromium.org/chromium/src/content/child/web_url_loader_impl.cc?q=web_url_loader_impl+package:%5Echromium$&l=672&rcl=90ff901e2d8127ff990319818f93de838fcd8990

It has to say:
          : blink::WebURLRequest::ServiceWorkerMode::Foreign);

@mek, should I update the patch?

Comment 10 by mek@chromium.org, Mar 29 2017

Sorry for ignoring this patch/bug so far. The proposed change definitely sounds good, as it would better align our implementation with the spec. We should also add some (web platform) tests for this while we're at it.

Comment 11 by mek@chromium.org, Jan 30 2018

Status: WontFix (was: Assigned)
Foreign fetch is no more.

Sign in to add a comment