New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668087 link

Starred by 1 user
Status: Verified
Owner:
█ joh...@chromium.org
no longer working on chrome
Closed: Nov 2016
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocked on:
issue 614456


Sign in to add a comment

Notification image border/background is too dark

Project Member Reported by joh...@chromium.org, Nov 23 2016 
 Issue 326224  gave notification images that don't have exactly a 3:2 aspect ratio a dark border (technically it's a background).

UI review recently commented (https://goto.google.com/mhgmb) that the dark background looks odd, and sgabriel@ and bettes@ suggested offline that we change it to match the notification background (which is white).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1da7201bea9f6d2cd10619638fca3f0526778d73

commit 1da7201bea9f6d2cd10619638fca3f0526778d73
Author: johnme <johnme@chromium.org>
Date: Wed Nov 23 19:41:50 2016

[Notifications] Make image background white like notification background

Suggested by UI reviewers, and looks a little cleaner.

BUG= 668087 

Review-Url: https://codereview.chromium.org/2522083003
Cr-Commit-Position: refs/heads/master@{#434225}

[modify] https://crrev.com/1da7201bea9f6d2cd10619638fca3f0526778d73/ui/message_center/message_center_style.h

Comment 2 by joh...@chromium.org, Nov 28 2016

Labels: Merge-Request-56
Requesting approval to merge https://crrev.com/1da7201bea9f6d2cd10619638fca3f0526778d73 to m56. It's a one-liner addressing feedback from UI launch approval that wasn't blocking but is better to fix before launch.

Comment 3 by dimu@chromium.org, Nov 28 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b56874adef69558560cf961624ec6cf217acd92

commit 7b56874adef69558560cf961624ec6cf217acd92
Author: John Mellor <johnme@chromium.org>
Date: Mon Nov 28 17:25:15 2016

[Notifications] Make image background white like notification background

Suggested by UI reviewers, and looks a little cleaner.

BUG= 668087 

Review-Url: https://codereview.chromium.org/2522083003
Cr-Commit-Position: refs/heads/master@{#434225}
(cherry picked from commit 1da7201bea9f6d2cd10619638fca3f0526778d73)

Review URL: https://codereview.chromium.org/2535873002 .

Cr-Commit-Position: refs/branch-heads/2924@{#113}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/7b56874adef69558560cf961624ec6cf217acd92/ui/message_center/message_center_style.h

Comment 5 by joh...@chromium.org, Nov 28 2016

Status: Fixed (was: Started)

Comment 6 by joh...@chromium.org, Nov 28 2016

Labels: M-56

Comment 7 by abod...@chromium.org, Dec 13 2016

Status: Verified (was: Fixed)
ChromeOS:9000.27.0/Chrome:56.0.2924.26

Comment 8 by joh...@chromium.org, Mar 2 2017

Blockedon: 614456
►

Sign in to add a comment