extra animation/rendering activities during V8.Execution in Octane2 workload
Reported by
junchao....@intel.com,
Nov 23 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36 Steps to reproduce the problem: 1. install latest chrome (54.0.2840.99) on Windows OS 2. open two chrome windows and display them side by side on the desktop 3. for the first chrome window, press F12, choose "Toggle device toolbar" and select "Nexus 6P", and open https://chromium.github.io/octane/ 4. for the second chrome window, open chrome://tracing, press "Record", choose "JavaScript and rendering", press "Record" 5. touch "Start Octane 2.0" in the first window 6. wait 10 seconds and click "Stop" in second window 7. view trace collected in second window What is the expected behavior? For chrome process running Octane2, when V8.Execute is busy in CrRenderMain thread, there should be no extra animation/rendering activity in Compositor thread. What went wrong? For chrome process running Octane2, when V8.Execute is busy in CrRenderMain thread, there are many extra animation/rendering activities in Compositor thread. For WebView on Android, such activities will cause frame keeps updating. But actually frame should not be updated during JS runs the workload. Did this work before? N/A Chrome version: 54.0.2840.99 Channel: stable OS Version: 6.3 Flash Version: Shockwave Flash 23.0 r0
,
Nov 24 2016
,
Nov 24 2016
Looks like CL is under review. Marking this Untriaged and Cc'ing reviewer for further update. Thank you!
,
Nov 28 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e190bb23bc08d98e305c4e2b367acf932a2d800 commit 7e190bb23bc08d98e305c4e2b367acf932a2d800 Author: junchao.han <junchao.han@intel.com> Date: Tue Nov 29 03:10:02 2016 add has_element_in_any_list check in ElementAnimations::UpdateActivation add has_element_in_any_list check in ElementAnimations::UpdateActivation during PushProperities process. This solves a corner case if dom for animation be removed before animation starts. See bug for details. BUG= 668086 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2527623002 Cr-Commit-Position: refs/heads/master@{#434862} [modify] https://crrev.com/7e190bb23bc08d98e305c4e2b367acf932a2d800/cc/animation/element_animations.cc [modify] https://crrev.com/7e190bb23bc08d98e305c4e2b367acf932a2d800/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/7e190bb23bc08d98e305c4e2b367acf932a2d800/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/7e190bb23bc08d98e305c4e2b367acf932a2d800/cc/test/animation_timelines_test_common.h
,
Nov 29 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by junchao....@intel.com
, Nov 24 2016