New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668075 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus doesn't traverse in chrome://md-settings/changePicture page on using arrow keys

Project Member Reported by mmanchala@chromium.org, Nov 23 2016

Issue description

Version: 57.0.2926.0/9014.0.0 dev-channel Falco,Gnawty and Paine
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://md-settings/changePicture page 
(2)Now Use Up/Down/Right/left arrow buttons from keyboard and observe for Focus (Please refer Video)

Expected: Focus should traverse in chrome://md-settings/changePicture page on using arrow keys 
Actual: Instead Focus does not traverse

This is Regression Issue as same is working fine in chrome://settings page i.e. Focus  is seen.


 
Actual.webm
645 KB View Download
Expected_Navigation.webm
1.5 MB View Download
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Labels: Needs-Feedback
Hello, can this still be reproduced on Chrome Canary?
Labels: -Needs-Feedback
As per comment # 2 checked on latest chrome canary build.
Able to reproduce the Issue in 57.0.2977.0/9171.0.0 i.e. Using Up/Down/Right/left arrow buttons from keyboard focus does not traverse
Cc: tommycli@chromium.org
Labels: -M-57 M-58
Owner: steve...@chromium.org
tommycli@ - Here is what I see: When the page is opened, we show the focus highlight around the selected image, but the image select is not actually focused. Pressing 'tab' twice will select it at which point the arrow keys work fine.

I can go ahead and look into focusing the image select by default since this is CrOS only, unless you know exactly what it is or want to take this on.

stevenjb@ - Thanks for diving into this.

For your reference, the Manage Profile feature (Chrome Browser) has a similar grid that uses the generic cr_profile_avatar_selector. It's possible this can be adapted to the ChromeOS situation as well, but I didn't do that since there's the Camera, File, and Old Picture icons that complicate things.

Just for your reference...

https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_profile_avatar_selector/
Ah, thanks. I think I will go ahead and fix this specifically for Settings,
it looks like explicitly focusing the container on navigation will do the
trick.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa

commit 9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Mar 06 20:06:52 2017

MD Settings: Change picture: Focus container

BUG= 668075 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2730873003
Cr-Commit-Position: refs/heads/master@{#454930}

[modify] https://crrev.com/9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa/chrome/browser/resources/settings/people_page/change_picture.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment