New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668072 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Devtools]Certificate window does not open after clicking on 'Open full certificate details' button.

Reported by dmascare...@etouch.net, Nov 23 2016

Issue description

Chrome Version:57.0.2929.0 (Official Build) d78075be67a3ee6520d1f8377cd69b478ebdf5ee-refs/heads/master@{#434071}
OS:Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to https://bugs.chromium.org/p/chromium/issues/list
2. Click on Lock icon and then click on 'Details' link such that devtools gets opened
3. Reload the page and then click on 'https://bugs.chromium.org' option below Main Origin
4. Click on 'Open full certificate details' button and observe.

Actual: Certificate window does not open after clicking on 'Open full certificate details' button.

Expected: Certificate window should open after clicking on 'Open full certificate details' button.

This is a regression issue broken in M-55, below is manual bisect info:

Good Build: 55.0.2851.0 
Bad Build: 55.0.2853.0 

 
Actual_dev.mp4
2.0 MB View Download
Expected_dev.mp4
1.0 MB View Download
Labels: ReleaseBlock-Stable hasbisect-per-revision
Owner: jam@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2851.0 (Revision: 416559).
Bad build: 55.0.2853.0 (Revision: 416812).

You are probably looking for a change made after 416699 (known good), but no later than 416700 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/59086df0374a53915887b36d081fef7f84cead72..8b3813b7f3ac9e197305cc440b78c81773cd07af

@jam -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.

Comment 2 by gov...@chromium.org, Nov 24 2016

Cc: tsepez@chromium.org davidben@chromium.org pfeldman@chromium.org
Adding Cl reviewers (pfeldman@, davidben@,tsepez@) to CC list as jam@ is OOO till 12/02.


 

Comment 3 by gov...@chromium.org, Nov 24 2016

Cc: pbomm...@chromium.org mmoss@chromium.org

Comment 4 by gov...@chromium.org, Nov 24 2016

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch latest by November 28th, 4:00 PM PT in order to make into the desktop Stable final build cut (sooner the better). Thank you!
jam@ Gentle ping! Since this issue is marked as RB stable for M-55, Could you please let us know is there any latest update available for this issue? As per comment #4 we are about to push M-55 to stable channel soon.

Thanks!
Cc: -pfeldman@chromium.org
Owner: pfeldman@chromium.org
Update : Had an offline chat with pfeldman@ and he is working on a fix, hence changing owner's.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922fbf5561c60b6d2239892f73eddcc3a0676aa7

commit 922fbf5561c60b6d2239892f73eddcc3a0676aa7
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Nov 29 00:15:13 2016

DevTools: pick resource with certificate when retrieving cert data.

BUG= 668072 
NOTRY=true

Review-Url: https://codereview.chromium.org/2540493002
Cr-Commit-Position: refs/heads/master@{#434792}

[modify] https://crrev.com/922fbf5561c60b6d2239892f73eddcc3a0676aa7/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Labels: Merge-Request-55
Cc: gov...@chromium.org
Labels: Merge-Request-56
Before we approve merge to M55 branch 2883, could you please make sure this change is well baked/verified in Canary/Dev and safe to merge to M55?

Labels: TE-Verified-57.0.2936.0 TE-Verified-M57
Tested the issue on Latest Canary# 57.0.2936.0 on Windows and Mac and is working as intended.
Able to view the certificate after clicking on "Open full certificate details".
Attaching screen shot for reference.

Note: Linux build is not available as of now. Adding TE-Verified Labels only on Windows and Mac.
Thank You.
668072.png
468 KB View Download
Labels: -Merge-Request-55 Merge-Approved-55
Approving merge to M55 branch 2883 based on comment #12. Please merge ASAP. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 29 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd35b853b29de548eb08d0ff07f0ccbcc9acc26d

commit dd35b853b29de548eb08d0ff07f0ccbcc9acc26d
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Nov 29 18:55:23 2016

DevTools: pick resource with certificate when retrieving cert data.

BUG= 668072 
NOTRY=true

Review-Url: https://codereview.chromium.org/2540493002
Cr-Commit-Position: refs/heads/master@{#434792}
(cherry picked from commit 922fbf5561c60b6d2239892f73eddcc3a0676aa7)

Review URL: https://codereview.chromium.org/2534203002 .

Cr-Commit-Position: refs/branch-heads/2883@{#680}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/dd35b853b29de548eb08d0ff07f0ccbcc9acc26d/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 29 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf05fb214748aad4b8689105b6c3e9edcd7c55c4

commit bf05fb214748aad4b8689105b6c3e9edcd7c55c4
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Nov 29 19:15:53 2016

DevTools: pick resource with certificate when retrieving cert data.

BUG= 668072 
NOTRY=true

Review-Url: https://codereview.chromium.org/2540493002
Cr-Commit-Position: refs/heads/master@{#434792}
(cherry picked from commit 922fbf5561c60b6d2239892f73eddcc3a0676aa7)

Review URL: https://codereview.chromium.org/2537853002 .

Cr-Commit-Position: refs/branch-heads/2924@{#163}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/bf05fb214748aad4b8689105b6c3e9edcd7c55c4/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Status: Fixed (was: Assigned)
Labels: TE-Verified-M55 TE-Verified-55.0.2883.71
Verified this issue on Windows-10, Mac OS 10.12 and Ubuntu 14.04 using chrome latest M55-55.0.2883.71 by following steps mentioned in the original comment. Observed certificate window opens after clicking on 'Open full certificate details' button as expected. Hence adding TE-Verified label.

Thanks!
Screen Shot 2016-11-30 at 12.43.53 PM.png
351 KB View Download

Comment 18 by dimu@chromium.org, Nov 30 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
Labels: -Merge-Review-56 Merge-Approved-56
M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.Please merge your change ASAP so that we could take it for next Release.
Project Member

Comment 21 by sheriffbot@chromium.org, Dec 4 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 22 Deleted

If there is no pending work please remove Merge-Approved-56 label
Project Member

Comment 24 by sheriffbot@chromium.org, Dec 7 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-56

Sign in to add a comment