"ContentVerifierPolicyTest.PolicyCorruptedOnStartup" is flaky |
||||
Issue description"ContentVerifierPolicyTest.PolicyCorruptedOnStartup" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 37 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJDb250ZW50VmVyaWZpZXJQb2xpY3lUZXN0LlBvbGljeUNvcnJ1cHRlZE9uU3RhcnR1cAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 23 2016
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408f7ef83c1436ec6837829a8c0ed184f073094e commit 408f7ef83c1436ec6837829a8c0ed184f073094e Author: asargent <asargent@chromium.org> Date: Wed Nov 23 19:20:18 2016 Disable ContentVerifierPolicyTest.PolicyCorruptedOnStartup test This test has been flaky since landing - this CL disables it so I can investigate the cause of the problem without impacting the tree. TBR=lazyboy@chromium.org BUG= 668067 Review-Url: https://codereview.chromium.org/2527693003 Cr-Commit-Position: refs/heads/master@{#434220} [modify] https://crrev.com/408f7ef83c1436ec6837829a8c0ed184f073094e/chrome/browser/extensions/content_verifier_browsertest.cc
,
Nov 23 2016
,
Nov 23 2016
Thanks for disabling the test in #c3.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba52f3250a997eaee8663d6731819431bca18a71 commit ba52f3250a997eaee8663d6731819431bca18a71 Author: asargent <asargent@chromium.org> Date: Wed Nov 30 18:26:06 2016 Fix flaky test ContentVerifierPolicyTest.PolicyCorruptedOnStartup The way this test works is that the PRE_ test disables a policy force installed extension due to corruption, and then the regular test checks that it gets properly reinstalled after startup. It turns out that the reinstall gets scheduled pretty early on during startup - in ExtensionService::CheckForExternalUpdates which happens after SetUpInProcessBrowserTestFixture, and on the build waterfall that sometimes completes before SetUpOnMainThread of the tesst runs, let alone when the regular test body runs. On a local development machine I wasn't able to reproduce this unless I induced a lot of extra load using stress-ng. So the fix is to switch the test from assuming the install will happen during the regular test body to first checking whether it already happened before the start of the test, and only waiting for it if it hadn't already happened. BUG= 668067 Review-Url: https://codereview.chromium.org/2537623002 Cr-Commit-Position: refs/heads/master@{#435344} [modify] https://crrev.com/ba52f3250a997eaee8663d6731819431bca18a71/chrome/browser/extensions/content_verifier_browsertest.cc
,
Nov 30 2016
Optimistically marking as fixed |
||||
►
Sign in to add a comment |
||||
Comment 1 by lukasza@chromium.org
, Nov 23 2016