"HandsOffNetworkScreenTest.RequiresNoInput" is flaky |
|||||||||
Issue description"HandsOffNetworkScreenTest.RequiresNoInput" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilIYW5kc09mZk5ldHdvcmtTY3JlZW5UZXN0LlJlcXVpcmVzTm9JbnB1dAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 23 2016
I will disable it. Thanks for info.
,
Nov 23 2016
Sending the CL (https://codereview.chromium.org/2529683002) to queue
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cb3a959909e34f0053c4c653c5e99669d30e56b commit 6cb3a959909e34f0053c4c653c5e99669d30e56b Author: kolos <kolos@chromium.org> Date: Wed Nov 23 16:46:40 2016 Disable HandsOffNetworkScreenTest.RequiresNoInput test The test is flaky. BUG= 668054 TBR=kumarniranjan@google.com,piman@chromium.org Review-Url: https://codereview.chromium.org/2529683002 Cr-Commit-Position: refs/heads/master@{#434184} [modify] https://crrev.com/6cb3a959909e34f0053c4c653c5e99669d30e56b/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc
,
Nov 23 2016
kumarniranjan@, could you please investigate and/or find a better owner (I am assigning to you since you are the last person to modify chrome/browser/chromeos/login/screens/network_screen_browsertest.cc). Also CC-ing a few other people who have been touching the test source file and/or work on ChromeOS (ygorshenin@, satorux@). Since the test is disabled and assigned to a (tentative) owner, let me remove the bug from the sheriff queue.
,
Nov 23 2016
xiyuan@, could you take a look? (since you've made some recent changes under chrome/browser/chromeos/login/screens) I am reassigning, because (not sure why) monorail says "user never visited" about kumarniranjan@...
,
Nov 23 2016
I wrote this test and it worked consistently on my machine. It always ran in less than 30 seconds. However, I understand that our testing environment differs somewhat from local development environments, and this may affect the speed at which certain things run. I will work on making this test more reliable in the testing environment. Thank you for bringing this to my attention.
,
Nov 24 2016
I now have a CL to fix this. https://codereview.chromium.org/2526423002/
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/368ac3b055c023a43486a7638359fa63b30cc1fe commit 368ac3b055c023a43486a7638359fa63b30cc1fe Author: kumarniranjan <kumarniranjan@google.com> Date: Sat Dec 03 00:12:33 2016 Fixed flaky test The test HandsOffNetworkScreenTest.RequiresNoInput was flaky. Made some changes to fix that. BUG= 668054 TEST=browser test Review-Url: https://codereview.chromium.org/2526423002 Cr-Commit-Position: refs/heads/master@{#436089} [modify] https://crrev.com/368ac3b055c023a43486a7638359fa63b30cc1fe/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc
,
Dec 5 2016
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by treib@chromium.org
, Nov 23 2016Labels: OS-Chrome
Status: Available (was: Untriaged)