New issue
Advanced search Search tips

Issue 668042 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Wavy decoration shold continue across element boundaries

Project Member Reported by drott@chromium.org, Nov 23 2016

Issue description

Spun off from  issue 548798 .

In http://fiddle.jshell.net/ydpLhrag/1/ the wavy decoration for the link underline in the first section should continue homogenously across the whole link element, not be divided by the <em> nested tag.

Using Paint component, for lack of a better one. Suggestions welcome.

Christian, do we have a label for something like a LayoutNG related hotlist? 
 
AFAIK we have no way to label LayoutNG bugs, no.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
This seems super hard to fix. It would require gathering neighboring line boxes into one for the purposes of painting the decoration. I suppose we could draw it at a higher level in the layout tree, but maybe would that mean detecting our own line breaks etc.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
The Chromium implementation for rendering a wavy underline is to "round down to the nearest wavelength". It occurs regardless of <em> tags et al. It will even do the wavelength-rounding twice for wavy-underlined text that word wraps - once at the end of the line and the other at the end of the wavy-underlined text on the second line.

Comment 6 by e...@chromium.org, Jan 5 2018

With LayoutNG we'll have a data model that will allow us to do something about this. It'll still be hard but at least it'll be possible unlike in the current model where the lineboxes doesn't have the information needed.
Chromium correctly marks spellcheck errors with a complete red wavy underline. I'm looking at it now in this textarea element, even if I modify font-family to any of {monospace, cursive, fantasy, sans-serif, serif}...

Chromium on the podium of odium
Chromuim on the padium ofodium
Chremium ov the qopium fo olium

The spellcheck-marking code should therefore give insights on how to correctly apply complete wavy underline styles to other elements.

In certain Apps the current implementation is unusable. Refer to image.

PS: I also noticed today that if only one wave is displayed, it's wavelength is longer than the wavelength when displaying multiple waves.
wavelength.png
6.7 KB View Download

Sign in to add a comment