New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668039 link

Starred by 3 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Dec 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
w...@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ msrchandra@chromium.org
█ durga.behera@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Media Router ephemeral icon shows up in the overflow menu every other time in guest/incognito mode

Project Member Reported by sc00335...@techmahindra.com, Nov 23 2016 
Version: 57.0.2928.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and browse as guest >> Right click and select cast option and observe focus on wrench menu
(2)Close cast overlay and again right click and select cast option and observe focus on wrench menu

Expected: Focus should not be seen in wrench menu.
Actual: Unwanted focus is seen on wrench menu on opening cast overlay.

This is a regression issue broken in M56.
Actual_hover on wrench menu.ogv
904 KB View Download

Comment 1 Deleted

Comment 2 by brajkumar@chromium.org, Nov 23 2016 

Able to reproduce the issue on Mac 10.12 using chrome latest Dev #57.0.2926.0, Observed focus highlight seen on cast icon.

Comment 3 by brajkumar@chromium.org, Nov 23 2016

Labels: -Needs-Bisect hasbisect-per-revision
Owner: taku...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2915.0 
Bad build: 56.0.2916.0 

You are probably looking for a change made after 431295 (known good), but no later than 431296 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/116138bad2403c5f51580005842f226beab0bf2e..89fc2a78d69cb432b445da453fd3f6fd02d4ebfe

@takumif - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by brajkumar@chromium.org, Nov 24 2016

Cc: msrchandra@chromium.org w...@chromium.org nyerramilli@chromium.org
 Issue 668430  has been merged into this issue.

Comment 5 by taku...@chromium.org, Nov 30 2016

Labels: -Pri-1 Pri-2
Summary: Regression: Media Router ephemeral icon shows up in the overflow menu every other time in guest/incognito mode (was: Regression: Unwanted focus highlight is seen on wrench menu icon on selecting cast option)

Comment 6 by sko...@chromium.org, Dec 1 2016

Labels: -M-56 M-57
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a17a81205b7482b758b8fdad29aa7d759742f50

commit 3a17a81205b7482b758b8fdad29aa7d759742f50
Author: takumif <takumif@chromium.org>
Date: Thu Dec 01 19:26:12 2016

Ensure that new toolbar actions added to incognito toolbars become visible

When a new action is added to the incognito toolbar (which can happen with the
Media Router component action), it should become visible regardless of the state
of the non-incognito toolbar. This change ensures that and adds a unit test.

BUG= 668039 

Review-Url: https://codereview.chromium.org/2539153003
Cr-Commit-Position: refs/heads/master@{#435675}

[modify] https://crrev.com/3a17a81205b7482b758b8fdad29aa7d759742f50/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/3a17a81205b7482b758b8fdad29aa7d759742f50/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Comment 8 by taku...@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment