chrome.input.ime.setComposition API doesn't work with empty text |
||||||||
Issue descriptionVersion: R56 OS: Linux What steps will reproduce the problem? (1) Installs the extension https://chrome.google.com/webstore/detail/google-input-tools/mclkkofklkfljcocdinagocijmpgbhab (2) Enables & activates the Chinese Pinyin IME. (3) Typing 'a' and then pressing ESC key. What is the expected result? The candidate window is hidden, and the composition text "a" is removed. What happens instead? The candidate window is hidden, but the composition text "a" is not removed.
,
Nov 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89a156914461e445488deeca97a453997540e010 commit 89a156914461e445488deeca97a453997540e010 Author: shuchen <shuchen@chromium.org> Date: Fri Nov 25 02:35:49 2016 Makes delay commitText/setComposition can deal with empty text/composition. BUG= 668036 Review-Url: https://codereview.chromium.org/2525723005 Cr-Commit-Position: refs/heads/master@{#434426} [modify] https://crrev.com/89a156914461e445488deeca97a453997540e010/chrome/browser/ui/input_method/input_method_engine.cc [modify] https://crrev.com/89a156914461e445488deeca97a453997540e010/chrome/browser/ui/input_method/input_method_engine_base.cc [modify] https://crrev.com/89a156914461e445488deeca97a453997540e010/chrome/browser/ui/input_method/input_method_engine_base.h
,
Nov 25 2016
,
Nov 26 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4008e8aaf220567fca23db9fcec633318ee495aa commit 4008e8aaf220567fca23db9fcec633318ee495aa Author: Shu Chen <shuchen@google.com> Date: Mon Nov 28 01:03:51 2016 Makes delay commitText/setComposition can deal with empty text/composition. BUG= 668036 Review-Url: https://codereview.chromium.org/2525723005 Cr-Commit-Position: refs/heads/master@{#434426} (cherry picked from commit 89a156914461e445488deeca97a453997540e010) Review URL: https://codereview.chromium.org/2532803002 . Cr-Commit-Position: refs/branch-heads/2924@{#104} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/4008e8aaf220567fca23db9fcec633318ee495aa/chrome/browser/ui/input_method/input_method_engine.cc [modify] https://crrev.com/4008e8aaf220567fca23db9fcec633318ee495aa/chrome/browser/ui/input_method/input_method_engine_base.cc [modify] https://crrev.com/4008e8aaf220567fca23db9fcec633318ee495aa/chrome/browser/ui/input_method/input_method_engine_base.h
,
Nov 28 2016
,
Nov 28 2016
,
Nov 29 2016
Tested in chrome dev #56.0.2924.10 on Windows 10 & Ubuntu 14.04 and observed that the issue is still reproducible 1.The composition text "a" is not removed. Attached a screen cast for reference, please let me know if i have missed anything. Thank you!
,
Nov 30 2016
Looks like 56.0.2924.10 has not included the fix cl yet. You need to enable an IME in the extension, click the extension icon and click the gear button in the popup menu, which will pop up the settings page. From there, select an IME, e.g. Chinese Pinyin. Wait for a while to let the language model data being downloaded, and then type in an input field, which will trigger the popup candidate window and composition text. And then, press Escape key.
,
Nov 30 2016
Tested in chrome dev #56.0.2924.10 on Windows 10 & Ubuntu 14.04 as per comment#10 steps.composition text "a" is removed.Please find the screen shot for reference.Hence adding TE-Verified label. Thank You! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by shuchen@chromium.org
, Nov 23 2016