New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668035 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Auto-scrolling is seen missing in Keyboard/Network list of Uber tray on using tab key .

Project Member Reported by jbanavatu@chromium.org, Nov 23 2016

Issue description

Version: 57.0.2926.0/9014.0.0 dev-channel Paine, Falco, Gnawty
OS:Chrome.

Pre-condition:Select any uber tray option which has long list such that scrollbar will be seen. 

What steps will reproduce the problem?
(1)Recover build via USB/Sign in to chrome>> Go to Uber tray and select keyboard/Network option
(2)Now hit tab till you reach to the bottom option and Observe (Please refer video)

Expected: As you reach to the bottom options keyboard/network list should be auto-scrolled accordingly.
Actual: Instead auto-scrolling is seen missing.
(Only focus is getting shifted but options are not seen until you manually scroll using touch-pad/by dragging the scrollbar.)

This is regression issue as it is working fine in 54.0.2840.101/8743.85.0 stable channel butterfly

Attaching screen-cast for reference.
 
Expected.mp4
8.6 MB View Download
Actual.mp4
9.2 MB View Download
Summary: Regression: Auto-scrolling is seen missing in Keyboard/Network list of Uber tray on using tab key . (was: Regression: Auto-scroll of Keyboard/Network list is seen missing in Uber tray upon using tab key .)
Labels: -ReeaseBlock-Stable ReleaseBlock-Stable
Components: Blink>Scroll
Cc: tbuck...@chromium.org
Components: -Blink>Scroll
Owner: tdander...@chromium.org
Status: Assigned (was: Untriaged)
Not blink related

Not convinced this should be a release blocker
Cc: tdander...@chromium.org
Components: UI>Input>Text>IME
Labels: -ReleaseBlock-Stable -M-57 Proj-MaterialDesign-CrOS M-56
Owner: azurewei@chromium.org
Agreed this is not a release blocker. I suspect this actually regressed in M-55 when the opt-in IME menu refactoring took place; on canary I do not see the same issue on other detailed views (the network detailed view, for instance).

azurewei@, can you please take a look? Let's consider for a merge back into M-56 if the fix is low-risk.
Status: Started (was: Assigned)
I wonder if it relates to the shadow at top of TrayDetailsView when scrolled. It seems not related to opt-in IME menu refactoring since network list also repo the bug. 
Let me debug and find out what goes wrong.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6

commit c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6
Author: azurewei <azurewei@chromium.org>
Date: Thu Dec 01 00:34:36 2016

Scroll IME list to visible when using tab key.

When switches the focused IME item with Tab key, scroll the IME detailed view to make the focused item visible.

BUG= 668035 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2537893003
Cr-Commit-Position: refs/heads/master@{#435494}

[modify] https://crrev.com/c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6/ash/common/system/chromeos/ime_menu/ime_list_view.cc

Labels: Merge-Approved-56
Labels: -Merge-Approved-56 Merge-Request-56
Labels: Merge-Approved-56

Comment 11 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Status: Fixed (was: Started)
Cherrypicked with CL: https://codereview.chromium.org/2549673003/
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 2 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4756740d27df15f3035530810333aaca3d8e9db

commit e4756740d27df15f3035530810333aaca3d8e9db
Author: azurewei <azurewei@chromium.org>
Date: Fri Dec 02 03:20:38 2016

Scroll IME list to visible when using tab key.

When switches the focused IME item with Tab key, scroll the IME detailed view to make the focused item visible.

TBR=tdanderson@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 668035 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2537893003
Cr-Commit-Position: refs/heads/master@{#435494}
(cherry picked from commit c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6)

Review-Url: https://codereview.chromium.org/2549673003
Cr-Commit-Position: refs/branch-heads/2924@{#282}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/e4756740d27df15f3035530810333aaca3d8e9db/ash/common/system/chromeos/ime_menu/ime_list_view.cc

Status: Verified (was: Fixed)
Verified on 56.0.2924.28/9000.29.0

Sign in to add a comment