DevTools failed to save HAR due to null pointer in inspector.js
Reported by
yeh.jul...@gmail.com,
Nov 23 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Steps to reproduce the problem: 1. Remote debug on a Android phone which loading "weather.com" 2. Save the network log as HAR 3. The saved file size is 0KB What is the expected behavior? Devtools saves HAR successfully What went wrong? We "inspect" the DevTools, it showed a error log: inspector.js:1557 TypeError: Cannot read property 'pageLoadForRequest' of null TypeError: Cannot read property 'pageLoadForRequest' of null at WebInspector.HARLog._buildPages (inspector.js:6011) at WebInspector.HARLog.build (inspector.js:6009) at WebInspector.HARWriter.write (network_module.js:83) at WebInspector.NetworkLogView.openCallback (network_module.js:500) at WebInspector.FileOutputStream.callbackWrapper (inspector.js:8625) at WebInspector.FileManager._invokeSaveCallback (inspector.js:7510) at WebInspector.FileManager._savedURL (inspector.js:7508) at WebInspector.Object.dispatchEventToListeners (inspector.js:738) at innerDispatch (inspector.js:1557) at InspectorFrontendAPIImpl._dispatch (inspector.js:1556) We also trace the inspector.js, and found it was accessing a request "service-worker.js" which don't have the "_networkLog" property Did this work before? N/A Chrome version: 54.0.2840.85 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 23.0 r0
,
Dec 1 2016
,
Dec 7 2016
,
Dec 15 2016
,
Jan 5 2017
Hello all, Is there any update on ETA for the fix?
,
Jan 6 2017
Yes, I put together a patch last month, but got bogged down with some technical details. I have a CL that should be passable here: https://codereview.chromium.org/2616023003/ I'll push it to M-56 when I get an lgtm + 1 week.
,
Jan 10 2017
allada@ - Could you please provide any update on this issue as it has been marked as a release block stable. Thanks...!!
,
Jan 19 2017
It's committing now here: https://codereview.chromium.org/2628693002/ It got caught up in the holidays.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf6bde6fff78674429a4543d4aac2d536c1661ea commit cf6bde6fff78674429a4543d4aac2d536c1661ea Author: allada <allada@chromium.org> Date: Thu Jan 19 02:47:40 2017 [Devtools] Move initiator data into NetworkLog from NetworkRequest This patch moves request initiator info into NetworkLog. R=dgozman BUG= 668032 Review-Url: https://codereview.chromium.org/2628693002 Cr-Commit-Position: refs/heads/master@{#444606} [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js [modify] https://crrev.com/cf6bde6fff78674429a4543d4aac2d536c1661ea/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
,
Jan 20 2017
My TL said we should hold off on this and not push it out till M-57.
,
Jan 20 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 23 2017
Cl listed at #9 is {#444606} and M57 is branched Chromium at revision {#444943}, so no merge is needed to M57. Hence, removing Merge-TBD label.
,
Feb 20 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lushnikov@chromium.org
, Nov 23 2016Status: Assigned (was: Unconfirmed)