New issue
Advanced search Search tips

Issue 668021 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Presubmit check fails in _CheckBowerDependencies with unexpected keyword argument to AffectedFiles

Project Member Reported by michae...@chromium.org, Nov 23 2016

Issue description

third_party/polymer/v1_0/PRESUBMIT.py probably just needs to be updated.

~/dev/c/work3/src % git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
Done processing /usr/local/google/home/michaelpg/dev/c/work3/src/chrome/browser/ui/webui/settings/md_settings_ui.cc
Traceback (most recent call last):
  File "/usr/local/google/home/michaelpg/tools/depot_tools/git_cl.py", line 5403, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/michaelpg/tools/depot_tools/git_cl.py", line 5385, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/michaelpg/tools/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/michaelpg/tools/depot_tools/git_cl.py", line 4210, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/michaelpg/tools/depot_tools/git_cl.py", line 1592, in CMDUpload
    change=change)
  File "/usr/local/google/home/michaelpg/tools/depot_tools/git_cl.py", line 1536, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/usr/local/google/home/michaelpg/tools/depot_tools/presubmit_support.py", line 1247, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/michaelpg/tools/depot_tools/presubmit_support.py", line 1157, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 53, in CheckChangeOnUpload
  File "<string>", line 20, in _CheckBowerDependencies
TypeError: AffectedFiles() got an unexpected keyword argument 'include_dirs'

 

Comment 1 by dbeam@chromium.org, Nov 23 2016

Owner: michae...@chromium.org
Status: Assigned (was: Untriaged)
maybe you meant include_deletes=True?
https://codereview.chromium.org/1221923003/diff/130001/third_party/polymer/v1_0/PRESUBMIT.py

Comment 2 by dbeam@chromium.org, Nov 29 2016

Cc: michae...@chromium.org dbeam@chromium.org
 Issue 669584  has been merged into this issue.

Comment 3 by dbeam@chromium.org, Nov 29 2016

Cc: aga...@chromium.org
include_dirs= was removed here

https://codereview.chromium.org/2394043002/

so maybe we just remove the key?

Comment 4 by dbeam@chromium.org, Nov 29 2016

Cc: -michae...@chromium.org dpa...@chromium.org

Comment 5 by dbeam@chromium.org, Nov 29 2016

Cc: -dpa...@chromium.org michae...@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7383f00039f3d3a10e76e714e51b69e9b9750309

commit 7383f00039f3d3a10e76e714e51b69e9b9750309
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 30 02:04:43 2016

MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG= 664433 , 668021 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2526053002
Cr-Commit-Position: refs/heads/master@{#435124}

[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/PRESUBMIT.py
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/web-animations-js/sources/.bower.json

Comment 7 by dbeam@chromium.org, Nov 30 2016

Status: Fixed (was: Started)

Sign in to add a comment