New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668013 link

Starred by 1 user
Status: Verified
Owner:
azurewei@chromium.org
Closed: Nov 2016
Cc:
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Show a virtual keyboard toggle for opt-in IME menu.

Project Member Reported by azurewei@chromium.org, Nov 23 2016 
Version: 57.0.2926.0 canary 
OS: ChromeOS

What steps will reproduce the problem?
(1) Checked <Show input options in the shelf> 
(2) Open opt-in menu in shelf in TouchView
(3) Plug in an external

What is the expected result?
The virtual keyboard will be disabled by default. Needs a 'On-screen keyboard' toggle (see in System IME menu) to let users enable the VK again.

What happens instead?
No VK toggle button.

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb9e7720d5a4ddaef6ce257f4d252a831bea688

commit 1fb9e7720d5a4ddaef6ce257f4d252a831bea688
Author: azurewei <azurewei@chromium.org>
Date: Wed Nov 23 06:29:11 2016

Add virtual keyboard item into opt-in IME menu.

The 'Smart deploy toggle' is always hidden in opt-in IME menu. We should show/hide it based on the vr and devices state.
Make ImeMenuTray listens on the virtual keyboard state to show the toggle.
Currently the ImeMenuBubble doesn't support update UI. So if there's state change (which leads to UI change) of the VK, just hide the bubble.

BUG= 668013 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2474843002
Cr-Commit-Position: refs/heads/master@{#434127}

[modify] https://crrev.com/1fb9e7720d5a4ddaef6ce257f4d252a831bea688/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/1fb9e7720d5a4ddaef6ce257f4d252a831bea688/ash/common/system/chromeos/ime_menu/ime_menu_tray.h

Comment 2 by tdander...@chromium.org, Nov 23 2016

Components: UI>Shell>Shelf UI>Input>Text>IME
Labels: Proj-MaterialDesign-CrOS M-56 OS-Chrome
Status: Started (was: Assigned)

Comment 3 by azurewei@chromium.org, Nov 28 2016

Labels: Merge-Request-56
Status: Fixed (was: Started)

Comment 4 by dimu@chromium.org, Nov 28 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)

Comment 5 by tdander...@chromium.org, Nov 28 2016

Status: Started (was: Fixed)
Let's leave open until the merge into 56 is complete.

Verified on 57.0.2933.0 canary, will perform the merge shortly.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1511d6037dd138d551a42c36e21264cd4428aa9d

commit 1511d6037dd138d551a42c36e21264cd4428aa9d
Author: Terry Anderson <tdanderson@chromium.org>
Date: Mon Nov 28 22:09:30 2016

Add virtual keyboard item into opt-in IME menu.

The 'Smart deploy toggle' is always hidden in opt-in IME menu. We should show/hide it based on the vr and devices state.
Make ImeMenuTray listens on the virtual keyboard state to show the toggle.
Currently the ImeMenuBubble doesn't support update UI. So if there's state change (which leads to UI change) of the VK, just hide the bubble.

BUG= 668013 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2474843002
Cr-Commit-Position: refs/heads/master@{#434127}
(cherry picked from commit 1fb9e7720d5a4ddaef6ce257f4d252a831bea688)

Review URL: https://codereview.chromium.org/2536003002 .

Cr-Commit-Position: refs/branch-heads/2924@{#134}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1511d6037dd138d551a42c36e21264cd4428aa9d/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/1511d6037dd138d551a42c36e21264cd4428aa9d/ash/common/system/chromeos/ime_menu/ime_menu_tray.h

Comment 7 by tdander...@chromium.org, Nov 28 2016

Status: Fixed (was: Started)

Comment 8 by sdantul...@chromium.org, Jan 5 2017

Status: Verified (was: Fixed)
Verified on ChromeOS 9000.50.0, 56.0.2924.53
►

Sign in to add a comment