New issue
Advanced search Search tips

Issue 668012 link

Starred by 7 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 752745

Blocking:
issue 545324



Sign in to add a comment

Project Ribbon in the Parser

Project Member Reported by aazzam@google.com, Nov 23 2016

Issue description

In order to move property-specific logic out of the parser, we want to design implement a property interface that which includes parser methods, and property API's which implement these methods.

A design doc for this can be found at https://docs.google.com/a/google.com/document/d/1R2qiaQJ-SKkTTvnoUkuT9f-dmk5GlhzcvzeQj3iQaUY/edit?usp=sharing
 
Showing comments 104 - 203 of 203 Older
Project Member

Comment 104 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb

commit 16f5c5b2155faa46890e2c5ad18bd27f7c506deb
Author: bugsnash <bugsnash@chromium.org>
Date: Thu Apr 06 07:01:30 2017

Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462379}

[modify] https://crrev.com/16f5c5b2155faa46890e2c5ad18bd27f7c506deb/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/16f5c5b2155faa46890e2c5ad18bd27f7c506deb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/16f5c5b2155faa46890e2c5ad18bd27f7c506deb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp

Project Member

Comment 105 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912e5f787ee415f874928b9684ea50dc75f85d40

commit 912e5f787ee415f874928b9684ea50dc75f85d40
Author: bugsnash <bugsnash@chromium.org>
Date: Thu Apr 06 07:04:39 2017

Changed CSSParserContext argument from * to & for null safety.

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

Note that this patch changes the syntax inside parseSingleValue
implementations to get the address of CSSParserContext references to pass to
utility methods that still expect a pointer. Future patches should change these
utility methods to also take references instead of pointers, at which point the
syntax inside parseSingleValue implementations can be changed back to pass the
object.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
  CSSPropertyAPIMethods.json5 so that the generated API header files (including
  the base class header file) would update
- changed the parameter in each of the .cpp files for the property APIs in
  core/css/properties
- updated the single call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
  reference syntax

Diff of generated files:
https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2786153004
Cr-Commit-Position: refs/heads/master@{#462380}

[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifySelf.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaselineShift.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnCount.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnGap.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnRuleWidth.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnSpan.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContain.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSize.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantCaps.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantLigatures.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFragmentation.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoFlow.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImage.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifyItems.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeight.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrder.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineColor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineOffset.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineWidth.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPadding.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintStroke.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIQuotes.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRadius.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScale.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeImageThreshold.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeMargin.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPISize.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeMiterlimit.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITabSize.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationColor.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationSkip.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextIndent.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextSizeAdjust.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITouchAction.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransformOrigin.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVerticalAlign.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlexGroup.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitFontSizeDelta.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaxLogicalWidthOrHeight.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitPadding.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeWidth.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTransformOriginZ.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZIndex.cpp
[modify] https://crrev.com/912e5f787ee415f874928b9684ea50dc75f85d40/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp

Project Member

Comment 106 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7aae4a78d2902cb83671f7ef7792b14180ee462

commit b7aae4a78d2902cb83671f7ef7792b14180ee462
Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Apr 06 07:33:50 2017

Revert of Changed CSSParserContext argument from * to & for null safety. (patchset #4 id:60001 of https://codereview.chromium.org/2786153004/ )

Reason for revert:

Findit identified CL at revision 462380 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkxMmU1Zjc4N2VlNDE1Zjg3NDkyOGI5Njg0ZWE1MGRjNzVmODVkNDAM

Original issue's description:
> Changed CSSParserContext argument from * to & for null safety.
>
> Changed the CSSParserContext argument to the parseSingleValue method in
> the property APIs from a pointer to a reference to ensure that nullptr
> cannot be passed.
>
> Note that this patch changes the syntax inside parseSingleValue
> implementations to get the address of CSSParserContext references to pass to
> utility methods that still expect a pointer. Future patches should change these
> utility methods to also take references instead of pointers, at which point the
> syntax inside parseSingleValue implementations can be changed back to pass the
> object.
>
> This patch:
> - changed the CSSParserContext parameter to parseSingleValue in
>   CSSPropertyAPIMethods.json5 so that the generated API header files (including
>   the base class header file) would update
> - changed the parameter in each of the .cpp files for the property APIs in
>   core/css/properties
> - updated the single call site in CSSPropertyParser.cpp
> - updated the implementations of parseSingleValue in the property APIs to use
>   reference syntax
>
> Diff of generated files:
> https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions
>
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2786153004
> Cr-Commit-Position: refs/heads/master@{#462380}
> Committed: https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea50dc75f85d40

TBR=shend@chromium.org,meade@chromium.org,bugsnash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012

Review-Url: https://codereview.chromium.org/2801893003
Cr-Commit-Position: refs/heads/master@{#462383}

[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifySelf.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaselineShift.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnCount.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnGap.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnRuleWidth.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnSpan.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContain.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSize.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantCaps.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantLigatures.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFragmentation.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoFlow.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImage.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifyItems.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeight.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrder.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineColor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineOffset.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineWidth.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPadding.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintStroke.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIQuotes.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRadius.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScale.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeImageThreshold.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeMargin.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPISize.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeMiterlimit.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITabSize.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationColor.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationSkip.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextIndent.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextSizeAdjust.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITouchAction.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransformOrigin.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVerticalAlign.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlexGroup.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitFontSizeDelta.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaxLogicalWidthOrHeight.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitPadding.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeWidth.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTransformOriginZ.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZIndex.cpp
[modify] https://crrev.com/b7aae4a78d2902cb83671f7ef7792b14180ee462/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp

Project Member

Comment 107 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68471e6f7e1d8570d209ab7221bced498e262d6

commit c68471e6f7e1d8570d209ab7221bced498e262d6
Author: awdf <awdf@chromium.org>
Date: Thu Apr 06 07:35:21 2017

Revert of Implemented parseSingleValue in CSSPropertyAPICounterIncrement.
(patchset #4 id:60001 of https://codereview.chromium.org/2783543002/ )

Reason for revert:
LIkely cause of compile failure on Android builders:

const blink::CSSParserContext*)' does not match any in class 'blink::CSSPropertyAPICounterIncrement'
 const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue(
                 ^

Original issue's description:
> Implemented parseSingleValue in CSSPropertyAPICounterIncrement.
>
> Part of Project Ribbon, separating the parsing logic for CSS
> properties from the parser into an API.
>
> This patch
> - added parseSingleValue method to the CSSPropertyAPICounterIncrement
>   API, with parsing logic from CSSPropertyParser
> - removed CSSPropertyCounterIncrement from the switch statement in
>   CSSPropertyParser::parseSingleValue, calling the API instead using
>   a CSSPropertyDescriptor
> - added parseSingleValue to counter-increment in CSSProperties.json5
>   so it will be added to the generated files for the api
>
> Diff in generated CSSPropertyAPICounterIncrement.h:
> https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
> Diff in generated CSSPropertyDescriptor.cpp:
> https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions
>
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2783543002
> Cr-Commit-Position: refs/heads/master@{#462379}
> Committed: https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb

TBR=ericwilligers@chromium.org,meade@chromium.org,bugsnash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012

Review-Url: https://codereview.chromium.org/2801023002
Cr-Commit-Position: refs/heads/master@{#462384}

[modify] https://crrev.com/c68471e6f7e1d8570d209ab7221bced498e262d6/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/c68471e6f7e1d8570d209ab7221bced498e262d6/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/c68471e6f7e1d8570d209ab7221bced498e262d6/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp

Project Member

Comment 108 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b7ef119f3fccf1aecf18202637ae3d36abda692

commit 9b7ef119f3fccf1aecf18202637ae3d36abda692
Author: nainar <nainar@chromium.org>
Date: Thu Apr 06 23:51:42 2017

Add generated CSSPropertyAPIFragmentation.h file to core/BUILD.gn

Follow up to https://codereview.chromium.org/2639303004

BUG=668012

Review-Url: https://codereview.chromium.org/2752563002
Cr-Commit-Position: refs/heads/master@{#462689}

[modify] https://crrev.com/9b7ef119f3fccf1aecf18202637ae3d36abda692/third_party/WebKit/Source/core/BUILD.gn

Project Member

Comment 109 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef

commit 3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef
Author: bugsnash <bugsnash@chromium.org>
Date: Fri Apr 07 00:05:58 2017

Reland of Changed CSSParserContext argument from * to & for null safety. (patchset #1 id:1 of https://codereview.chromium.org/2801893003/ )

Reason for revert:
This patch was reverted for breaking tests when it was landed at the same time as a clashing patch https://codereview.chromium.org/2783543002/. Both of these patches were reverted.

Landing them one at a time and rebasing should solve the problem.

Original issue's description:
> Revert of Changed CSSParserContext argument from * to & for null safety. (patchset #4 id:60001 of https://codereview.chromium.org/2786153004/ )
>
> Reason for revert:
>
> Findit identified CL at revision 462380 as the culprit for
> failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkxMmU1Zjc4N2VlNDE1Zjg3NDkyOGI5Njg0ZWE1MGRjNzVmODVkNDAM
>
> Original issue's description:
> > Changed CSSParserContext argument from * to & for null safety.
> >
> > Changed the CSSParserContext argument to the parseSingleValue method in
> > the property APIs from a pointer to a reference to ensure that nullptr
> > cannot be passed.
> >
> > Note that this patch changes the syntax inside parseSingleValue
> > implementations to get the address of CSSParserContext references to pass to
> > utility methods that still expect a pointer. Future patches should change these
> > utility methods to also take references instead of pointers, at which point the
> > syntax inside parseSingleValue implementations can be changed back to pass the
> > object.
> >
> > This patch:
> > - changed the CSSParserContext parameter to parseSingleValue in
> >   CSSPropertyAPIMethods.json5 so that the generated API header files (including
> >   the base class header file) would update
> > - changed the parameter in each of the .cpp files for the property APIs in
> >   core/css/properties
> > - updated the single call site in CSSPropertyParser.cpp
> > - updated the implementations of parseSingleValue in the property APIs to use
> >   reference syntax
> >
> > Diff of generated files:
> > https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions
> >
> > BUG=668012
> >
> > Review-Url: https://codereview.chromium.org/2786153004
> > Cr-Commit-Position: refs/heads/master@{#462380}
> > Committed: https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea50dc75f85d40
>
> TBR=shend@chromium.org,meade@chromium.org,bugsnash@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2801893003
> Cr-Commit-Position: refs/heads/master@{#462383}
> Committed: https://chromium.googlesource.com/chromium/src/+/b7aae4a78d2902cb83671f7ef7792b14180ee462

TBR=meade@chromium.org,lukasza@google.com,jkrcal@google.com,foolip@google.com,ellyjones@google.com,shend@chromium.org,findit-for-me@appspot.gserviceaccount.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012

Review-Url: https://codereview.chromium.org/2805153002
Cr-Commit-Position: refs/heads/master@{#462696}

[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifySelf.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaselineShift.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnCount.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnGap.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnRuleWidth.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnSpan.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContain.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSize.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantCaps.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantLigatures.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFragmentation.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoFlow.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImage.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifyItems.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeight.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrder.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineColor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineOffset.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineWidth.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPadding.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintStroke.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIQuotes.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRadius.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScale.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeImageThreshold.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeMargin.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPISize.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeMiterlimit.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITabSize.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationColor.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationSkip.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextIndent.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextSizeAdjust.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITouchAction.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransformOrigin.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVerticalAlign.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlexGroup.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitFontSizeDelta.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaxLogicalWidthOrHeight.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitPadding.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeWidth.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTransformOriginZ.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZIndex.cpp
[modify] https://crrev.com/3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp

Project Member

Comment 110 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d

commit a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d
Author: bugsnash <bugsnash@chromium.org>
Date: Fri Apr 07 06:05:40 2017

Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2783543002
Cr-Original-Commit-Position: refs/heads/master@{#462379}
Committed: https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb
Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462789}

[modify] https://crrev.com/a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp

Project Member

Comment 111 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7586cc3f2ec274b36870e7b70e3acc034f0dbd2f

commit 7586cc3f2ec274b36870e7b70e3acc034f0dbd2f
Author: bugsnash <bugsnash@chromium.org>
Date: Fri Apr 07 08:29:35 2017

Refactored out the need to use CSSPropertyID to parse shadow properties.

This is pre work to allow the parseSingleValue method of the
CSSPropertyTextShadow and CSSPropertyBoxShadow properties to be
implemented in separate APIs.

This patch also makes the arguments passed to consumeShadow consistent
with those passed to parseSingleShadow and removes property specific
naming in those arguments.

BUG=668012

Review-Url: https://codereview.chromium.org/2796803002
Cr-Commit-Position: refs/heads/master@{#462808}

[modify] https://crrev.com/7586cc3f2ec274b36870e7b70e3acc034f0dbd2f/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 112 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9c68bb0ee3cb79b68a493ad080aa43262865e5

commit da9c68bb0ee3cb79b68a493ad080aa43262865e5
Author: bugsnash <bugsnash@chromium.org>
Date: Fri Apr 07 08:36:53 2017

Implemented parseSingleValue in CSSPropertyAPICounterReset.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterReset
  API, with parsing logic moved from CSSPropertyParser
- removed CSSPropertyCounterReset from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-reset in CSSProperties.json5
  so it will be added to the generated files for the api

Diffs in generated files:
https://gist.github.com/BugsNash/ee5824f42b2120bc405ef97f6e10d99a/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2784443003
Cr-Commit-Position: refs/heads/master@{#462809}

[modify] https://crrev.com/da9c68bb0ee3cb79b68a493ad080aa43262865e5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/da9c68bb0ee3cb79b68a493ad080aa43262865e5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/da9c68bb0ee3cb79b68a493ad080aa43262865e5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterReset.cpp

Project Member

Comment 113 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7178db73ead99cf38ec82a0d5a514f6612fddf2d

commit 7178db73ead99cf38ec82a0d5a514f6612fddf2d
Author: bugsnash <bugsnash@chromium.org>
Date: Thu Apr 13 05:34:37 2017

Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012

Review-Url: https://codereview.chromium.org/2808383008
Cr-Commit-Position: refs/heads/master@{#464311}

[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifySelf.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaselineShift.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnCount.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnGap.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnRuleWidth.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnSpan.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContain.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterReset.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSize.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantCaps.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantLigatures.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFragmentation.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoFlow.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImage.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifyItems.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeight.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrder.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineColor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineOffset.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineWidth.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPadding.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintStroke.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIQuotes.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRadius.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScale.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapCoordinate.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeImageThreshold.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeMargin.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPISize.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeMiterlimit.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITabSize.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationColor.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationSkip.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextIndent.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextSizeAdjust.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITouchAction.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransformOrigin.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVerticalAlign.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlexGroup.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitFontSizeDelta.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaxLogicalWidthOrHeight.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitPadding.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeWidth.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTransformOriginZ.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZIndex.cpp
[modify] https://crrev.com/7178db73ead99cf38ec82a0d5a514f6612fddf2d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp

Cc: -sashab@chromium.org
Project Member

Comment 115 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/128db945e1f34ed9609cf51f7a0291a113b455ac

commit 128db945e1f34ed9609cf51f7a0291a113b455ac
Author: bugsnash <bugsnash@chromium.org>
Date: Thu Apr 20 00:36:42 2017

Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils.
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils.
- Made the ConsumePath method private to the CSSPropertyOffsetPathUtils
  file as it is not used elsewhere.

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012

Review-Url: https://codereview.chromium.org/2816903003
Cr-Commit-Position: refs/heads/master@{#465826}

[modify] https://crrev.com/128db945e1f34ed9609cf51f7a0291a113b455ac/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/128db945e1f34ed9609cf51f7a0291a113b455ac/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/128db945e1f34ed9609cf51f7a0291a113b455ac/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
[add] https://crrev.com/128db945e1f34ed9609cf51f7a0291a113b455ac/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.h

Project Member

Comment 117 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b72ac686eb305a9201b6410c8918637415d204fc

commit b72ac686eb305a9201b6410c8918637415d204fc
Author: bugsnash <bugsnash@chromium.org>
Date: Thu Apr 20 06:26:28 2017

Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:
https://gist.github.com/BugsNash/b847d3875db665dc9d57ec984c2174c0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2824993002
Cr-Commit-Position: refs/heads/master@{#465917}

[modify] https://crrev.com/b72ac686eb305a9201b6410c8918637415d204fc/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b72ac686eb305a9201b6410c8918637415d204fc/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/b72ac686eb305a9201b6410c8918637415d204fc/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/b72ac686eb305a9201b6410c8918637415d204fc/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/b72ac686eb305a9201b6410c8918637415d204fc/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp

Project Member

Comment 118 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b58fb7956f56025d0cf384376995ad54f39b6c78

commit b58fb7956f56025d0cf384376995ad54f39b6c78
Author: bugsnash <bugsnash@chromium.org>
Date: Wed Apr 26 09:07:44 2017

Refactored out need to pass property to IsValidAnimationPropertyList.

Part of project Ribbon

This refactor is one step in the process of refactoring out property
specific logic inside switch cases in
CSSPropertyParser::ParseSingleValue. This is required to implement the
parseSingleValue methods in the property APIs without passing property
ID to the API.

Given that the IsValidAnimationPropertyList function only ever returned
false if the property passed was CSSPropertyTransitionProperty, this
check was moved to the calling methods.

The next step in this process will be to refactor out the need to pass
property to the ConsumeAnimationPropertyList function. At this stage the
call to IsValidAnimationPropertyList will be moved to the
CSSPropertyTransitionProperty case only and the check for this property
will be removed.

The check for this property in
CSSPropertyParser::ConsumeAnimationShorthand will be refactored out at a
later stage in project Ribbon.

BUG=668012

Review-Url: https://codereview.chromium.org/2835893002
Cr-Commit-Position: refs/heads/master@{#467277}

[modify] https://crrev.com/b58fb7956f56025d0cf384376995ad54f39b6c78/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 119 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0f43286afa116cc6ac6160cbf9cec199ba56ee3

commit b0f43286afa116cc6ac6160cbf9cec199ba56ee3
Author: jiameng <jiameng@chromium.org>
Date: Thu May 04 06:03:29 2017

Implements CSSPropertyAPI for the font-feature-settings property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2861633002
Cr-Commit-Position: refs/heads/master@{#469282}

[modify] https://crrev.com/b0f43286afa116cc6ac6160cbf9cec199ba56ee3/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b0f43286afa116cc6ac6160cbf9cec199ba56ee3/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/b0f43286afa116cc6ac6160cbf9cec199ba56ee3/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/b0f43286afa116cc6ac6160cbf9cec199ba56ee3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/b0f43286afa116cc6ac6160cbf9cec199ba56ee3/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp

Project Member

Comment 120 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8091ef8119fff447dc756b8dfc6e99b944a479f8

commit 8091ef8119fff447dc756b8dfc6e99b944a479f8
Author: bugsnash <bugsnash@chromium.org>
Date: Fri May 05 01:53:12 2017

Refactored out property specific logic in animation list parsing.

Replaced animation list parsing method ConsumeAnimationPropertyList
with a new more general list parsing method ConsumeCommaSeparatedList.
This removes the need to pass property information to the list parsing
method, instead passing a callback function to be called on each of the
items in the list.

This is pre work to implementing the parseSingleValue method in the
property APIs for the animation properties that expect a list, as the
APIs do not take property as an argument.

The new ConsumeCommaSeparatedList method can be used in other parts of
the code base, which may be done in future patches.

This patch
- Added ConsumeCommaSeparatedList templated function to
  CSSPropertyParserHelpers
- Made each animation list property in parseSingleValue use the new
  ConsumeCommaSeparatedList method instead of
  ConsumeAnimationPropertyList
- Deleted ConsumeAnimationPropertyList method

BUG=668012

Review-Url: https://codereview.chromium.org/2849363002
Cr-Commit-Position: refs/heads/master@{#469569}

[modify] https://crrev.com/8091ef8119fff447dc756b8dfc6e99b944a479f8/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/8091ef8119fff447dc756b8dfc6e99b944a479f8/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Project Member

Comment 121 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bf16d19c231ffe8787ac464f3fadb6c52859821

commit 7bf16d19c231ffe8787ac464f3fadb6c52859821
Author: bugsnash <bugsnash@chromium.org>
Date: Fri May 05 03:03:05 2017

Added generated class level comments to all CSSPropertyAPIs.

Added generated class level comments to all CSSPropertyAPIs with a
definition of the class and status.

BUG=668012

Review-Url: https://codereview.chromium.org/2864583002
Cr-Commit-Position: refs/heads/master@{#469580}

[modify] https://crrev.com/7bf16d19c231ffe8787ac464f3fadb6c52859821/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
[modify] https://crrev.com/7bf16d19c231ffe8787ac464f3fadb6c52859821/third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl

Project Member

Comment 122 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6597730dd27c7207682ef6390f9388a83d56a702

commit 6597730dd27c7207682ef6390f9388a83d56a702
Author: bugsnash <bugsnash@chromium.org>
Date: Fri May 05 04:43:46 2017

Updated stale generated class comment in CSSPropertyAPI.h

Added note that not all property APIs implement all the methods.

BUG=668012

Review-Url: https://codereview.chromium.org/2860573012
Cr-Commit-Position: refs/heads/master@{#469596}

[modify] https://crrev.com/6597730dd27c7207682ef6390f9388a83d56a702/third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl

Project Member

Comment 123 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22d5fb78823f01b93f1d62465fa178bd5e2b143

commit a22d5fb78823f01b93f1d62465fa178bd5e2b143
Author: jiameng <jiameng@chromium.org>
Date: Fri May 05 05:27:41 2017

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitBorder[Start|End|Before|After]Width from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds parseSingleValue to -webkit-border-[start|end|before|after]-width in CSSProperties.json5
so that it will be added to the generated files for the api.
- Moves the parsing logic for the above properties from CSSPropertyParser.cpp to CSSPropertyAPIWebkitBorderWidth.cpp, which implements CSSPropertyAPI.h.
- Moves shared function ConsumeBorderWidth from CSSPropertyParser.cpp to CSSPropertyWebkitBorderWidthUtils.h.

Diff: https://gist.github.com/jm318/d277f7f4568a69fb5c11c02a6ac47f09/revisions
BUG=668012

Review-Url: https://codereview.chromium.org/2860333002
Cr-Commit-Position: refs/heads/master@{#469600}

[modify] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderWidth.cpp
[add] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/properties/CSSPropertyWebkitBorderWidthUtils.cpp
[add] https://crrev.com/a22d5fb78823f01b93f1d62465fa178bd5e2b143/third_party/WebKit/Source/core/css/properties/CSSPropertyWebkitBorderWidthUtils.h

Project Member

Comment 124 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bef7b29ce7529f8512e76226f8690d67e2a0b97

commit 2bef7b29ce7529f8512e76226f8690d67e2a0b97
Author: bugsnash <bugsnash@chromium.org>
Date: Tue May 09 06:54:13 2017

Refactored out property specific logic in ConsumeBorderImageSlice.

Replaced property specific logic in ConsumeBorderImageSlice with a bool
arg specifying whether the property has fill set by default. This
removes the need to pass property to the method, moving the
property specific logic to the calling method, which can later be
separated out into property APIs.

BUG=668012

Review-Url: https://codereview.chromium.org/2860283003
Cr-Commit-Position: refs/heads/master@{#470256}

[modify] https://crrev.com/2bef7b29ce7529f8512e76226f8690d67e2a0b97/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/2bef7b29ce7529f8512e76226f8690d67e2a0b97/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Project Member

Comment 125 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a90e416a49db962781bf5e3fc5cfd263346e5375

commit a90e416a49db962781bf5e3fc5cfd263346e5375
Author: ericwilligers <ericwilligers@chromium.org>
Date: Fri May 12 04:31:10 2017

Implements CSSPropertyAPI for the d property

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyD from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API
for the d property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPID.cpp to the BUILD.gn file.
- Adds parseSingleValue to "d" in CSSProperties.json5
  so that it will be added to the generated files for the api.
- Moves the parsing logic for d from CSSPropertyParser.cpp to
  CSSPropertyAPID.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2642033002
Cr-Commit-Position: refs/heads/master@{#471220}

[modify] https://crrev.com/a90e416a49db962781bf5e3fc5cfd263346e5375/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/a90e416a49db962781bf5e3fc5cfd263346e5375/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/a90e416a49db962781bf5e3fc5cfd263346e5375/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/a90e416a49db962781bf5e3fc5cfd263346e5375/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/a90e416a49db962781bf5e3fc5cfd263346e5375/third_party/WebKit/Source/core/css/properties/CSSPropertyAPID.cpp

Project Member

Comment 126 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/545f7be4401875ef9842de21144da3561281b2db

commit 545f7be4401875ef9842de21144da3561281b2db
Author: ericwilligers <ericwilligers@chromium.org>
Date: Fri May 12 12:52:06 2017

Implements CSSPropertyAPI for the offset-path property

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPath from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API
for the offset-path property is stored in a CSSPropertyDescriptor,
and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPath.cpp to the BUILD.gn file.
- Adds parseSingleValue to "offset-path" in CSSProperties.json5
  so that it will be added to the generated files for the api.
- Moves the parsing logic for offset-path from CSSPropertyParser.cpp
  to CSSPropertyAPIOffsetPath.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2878533004
Cr-Commit-Position: refs/heads/master@{#471289}

[modify] https://crrev.com/545f7be4401875ef9842de21144da3561281b2db/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/545f7be4401875ef9842de21144da3561281b2db/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/545f7be4401875ef9842de21144da3561281b2db/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/545f7be4401875ef9842de21144da3561281b2db/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/545f7be4401875ef9842de21144da3561281b2db/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp

Project Member

Comment 127 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a1960fb48be21c84024bec173b72da40d16289d

commit 6a1960fb48be21c84024bec173b72da40d16289d
Author: bugsnash <bugsnash@chromium.org>
Date: Mon May 15 04:37:24 2017

Removed CSSPropertyAPIShadow group property stub

The CSSPropertyAPIShadow stub was intended to implement a shared API
between the CSSPropertyTextShadow and CSSPropertyBoxShadow properties.
This stub was added prematurely, and will in fact not be used as
these properties have recently been refactored and require unique
parsing logic, so they will be individually implemented as APIs in
future.

BUG=668012

Review-Url: https://codereview.chromium.org/2877783004
Cr-Commit-Position: refs/heads/master@{#471668}

[modify] https://crrev.com/6a1960fb48be21c84024bec173b72da40d16289d/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6a1960fb48be21c84024bec173b72da40d16289d/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/6a1960fb48be21c84024bec173b72da40d16289d/third_party/WebKit/Source/core/css/CSSProperties.json5
[delete] https://crrev.com/8ace54b1623362bd0720adf22811f237d93344a0/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShadow.cpp

Project Member

Comment 128 by bugdroid1@chromium.org, May 15 2017

Project Member

Comment 129 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23cf82b8915a04b3c6c83717902b2bfe0c885dde

commit 23cf82b8915a04b3c6c83717902b2bfe0c885dde
Author: bugsnash <bugsnash@chromium.org>
Date: Thu May 18 22:05:43 2017

Refactored out need to pass unresolved property id to ConsumePerspective

BUG=668012

Review-Url: https://codereview.chromium.org/2892483004
Cr-Commit-Position: refs/heads/master@{#472946}

[modify] https://crrev.com/23cf82b8915a04b3c6c83717902b2bfe0c885dde/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 130 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d39dae4faddc9927038ccccb4d7ec37a3fd87937

commit d39dae4faddc9927038ccccb4d7ec37a3fd87937
Author: bugsnash <bugsnash@chromium.org>
Date: Mon May 22 02:32:41 2017

Refactored out need to pass property to ConsumeBackgroundSize parsing

BUG=668012

Review-Url: https://codereview.chromium.org/2889153006
Cr-Commit-Position: refs/heads/master@{#473493}

[modify] https://crrev.com/d39dae4faddc9927038ccccb4d7ec37a3fd87937/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 131 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04fa8149930e617b317c48d578fb2386c06e38c1

commit 04fa8149930e617b317c48d578fb2386c06e38c1
Author: bugsnash <bugsnash@chromium.org>
Date: Mon May 22 06:23:22 2017

Refactored out need to pass property id to ConsumePrefixedBackgroundBox

BUG=668012

Review-Url: https://codereview.chromium.org/2895873002
Cr-Commit-Position: refs/heads/master@{#473514}

[modify] https://crrev.com/04fa8149930e617b317c48d578fb2386c06e38c1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 132 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6460e24cf59f429d69de255538d0fc7a425ccf9

commit b6460e24cf59f429d69de255538d0fc7a425ccf9
Author: jiameng <jiameng@chromium.org>
Date: Fri May 26 03:28:27 2017

Create a new local context class.

CSSParserLocalContext represents local context for each property.
Currently it only has one boolean field (use_alias_parsing), but it
will be later extended to contain other info, such as whether the
property is a longhand of a shorthand.

BUG=668012

Review-Url: https://codereview.chromium.org/2901393002
Cr-Commit-Position: refs/heads/master@{#474897}

[modify] https://crrev.com/b6460e24cf59f429d69de255538d0fc7a425ccf9/third_party/WebKit/Source/core/css/BUILD.gn
[add] https://crrev.com/b6460e24cf59f429d69de255538d0fc7a425ccf9/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.cpp
[add] https://crrev.com/b6460e24cf59f429d69de255538d0fc7a425ccf9/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h

Project Member

Comment 133 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d2eb259484cb04b331ac05367ff2bb1c31ed5a

commit 97d2eb259484cb04b331ac05367ff2bb1c31ed5a
Author: jiameng <jiameng@chromium.org>
Date: Tue Jun 06 12:01:02 2017

Move AddProperty to a helper class.

This cl paves the way for parsing shorthand properties. AddProperty is
currently a private function within CSSPropertyParser. We now move it
to a helper class so that it can be accessed by property APIs when a
property parses its values and adds parsed properties to a set of all
parsed properties for further processing.

BUG=668012

Review-Url: https://codereview.chromium.org/2917323003
Cr-Commit-Position: refs/heads/master@{#477261}

[modify] https://crrev.com/97d2eb259484cb04b331ac05367ff2bb1c31ed5a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/97d2eb259484cb04b331ac05367ff2bb1c31ed5a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[modify] https://crrev.com/97d2eb259484cb04b331ac05367ff2bb1c31ed5a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/97d2eb259484cb04b331ac05367ff2bb1c31ed5a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Project Member

Comment 135 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0

commit a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0
Author: bugsnash <bugsnash@chromium.org>
Date: Tue Jun 13 02:17:53 2017

Added CSSPropertyBorderImageUtils which holds shared parsing logic.

Added CSSPropertyBorderImageUtils which holds shared border image
parsing logic.

This patch
- Added CSSPropertyBorderImageUtils.h and
  CSSPropertyBorderImageUtils.cpp
- Moved the following methods from CSSPropertyParser.cpp to
  CSSPropertyBorderImageUtils as public utils
  - ConsumeWebkitBorderImage
  - ConsumeBorderImageComponents
  - ConsumeBorderImageRepeat
  - ConsumeBorderImageSlice
  - ConsumeBorderImageWidth
  - ConsumeBorderImageOutset
- Moved ConsumeBorderImageRepeatKeyword from CSSPropertyParser.cpp
  to CSSPropertyBorderImageUtils.cpp as a private method in an
  unnamed namespace

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyWebkitBorderImage

BUG=668012

Review-Url: https://codereview.chromium.org/2927023003
Cr-Commit-Position: refs/heads/master@{#478867}

[modify] https://crrev.com/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[add] https://crrev.com/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h

Project Member

Comment 136 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8445ae44afda4860ffb44dcab116534b3e3fa4a3

commit 8445ae44afda4860ffb44dcab116534b3e3fa4a3
Author: bugsnash <bugsnash@chromium.org>
Date: Fri Jun 16 07:15:47 2017

Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved ConsumeTransitionProperty and IsValidAnimationPropertyList from
  CSSPropertyParser to CSSPropertyTransitionUtils (changed name of
  IsValidAnimationPropertyList to IsValidAnimationList to avoid confusion
  with the animation property)

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012

Review-Url: https://codereview.chromium.org/2939883003
Cr-Commit-Position: refs/heads/master@{#479979}

[modify] https://crrev.com/8445ae44afda4860ffb44dcab116534b3e3fa4a3/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/8445ae44afda4860ffb44dcab116534b3e3fa4a3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/8445ae44afda4860ffb44dcab116534b3e3fa4a3/third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.cpp
[add] https://crrev.com/8445ae44afda4860ffb44dcab116534b3e3fa4a3/third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.h

Project Member

Comment 137 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbee2d97beece9b3b4dea2181019621a9f5299fb

commit fbee2d97beece9b3b4dea2181019621a9f5299fb
Author: bugsnash <bugsnash@chromium.org>
Date: Wed Jun 21 05:34:47 2017

Implemented remaining non-grouped longhand property APIs

Added the property APIs and implemented the parseSingleValue method on
the remaining longhand non-grouped properties that did not have stub API
implementations.

This includes the following properties:
- animation-direction
- animation-fill-mode
- animation-iteration-count
- animation-play-state
- background-color
- box-shadow
- font-weight
- object-position
- perspective-origin
- text-shadow
- transition-property
- webkit-box-reflect

BUG=668012

Review-Url: https://codereview.chromium.org/2882603002
Cr-Commit-Position: refs/heads/master@{#481115}

[modify] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationDirection.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationFillMode.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationIterationCount.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationPlayState.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundColor.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxShadow.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontWeight.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIObjectPosition.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspectiveOrigin.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextShadow.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransitionProperty.cpp
[add] https://crrev.com/fbee2d97beece9b3b4dea2181019621a9f5299fb/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxReflect.cpp

Cc: jiameng@chromium.org
Project Member

Comment 139 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f0923be4be20773b0138e070a2dbf35bdb11e6

commit e9f0923be4be20773b0138e070a2dbf35bdb11e6
Author: Jia <jiameng@chromium.org>
Date: Tue Jul 04 06:08:23 2017

Implement parseShorthand for shorthand properties "animation" and "transition".

This cl contains the following changes
1. Refactored ConsumeAnimationValue from CSSPropertyParser and broke it into
ConsumeAnimationValue and ConsumeTransitionValue.
- The old version is used by both "animation" and "transition" properties, now
the two properties are parsed by respective Consume<Property>Value functions.
- Moved the new ConsumeAnimationValue into animation property API as an anonymous 
function.
- Moved the new ConsumeTransitionValue into transition property API as an anonymous 
function.

2. Refactored ConsumeAnimationShorthand from CSSPropertyParser and moved it to
a new util file (CSSPropertyAnimationUtils) as ConsumeAnimationShorthand.
- The old version directly calls the old ConsumeAnimationValue. Since we are 
breaking up ConsumeAnimationValue, the new ConsumeAnimationShorthand receives a callback 
func as a param and forwards respective args to the appropriate callback functions. 
The expected callback functions are ConsumeAnimationValue and 
ConsumeTransitionValue.

3. Added CSSPropertyAnimationTimingFunctionUtils file.
- Moved ConsumeAnimationTimingFunction from CSSPropertyParser to this util file.
- It's currently being used by "animation" and "transition" shorthands. It will 
later be used by animation-timing-function longhand API.

4. Added API impl for "animation" property.
- In addition to parseShorthand, it has an anonymous ConsumeAnimationValue func.

5. Added API impl of "transition" property.
- In addition to parseShorthand, it has an anonymous ConsumeTransitionValue func.

6. Changed CSSPropertyParser to use the new API for these two shorthands.
- Also removed functions that won't be used.

7. Build files and json to include the new API.

Bug: 668012
Diff: https://gist.github.com/429b73fec6e926f58897301b51856465/revisions
Change-Id: Ic20898fbd603c5760da4b5afab86aa48edcff600
Reviewed-on: https://chromium-review.googlesource.com/549675
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484058}
[modify] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[add] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[add] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[add] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[add] https://crrev.com/e9f0923be4be20773b0138e070a2dbf35bdb11e6/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 140 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da1154afe061e0d4228f7e4a774a683e8de22338

commit da1154afe061e0d4228f7e4a774a683e8de22338
Author: Jia <jiameng@chromium.org>
Date: Thu Jul 06 03:37:13 2017

Implement CSSPropertyAPIMarker to parse longhands marker-[start|mid|end] and mask.

This cl contains the following changes
* Implemented parseSingleValue in CSSPropertyAPIMarker.
* Changed CSSPropertyParser.cpp to use the new API for the three properties.
- Also removed ConsumeNoneOrURI function that's not used any more.
* Changed CSSProperties.json5 to use APIs for the three properties.

Diff: https://gist.github.com/75a67fb3ae132e0cbc398ac59adae0dc/revisions
Bug: 668012
Change-Id: Ibeacb3f6edd251b19fc3e373c9e7c2ca5a5b3a26
Reviewed-on: https://chromium-review.googlesource.com/558824
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484457}
[modify] https://crrev.com/da1154afe061e0d4228f7e4a774a683e8de22338/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/da1154afe061e0d4228f7e4a774a683e8de22338/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/da1154afe061e0d4228f7e4a774a683e8de22338/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMarker.cpp

Project Member

Comment 141 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4

commit 8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4
Author: Jia <jiameng@chromium.org>
Date: Thu Jul 06 10:04:30 2017

Revert "Implement parseShorthand for shorthand properties "animation" and "transition"."

This reverts commit e9f0923be4be20773b0138e070a2dbf35bdb11e6.

Reason for revert: potentially causing crashes on pixel phone (crbug.com/739275).

Original change's description:
> Implement parseShorthand for shorthand properties "animation" and "transition".
> 
> This cl contains the following changes
> 1. Refactored ConsumeAnimationValue from CSSPropertyParser and broke it into
> ConsumeAnimationValue and ConsumeTransitionValue.
> - The old version is used by both "animation" and "transition" properties, now
> the two properties are parsed by respective Consume<Property>Value functions.
> - Moved the new ConsumeAnimationValue into animation property API as an anonymous 
> function.
> - Moved the new ConsumeTransitionValue into transition property API as an anonymous 
> function.
> 
> 2. Refactored ConsumeAnimationShorthand from CSSPropertyParser and moved it to
> a new util file (CSSPropertyAnimationUtils) as ConsumeAnimationShorthand.
> - The old version directly calls the old ConsumeAnimationValue. Since we are 
> breaking up ConsumeAnimationValue, the new ConsumeAnimationShorthand receives a callback 
> func as a param and forwards respective args to the appropriate callback functions. 
> The expected callback functions are ConsumeAnimationValue and 
> ConsumeTransitionValue.
> 
> 3. Added CSSPropertyAnimationTimingFunctionUtils file.
> - Moved ConsumeAnimationTimingFunction from CSSPropertyParser to this util file.
> - It's currently being used by "animation" and "transition" shorthands. It will 
> later be used by animation-timing-function longhand API.
> 
> 4. Added API impl for "animation" property.
> - In addition to parseShorthand, it has an anonymous ConsumeAnimationValue func.
> 
> 5. Added API impl of "transition" property.
> - In addition to parseShorthand, it has an anonymous ConsumeTransitionValue func.
> 
> 6. Changed CSSPropertyParser to use the new API for these two shorthands.
> - Also removed functions that won't be used.
> 
> 7. Build files and json to include the new API.
> 
> Bug: 668012
> Diff: https://gist.github.com/429b73fec6e926f58897301b51856465/revisions
> Change-Id: Ic20898fbd603c5760da4b5afab86aa48edcff600
> Reviewed-on: https://chromium-review.googlesource.com/549675
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: Bugs Nash <bugsnash@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#484058}

TBR=alancutter@chromium.org,jiameng@chromium.org,bugsnash@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 668012
Change-Id: I3ee75cd1d8a3c2ae16b14a520154c881e7c6831a
Reviewed-on: https://chromium-review.googlesource.com/561076
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484524}
[modify] https://crrev.com/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/8b6ebd482f565f7a83ca07d7a7996e97cc4f64d4/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[delete] https://crrev.com/6cd2e2ecb2f25705691db6b37d272ec59aebc30e/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[delete] https://crrev.com/6cd2e2ecb2f25705691db6b37d272ec59aebc30e/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[delete] https://crrev.com/6cd2e2ecb2f25705691db6b37d272ec59aebc30e/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[delete] https://crrev.com/6cd2e2ecb2f25705691db6b37d272ec59aebc30e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[delete] https://crrev.com/6cd2e2ecb2f25705691db6b37d272ec59aebc30e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 142 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9

commit 0b176f8a5bdbd7cbff9f554940277b9e27a21ae9
Author: Jia <jiameng@chromium.org>
Date: Fri Jul 07 07:06:17 2017

Implement parseShorthand API for "border-image" and "-webkit-mask-box-image".

This cl contains the following changes
* Implemented parseShorthand for CSSShorthandPropertyAPIBorderImage and CSSShorthandPropertyAPIWebkitMaskBoxImage.
* Broke up ConsumeBorderImage from CSSPropertyParser to two parts, one for each shorthand property.
- This function was used to serve both shorthands using a switch statement.
* Removed ConsumeBorderImage from CSSPropertyParser. Also changed CSSPropertyParser to use API for these two properties.
* Changed BUILD and json5 files to use the APIs.

Bug: 668012
Change-Id: I7fda459f423f684e52729f9ada0dc24e3b753d78
Reviewed-on: https://chromium-review.googlesource.com/558328
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484844}
[modify] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[add] https://crrev.com/0b176f8a5bdbd7cbff9f554940277b9e27a21ae9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp

Project Member

Comment 143 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/065f9c7188c551e84cbb2f269b223dd9209137bb

commit 065f9c7188c551e84cbb2f269b223dd9209137bb
Author: Jia <jiameng@chromium.org>
Date: Mon Jul 10 00:49:35 2017

Implement ParseLonghandViaAPI and move CountKeywordOnlyPropertyUsage to CSSPropertyParserHelpers.

This cl contains the following changes
* Implemented ParseLonghandViaAPI in CSSPropertyParserHelpers.
- This function will be used by Consume2Values, Consume4Values and
ConsumeShorthandGreedily. These shorthand parsing functions all need to
forward parsing ops to component longhands.
- At the moment, these functions call CSSPropertyParser's ParseSingleValue.
However, as we will later move these shorthand parsing functions to CSSPropertyParserHelpers,
we should not continue to call CSSPropertyParser.
- Therefore, this cl adds ParseLonghandViaAPI, which contains similar logic to
CSSPropertyParser's ParseSingleValue, with the exception that this new method only works
on longhands that have API impl.

* Moved CountKeywordOnlyPropertyUsage from CSSPropertyParser to CSSPropertyParserHelps.
- This function is used by ParseLonghandViaAPI.

Note, the next cl will have an impl of ConsumeShorthandVia4LonghandsAPI that will use
ParseLonghandViaAPI.

Bug: 668012
Change-Id: Ia9211f9eb5d70124536f5ef0e7d44eeafefa69e2
Reviewed-on: https://chromium-review.googlesource.com/557619
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485167}
[modify] https://crrev.com/065f9c7188c551e84cbb2f269b223dd9209137bb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/065f9c7188c551e84cbb2f269b223dd9209137bb/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/065f9c7188c551e84cbb2f269b223dd9209137bb/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Project Member

Comment 144 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51446e5de4d10c0670380c2440e9ebc2bcee6de4

commit 51446e5de4d10c0670380c2440e9ebc2bcee6de4
Author: Jia <jiameng@chromium.org>
Date: Mon Jul 10 02:41:46 2017

Implement ConsumeShorthandVia4LonghandsAPI in CSSPropertyParserHelpers.

The new function ConsumeShorthandVia4LonghandsAPI is a modified version
of Consume4Values of CSSPropertyParser. They both parse shorthands 
consisting of 4 longhands (top, right, bottom, left). The difference
between this new version and the old/existing Consume4Values is that
the new version expects component longhands to have API impl already 
as it will forward parsing logic to component longhands API via 
ParseLonghandViaAPI.

This cl contains one change only, i.e. the impl of 
ConsumeShorthandVia4LonghandsAPI. This cl is also a use case of
ParseLonghandViaAPI. The next cl will have a shorthand API impl
that will use ConsumeShorthandVia4LonghandsAPI.

Bug: 668012
Change-Id: I9a638d9c654a1bb734b60dccadaf2c52ddd761f0
Reviewed-on: https://chromium-review.googlesource.com/560920
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485175}
[modify] https://crrev.com/51446e5de4d10c0670380c2440e9ebc2bcee6de4/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/51446e5de4d10c0670380c2440e9ebc2bcee6de4/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Project Member

Comment 145 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc692089518300459e4f70e6d1aa66971ed6631f

commit dc692089518300459e4f70e6d1aa66971ed6631f
Author: Bugs Nash <bugsnash@chromium.org>
Date: Mon Jul 10 05:22:01 2017

Moved CSSPropertyColor to appropriate API and renamed color APIs

This patch fixes an error introduced in patch crrev.com/2882603002,
where the CSSPropertyBackgroundColor property was pulled out into a
single property API when it should have been grouped with the
CSSPropertyColor property. This error left CSSPropertyColor parsing
logic to fall through to border color parsing logic.

This patch
- moved CSSPropertyColor to be grouped with CSSPropertyBorderColor in
  existing API implementation
- renamed CSSPropertyAPIBackgroundColor to CSSPropertyAPIColor as a
  group API name for CSSPropertyColor and CSSPropertyBorderColor
- because CSSPropertyAPIColor was already taken as an API name,
  renamed the pre-existing CSSPropertyAPIColor to
  CSSPropertyAPIColorNoQuirks (the difference between the 2 APIs
  parsing logic is only whether quirks mode is permitted)

Bug: 668012
Change-Id: I119a2cafbd51b93bd1c9323745aae728cc74a2ca
Reviewed-on: https://chromium-review.googlesource.com/562944
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Suzy Howlett <suzyh@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485190}
[modify] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[delete] https://crrev.com/1657a919ecc63f457d2c4049d58574fe2e7271d5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundColor.cpp
[modify] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[add] https://crrev.com/dc692089518300459e4f70e6d1aa66971ed6631f/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColorNoQuirks.cpp

Project Member

Comment 146 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9368016fb19bf4a68a55dec1ee26a87caaf16cbd

commit 9368016fb19bf4a68a55dec1ee26a87caaf16cbd
Author: Jia <jiameng@chromium.org>
Date: Mon Jul 10 12:17:05 2017

Implement parseShorthand API for property "margin".

Shorthand property "margin" is parsed by delegating parsing logic to 
its component longhands API, using ConsumeShorthandVia4LonghandsAPI.
This cl also serves as a use case of ConsumeShorthandVia4LonghandsAPI.

This cl contains the following changes
* Implemented of "margin" parseShorthand API.
* Changed the system to use the new API for parsing.
- Changed CSSPropertyParser.cpp to use property API to parse "margin".
- Added api parsing to json file.
- Updated BUILD files to include the new API files.

Bug: 668012
Change-Id: Ide0737ab44088cc882191b53278e56c65a075208
Reviewed-on: https://chromium-review.googlesource.com/560801
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485241}
[modify] https://crrev.com/9368016fb19bf4a68a55dec1ee26a87caaf16cbd/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/9368016fb19bf4a68a55dec1ee26a87caaf16cbd/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/9368016fb19bf4a68a55dec1ee26a87caaf16cbd/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/9368016fb19bf4a68a55dec1ee26a87caaf16cbd/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/9368016fb19bf4a68a55dec1ee26a87caaf16cbd/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMargin.cpp

Project Member

Comment 147 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b23e0dd7a82965babb8599f7ea0f57640f529cf3

commit b23e0dd7a82965babb8599f7ea0f57640f529cf3
Author: Bugs Nash <bugsnash@chromium.org>
Date: Tue Jul 11 04:56:10 2017

Implemented CSSPropertyAPITextDecorationLine parsing logic

This patch:
- Added CSSPrpertyTextDecorationLineUtils and moved common function
  ConsumeTextDecorationLine from CSSPropertyParser into it.
- Implemented CSSPropertyAPITextDecorationLine::parseSingleValue,
  moving logic for properties CSSPropertyTextDecorationLine and
  CSSPropertyWebkitTextDecorationsInEffect from
  CSSPropertyParser::ParseSingleValue legacy switch statement
- Added details of API implementation for these properties to
  CSSProperties.json5 for generated files.

Diff for generated files: https://gist.github.com/BugsNash/1f4cae843ee5843e43b46ed3eebf0de6/revisions

Bug: 668012
Change-Id: I5f1d5f6f38d0fee61a6e3116f88e8ea78c7e2b3d
Reviewed-on: https://chromium-review.googlesource.com/565225
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485525}
[modify] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationLine.cpp
[add] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/properties/CSSPropertyTextDecorationLineUtils.cpp
[add] https://crrev.com/b23e0dd7a82965babb8599f7ea0f57640f529cf3/third_party/WebKit/Source/core/css/properties/CSSPropertyTextDecorationLineUtils.h

Project Member

Comment 148 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/632a1f75d14ad050a59073721ffe9ffeb56846a5

commit 632a1f75d14ad050a59073721ffe9ffeb56846a5
Author: Jia <jiameng@chromium.org>
Date: Tue Jul 11 09:12:53 2017

Implement ConsumeShorthandGreedilyViaLonghandsAPI and API for shorthand property -webkit-text-emphasis.

ConsumeShorthandGreedilyViaLonghandsAPI is a modified version of
ConsumeShorthandGreedily of CSSPropertyParser. The difference between
the two is that the new version expects component longhands to have API
impl already  as it will forward parsing logic to component longhands API
via ParseLonghandViaAPI.

ConsumeShorthandGreedily will be deprecated soon, when shorthand properties 
are ribbonised (i.e. have their own APIs). Until then, there is a slight 
code duplication between the two versions for the following reasons:

1. An alternative to code duplicate is to have the old ConsumeShorthandGreedily
call the new ConsumeShorthandGreedilyViaLonghandsAPI. However, the new 
ConsumeShorthandGreedilyViaLonghandsAPI expects ALL component longhands 
to have APIs and will parse all longhands via their APIs. In order to parse 
shorthands, where some component longhands do not have APIs, the new 
ConsumeShorthandGreedilyViaLonghandsAPI will need to return to the old 
ConsumeShorthandGreedily which longhands have no APIs and thus are not parsed.
The old ConsumeShorthandGreedily will then have to parse these longhands separately.
Hence there's added code complexity with little code reduction.

2. All shorthand properties will have APIs soon, hence such code duplication is 
temporary only.

This cl also implements API for shorthand property -webkit-text-emphasis
as a use case of ConsumeShorthandGreedilyViaLonghandsAPI.

Design doc for shorthand parsing: https://docs.google.com/document/d/1gF_3wAvO82iVNcyJ7z2YzT8sFa8JepkWmIgJ9NcT1Pc/edit

Diff: https://gist.github.com/f9cff56b20f46225b6b90f033798eccf/revisions
Bug: 668012
Change-Id: I1cf9295893bb113527b44c2935d296e2997164ac
Reviewed-on: https://chromium-review.googlesource.com/564875
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485567}
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[add] https://crrev.com/632a1f75d14ad050a59073721ffe9ffeb56846a5/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextEmphasis.cpp

Project Member

Comment 149 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe39759dd811fd2bfaf379f6e33ee69f50ab393b

commit fe39759dd811fd2bfaf379f6e33ee69f50ab393b
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 12 06:33:53 2017

Implement parseShorthand for -webkit-border-[start|end|before|after], -webkit-text-stroke and outline.

All these shorthand properties call the same helper function ConsumeShorthandGreedilyViaLonghandAPIs.
Hence these properties are grouped in one cl.

Bug: 668012
Change-Id: I4341dd88c9e69ef0105846094324f673adffa967
Diff: https://gist.github.com/56c80c6712e00d58983a557381f20664/revisions
Reviewed-on: https://chromium-review.googlesource.com/567605
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Suzy Howlett <suzyh@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485878}
[modify] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOutline.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderAfter.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderBefore.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderEnd.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderStart.cpp
[add] https://crrev.com/fe39759dd811fd2bfaf379f6e33ee69f50ab393b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextStroke.cpp

Project Member

Comment 150 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e0a3d9f477b909dc740b08e6b23cff16123f10

commit 02e0a3d9f477b909dc740b08e6b23cff16123f10
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 12 08:39:20 2017

Implement ConsumeShorthandVia2LonghandAPIs and API for shorthand property scroll-padding-block.

ConsumeShorthandVia2LonghandAPIs is a modified version of Consume2Values
of CSSPropertyParser. The difference between the two is that the new
version expects component longhands to have API impl already  as it will
forward parsing logic to component longhands API via ParseLonghandViaAPI.

Consume2Values will be deprecated soon, when shorthand properties 
are ribbonised (i.e. have their own APIs). Until then, there is a slight 
code duplication between the two versions, see crrev.com/c/564875 for discussions
why it is necessary.

In addition to ConsumeShorthandVia2LonghandAPIs, the cl also contains the following 
* Implement API for shorthand property scroll-padding-block as a use case of 
ConsumeShorthandVia2LonghandAPIs.
* Change ConsumeShorthandVia4LonghandsAPI to ConsumeShorthandVia4LonghandAPIs.
- Also updated "margin" API to reflect the naming change.


Bug: 668012
Change-Id: I45d1f5177c5ff3f381a24085ecde0647c5e08baf
Diff: https://gist.github.com/a54354ab973c928d2717251b56caeb57/revisions
Reviewed-on: https://chromium-review.googlesource.com/565662
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485898}
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[modify] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMargin.cpp
[add] https://crrev.com/02e0a3d9f477b909dc740b08e6b23cff16123f10/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPaddingBlock.cpp

Project Member

Comment 151 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df4bb375479ac4920c9636e83e53c9d096571a35

commit df4bb375479ac4920c9636e83e53c9d096571a35
Author: Bugs Nash <bugsnash@chromium.org>
Date: Fri Jul 14 03:02:37 2017

Added current_shorthand to CSSParserLocalContext.

This patch
- Added current_shorthand to CSSParserLocalContext so that longhands
  whose parsing logic depends on the current shorthand can be
  implemented in APIs
- Changed the APIs' parseShorthand methods CSSParserLocalContext
  argument to a use_legacy_parsing bool, because shorthand parsing
  does not need to be told what the shorthand is (and should not be
  passed this information).

Diff in generated files: https://gist.github.com/54d6f19738916454fdaaa2278f221ba3/revisions

Bug: 668012
Change-Id: Ide9e82fd74d17099f576ad98e0abaf2f24659b5f
Reviewed-on: https://chromium-review.googlesource.com/566258
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486655}
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderSpacing.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIColumns.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFontVariant.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMargin.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOffset.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOutline.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOverflow.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPaddingBlock.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderAfter.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderBefore.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderEnd.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderStart.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextEmphasis.cpp
[modify] https://crrev.com/df4bb375479ac4920c9636e83e53c9d096571a35/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextStroke.cpp

Project Member

Comment 152 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f246deb08d7f37dfa7036c62d608e4fddbfe098

commit 6f246deb08d7f37dfa7036c62d608e4fddbfe098
Author: Bugs Nash <bugsnash@chromium.org>
Date: Fri Jul 14 07:14:49 2017

Implemented parsing in BorderColor and BorderWidth property group APIs

This patch
- Added CSSPropertyAPIBorderColor
- Implemented parseSingleValue method on CSSPropertyAPIBorderColor and
  CSSPropertyAPIBorderWidth, moving parsing logic from CSSPropertyParser
  legacy switch
- Added details of API implementations to CSSProperties.json5 so that
  generated files will be updated

Bug: 668012
Change-Id: I05487329dab8542022d2750ddb1d81a4dbc65a1f
Reviewed-on: https://chromium-review.googlesource.com/566346
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486696}
[modify] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderColor.cpp
[modify] https://crrev.com/6f246deb08d7f37dfa7036c62d608e4fddbfe098/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderWidth.cpp

Project Member

Comment 153 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b

commit 7f1acbb2a16619c5d25fbd0f5762e11e948ad59b
Author: Jia <jiameng@chromium.org>
Date: Fri Jul 14 08:16:45 2017

Implement parseShorthand for scroll-padding-inline and scroll-snap-margin-[block|inline].

All these shorthand properties call the same helper function
ConsumeShorthandVia2LonghandAPIs. Hence these properties are grouped in
one cl.

Bug: 668012
Change-Id: I308be0165a6e7962874053e6cbefd831cac6f410
Diff: https://gist.github.com/06821a4b93df191366b1b8a2ac9d01ad/revisions
Reviewed-on: https://chromium-review.googlesource.com/571338
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486707}
[modify] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPaddingInline.cpp
[add] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMarginBlock.cpp
[add] https://crrev.com/7f1acbb2a16619c5d25fbd0f5762e11e948ad59b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMarginInline.cpp

Project Member

Comment 154 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51c2bff2427cc101d464b1c559c9cc868f0344c2

commit 51c2bff2427cc101d464b1c559c9cc868f0344c2
Author: Jia <jiameng@chromium.org>
Date: Tue Jul 18 03:27:40 2017

Implement API for shorthand properties animation and transition.

This cl is a resubmission of an earlier cl (crrev.com/c/549675), which
was reverted to fix a crash on one specific version of Google Pixel.
The difference between this cl and the previous cl is in the
implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand:
- The old version is a templated function that uses function callback
  and variable number of args.
- The new version uses a function pointer, which is simpler than a
  callback.

The original crash was not reproducible using the old patch. 
But it is probably better to use function pointers instead of 
a callback function with variable number of bugs. 

Have run this new patch on a pixel phone and there was not crash. 

Bug: 668012
Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4
Reviewed-on: https://chromium-review.googlesource.com/569505
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487372}
[modify] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.cpp
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[add] https://crrev.com/51c2bff2427cc101d464b1c559c9cc868f0344c2/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 155 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/402d1076bace44eb2a2d8f412cfc94e846cf39b9

commit 402d1076bace44eb2a2d8f412cfc94e846cf39b9
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 19 01:56:43 2017

Implement parseShorthand for background-position and -webkit-mask-position.

This cl also moves related functions (AddBackgroundValue and
ConsumeBackgroundPosition) to a util file (CSSPropertyBackgroundUtils).

Bug: 668012
Diff: https://gist.github.com/baf2458cc0b52d24baba7b01dc48adbb/revisions
Change-Id: I50dd559e6c2e0a172783f23825ebe2bf219144fa
Reviewed-on: https://chromium-review.googlesource.com/575254
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487718}
[modify] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[add] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h
[add] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackgroundPosition.cpp
[add] https://crrev.com/402d1076bace44eb2a2d8f412cfc94e846cf39b9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskPosition.cpp

Project Member

Comment 156 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5

commit eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Jul 19 04:47:52 2017

Implements CSSPropertyAPI for -webkit-locale/-webkit-hyphenate-character


As part of Project Ribbon, separate the parsing logic for CSS
properties -webkit-locale and -webkit-hyphenate-character from
the parser into an API.

Bug: 668012

Signed-off-by: Rob Buis <rob.buis@samsung.com>
Change-Id: I6a1e7cf419d2f425ef2ca736f0153c48025caa78
Reviewed-on: https://chromium-review.googlesource.com/576234
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487753}
[modify] https://crrev.com/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/eb2cda8daef4a0a16f0dbea83cd3b9e372bdf2f5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAutoOrString.cpp

Project Member

Comment 157 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad0d92f68842f99018bfb208e1bab10432db9c3

commit 1ad0d92f68842f99018bfb208e1bab10432db9c3
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 19 06:11:14 2017

Implement parseShorthand for border-color, border-style, border-width, padding, scroll-padding and scroll-snap-margin.

All these shorthand properties call the same helper function
ConsumeShorthandVia4LonghandAPIs. Hence these properties are grouped in
one cl.

This cl also removes Consume4Values from CSSPropertyParser, as it is
now fully replaced by ConsumeShorthandVia4LonghandAPIs.

Bug: 668012
Diff: https://gist.github.com/c3c7bb4c3b5af945e0b1bfc778a2fb40/revisions
Change-Id: I1610e00df7f8045dea3dd4f2139ab3f21bb1f1d9
Reviewed-on: https://chromium-review.googlesource.com/572510
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487769}
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[modify] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderColor.cpp
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderStyle.cpp
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderWidth.cpp
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPadding.cpp
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPadding.cpp
[add] https://crrev.com/1ad0d92f68842f99018bfb208e1bab10432db9c3/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMargin.cpp

Project Member

Comment 158 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bfc8cc89c392fc7897189f5b2566b5858fa3b79

commit 0bfc8cc89c392fc7897189f5b2566b5858fa3b79
Author: Jia <jiameng@chromium.org>
Date: Thu Jul 20 03:04:33 2017

Implement parseShorthand for border-[bottom|left|right|top], column-rule, flex-flow, list-style and text-decoration.

All these shorthand properties call the same helper function
ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in
one cl.

This cl also removes ConsumeShorthandGreedily from CSSPropertyParser, 
as it is now fully replaced by ConsumeShorthandGreedilyViaLonghandAPIs.

Bug: 668012
Diff: https://gist.github.com/3747ac6e05e864871ac92f82fd49a822/revisions
Change-Id: Ice96f50a33c609bab24f5ab677b942ed4d424e97
Reviewed-on: https://chromium-review.googlesource.com/575608
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488113}
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderBottom.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderLeft.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRight.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderTop.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIColumnRule.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlexFlow.cpp
[add] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIListStyle.cpp
[modify] https://crrev.com/0bfc8cc89c392fc7897189f5b2566b5858fa3b79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITextDecoration.cpp

Project Member

Comment 159 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5275eb16f93c821123d826f3dc5744b8af57b0e5

commit 5275eb16f93c821123d826f3dc5744b8af57b0e5
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Jul 20 22:24:02 2017

Implements CSSPropertyAPI for -webkit-perspective/perspective

As part of Project Ribbon, separate the parsing logic for CSS
properties -webkit-perspective and perspective from
the parser into an API.

Bug: 668012

Signed-off-by: Rob Buis <rob.buis@samsung.com>
Change-Id: I504248e8561a9f97f741a5b5e3338b29d6caa395
Reviewed-on: https://chromium-review.googlesource.com/578213
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488440}
[modify] https://crrev.com/5275eb16f93c821123d826f3dc5744b8af57b0e5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/5275eb16f93c821123d826f3dc5744b8af57b0e5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/5275eb16f93c821123d826f3dc5744b8af57b0e5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspective.cpp

Project Member

Comment 160 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a75d4a501065f1d6977f4905e9ce382b3e9405a

commit 3a75d4a501065f1d6977f4905e9ce382b3e9405a
Author: Bugs Nash <bugsnash@chromium.org>
Date: Fri Jul 21 05:36:48 2017

Implemented parsing logic in simple single property APIs

This patch
- Implemented the parsing logic for the single property APIs for the
  following properties
  - offset-distance
  - offset-rotate
  - -webkit-box-flex
  - -webkit-border-image
- Removed the legacy parsing logic for these properties from
  CSSPropertyParser.cpp
- updated CSSProperties.json5 so that the generated header files for
  the property APIs are updated

diff for generated files:
https://gist.github.com/BugsNash/8844b947b4e7e165b7475684b04da92c/revisions

Bug: 668012
Change-Id: I144a82c9ba6727af9387a59a6d57427fd223327b
Reviewed-on: https://chromium-review.googlesource.com/578757
Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488594}
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetDistance.cpp
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetRotate.cpp
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderImage.cpp
[modify] https://crrev.com/3a75d4a501065f1d6977f4905e9ce382b3e9405a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlex.cpp

Project Member

Comment 161 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71aba56b3637c831d4b868fc7aa96184f58c63aa

commit 71aba56b3637c831d4b868fc7aa96184f58c63aa
Author: Jia <jiameng@chromium.org>
Date: Fri Jul 21 06:30:46 2017

Revert "Implement API for shorthand properties animation and transition."

This reverts commit 51c2bff2427cc101d464b1c559c9cc868f0344c2.

Reason for revert: causing a crash on clusterfuzz (crbug.com/746769)

Original change's description:
> Implement API for shorthand properties animation and transition.
> 
> This cl is a resubmission of an earlier cl (crrev.com/c/549675), which
> was reverted to fix a crash on one specific version of Google Pixel.
> The difference between this cl and the previous cl is in the
> implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand:
> - The old version is a templated function that uses function callback
>   and variable number of args.
> - The new version uses a function pointer, which is simpler than a
>   callback.
> 
> The original crash was not reproducible using the old patch. 
> But it is probably better to use function pointers instead of 
> a callback function with variable number of bugs. 
> 
> Have run this new patch on a pixel phone and there was not crash. 
> 
> Bug: 668012
> Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4
> Reviewed-on: https://chromium-review.googlesource.com/569505
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487372}

TBR=alancutter@chromium.org,jiameng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 746769
Change-Id: Ie93a301b97d599e593fcc4dac8c3a30ca972fcf3
Reviewed-on: https://chromium-review.googlesource.com/580588
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488601}
[modify] https://crrev.com/71aba56b3637c831d4b868fc7aa96184f58c63aa/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/71aba56b3637c831d4b868fc7aa96184f58c63aa/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/71aba56b3637c831d4b868fc7aa96184f58c63aa/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/71aba56b3637c831d4b868fc7aa96184f58c63aa/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/71aba56b3637c831d4b868fc7aa96184f58c63aa/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.cpp
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[delete] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 162 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19e177ec1153afbdd1e5b49e428e93646a8128a

commit e19e177ec1153afbdd1e5b49e428e93646a8128a
Author: Bugs Nash <bugsnash@chromium.org>
Date: Fri Jul 21 08:09:43 2017

Refactored out need to pass CSSPropertyID in background list parsing.

Rewritten from https://codereview.chromium.org/2897833004, this version
does not use the memory optimisation which has since been removed from
the code.

This patch
- Split property specific parsing logic for background components
  into the case statements in CSSPropertyParser::ParseSingleValue,
  using the general ConsumeCommaSeparatedList template instead of
  ConsumeCommaSeparatedBackgroundComponent so that CSSPropertyID
  no longer needs to be passed.
- Delted ConsumeCommaSeparatedBackgroundComponent (now unused).

NB
- ConsumeBackgroundComponent is still currently used in
  ConsumeBackgroundShorthand and so cannot be deleted.
- Some bool literals are passed in this patch, violating the style
  guide. These arguments were not introduced in this patch and so
  will not be fixed in this patch. They will be converted to enums
  when the APIs are implemented.

Bug: 668012
Change-Id: Ie364b810e10f0df3b3053e337d47fd60118cc985
Reviewed-on: https://chromium-review.googlesource.com/575253
Reviewed-by: Renée Wright <rjwright@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488613}
[modify] https://crrev.com/e19e177ec1153afbdd1e5b49e428e93646a8128a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 163 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6277982b8456b753fd964905ff940fc4d6017bed

commit 6277982b8456b753fd964905ff940fc4d6017bed
Author: Bugs Nash <bugsnash@chromium.org>
Date: Mon Jul 24 06:07:29 2017

Implemented parsing logic for grid-template-areas in property API

This patch
- implemented the parsing logic for the property grid-template-areas in
  the property API
- Removed the legacy parsing logic for this property from
  CSSPropertyParser.cpp
- updated CSSProperties.json5 so that the relevant generated files are
  updated.
- added #include StringHash.h in GridArea.h because GridArea.h
  defines a HashMap with a String key (NamedGridAreaMap). Calling
  .find() on a NamedGridAreaMap without knowledge of StringHash
  results in a compile error.

Diff in generated files:
https://gist.github.com/BugsNash/a48d571d91d90992e4afb50fa4ba7efe/revisions

Bug: 668012
Change-Id: I992c3351610de3382f6b7ae2741b63d44d95266a
Reviewed-on: https://chromium-review.googlesource.com/578538
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488923}
[modify] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateAreas.cpp
[add] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/properties/CSSPropertyGridTemplateAreasUtils.cpp
[add] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/css/properties/CSSPropertyGridTemplateAreasUtils.h
[modify] https://crrev.com/6277982b8456b753fd964905ff940fc4d6017bed/third_party/WebKit/Source/core/style/GridArea.h

Project Member

Comment 164 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c34ef9847e20b1ce74b983a14c6a136e44eb4e79

commit c34ef9847e20b1ce74b983a14c6a136e44eb4e79
Author: Jia <jiameng@chromium.org>
Date: Tue Jul 25 03:17:30 2017

Implement parseShorthand for grid-column and grid-row.

This cl also refactors the following functions from CSSPropertyParser
and moves them to a util file CSSPropertyGrid.
- ConsumeGridItemPositionShorthand
- ConsumeGridLine
- ConsumeCustomIdentForGridLine

Bug: 668012
Change-Id: I0b75b2f156a000e6c886babeccfd0ab8d9ba6b2a
Reviewed-on: https://chromium-review.googlesource.com/575124
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Javier Fernandez (OOO till Aug 4th) <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#489208}
[modify] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/properties/CSSPropertyGridUtils.cpp
[add] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/properties/CSSPropertyGridUtils.h
[add] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridColumn.cpp
[add] https://crrev.com/c34ef9847e20b1ce74b983a14c6a136e44eb4e79/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridRow.cpp

Project Member

Comment 165 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb

commit de69f63156bddb2e3807e6aeb4ab1a2be1622cfb
Author: Jia <jiameng@chromium.org>
Date: Tue Jul 25 04:28:34 2017

Implement API for scroll-boundary-behavior.

This cl also removes Consume2Values from CSSPropertyParser as it's no
longer used.

Bug: 668012
Change-Id: Idabf30e1f196a79c16cdb9f67e76ccb569791196
Reviewed-on: https://chromium-review.googlesource.com/582261
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489230}
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[modify] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[add] https://crrev.com/de69f63156bddb2e3807e6aeb4ab1a2be1622cfb/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollBoundaryBehavior.cpp

Project Member

Comment 166 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b4ce5991293f5936276b293ed6c9e36fb6d564

commit d4b4ce5991293f5936276b293ed6c9e36fb6d564
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 26 05:08:50 2017

Implement API for shorthand properties animation and transition.

This cl is a resubmission of an earlier cl (crrev.com/c/569505), which
was reverted to fix a clusterfuzz issue.

The difference between this cl and the previous cl is in replacing
HeapVector<CSSValue*> by HeapVector<Member<CSSValue>>.

Bug: 668012
Change-Id: Iba35c7b5ce5df91507029c059a5ff0cd52568540
Reviewed-on: https://chromium-review.googlesource.com/582670
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489553}
[modify] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.cpp
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[add] https://crrev.com/d4b4ce5991293f5936276b293ed6c9e36fb6d564/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 167 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4e19610bb9e3917fea7a2e990149c548e8dbc49

commit d4e19610bb9e3917fea7a2e990149c548e8dbc49
Author: Jia <jiameng@chromium.org>
Date: Wed Jul 26 09:39:12 2017

Add entries to core/BUILD.gn and json for shorthands to have APIs soon.

This cl summarizes some of the shorthands that will have APIs soon.
There are other shorthands whose APIs are already in review, hence
are not included here.

Bug: 668012
Change-Id: I0ae4e0bbbd48f903a75a842b6690e191508a73a5
Reviewed-on: https://chromium-review.googlesource.com/583413
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489578}
[modify] https://crrev.com/d4e19610bb9e3917fea7a2e990149c548e8dbc49/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/d4e19610bb9e3917fea7a2e990149c548e8dbc49/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 168 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a7c517b84e7df2f8361b31c2da290cf12a9bddd

commit 8a7c517b84e7df2f8361b31c2da290cf12a9bddd
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Jul 26 12:53:42 2017

Implements CSSPropertyAPI for various SVG properties

As part of Project Ribbon, separate the parsing logic for CSS
properties x, y, cx, cy, r, stroke-width and stroke-dashoffset
from the parser into an API.

Bug: 668012
Change-Id: Ie87bc50c3308f5e291a09888d79ebabcedf57080
Reviewed-on: https://chromium-review.googlesource.com/581932
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#489619}
[modify] https://crrev.com/8a7c517b84e7df2f8361b31c2da290cf12a9bddd/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/8a7c517b84e7df2f8361b31c2da290cf12a9bddd/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/8a7c517b84e7df2f8361b31c2da290cf12a9bddd/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeOrLength.cpp

Project Member

Comment 169 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9999dfe43c2cafcca50ca2c2bf1110b09386177b

commit 9999dfe43c2cafcca50ca2c2bf1110b09386177b
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Jul 27 16:13:19 2017

Implements CSSPropertyAPI for -webkit-filter/filter/background-filter

As part of Project Ribbon, separate the parsing logic for CSS
properties -webkit-filter, filter and background-filter from
the parser into an API.

Bug: 668012
Change-Id: I28c68caef886d955cfcd50daa3a29839b145709a
Reviewed-on: https://chromium-review.googlesource.com/581250
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489956}
[modify] https://crrev.com/9999dfe43c2cafcca50ca2c2bf1110b09386177b/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/9999dfe43c2cafcca50ca2c2bf1110b09386177b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/9999dfe43c2cafcca50ca2c2bf1110b09386177b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFilter.cpp

Project Member

Comment 170 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd79e500d319450624c9d4eed30639693e34e76e

commit cd79e500d319450624c9d4eed30639693e34e76e
Author: Jia <jiameng@chromium.org>
Date: Fri Jul 28 02:36:39 2017

Implement parseShorthand for 6 legacy break properties.

This implements parseShorthand for page-break-[after|before|inside] 
and -webkit-column-break-[after|before|inside].

This cl also refactors related util functions and moves them from
CSSPropertyParsers to a new util file CSSPropertyLegacyBreakUtils.

Bug: 668012
Change-Id: I96673b991fd6cca72cc24e3d27dc3afdaddb76c4
Reviewed-on: https://chromium-review.googlesource.com/585028
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490219}
[modify] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSPropertyLegacyBreakUtils.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSPropertyLegacyBreakUtils.h
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakAfter.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakBefore.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakInside.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakAfter.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakBefore.cpp
[add] https://crrev.com/cd79e500d319450624c9d4eed30639693e34e76e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakInside.cpp

Project Member

Comment 171 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5

commit a270ef7c9defbdb8554f8cfe0868fa9a67b67da5
Author: Bugs Nash <bugsnash@chromium.org>
Date: Fri Jul 28 04:49:40 2017

Implemented parsing logic in single background property APIs

This patch
- Implemented parsing logic property APIs for the following single
  properties:
  - background-attachment
  - background-blend-mode
  - mask-source-type
  - -webkit-mask-composite
- Removed the legacy parsing logic for these properties from
  CSSPropertyParser.cpp
- Updated CSSProperties.json5 so that the generated header files for
  the property APIs are updated
- Moved common functions from CSSPOropertyParser.cpp to
  CSSPropertyBackgroundUtils.cpp. These have been kept in the same
  utils file for ease of use in the background shorthand when the
  API parsing is implemented

Diff for generated files:
https://gist.github.com/58f44774beef3184830d77528be8cfdd/revisions

Bug: 668012
Change-Id: Ida51effbfb39c50749f90d584a74156073bb463e
Reviewed-on: https://chromium-review.googlesource.com/582260
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490267}
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundAttachment.cpp
[add] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBlendMode.cpp
[add] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMaskSourceType.cpp
[add] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaskComposite.cpp
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/a270ef7c9defbdb8554f8cfe0868fa9a67b67da5/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h

Project Member

Comment 173 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e106f712e6f24ca68964a126693e6d0c57c02226

commit e106f712e6f24ca68964a126693e6d0c57c02226
Author: Jia <jiameng@chromium.org>
Date: Fri Jul 28 10:03:07 2017

Implement parseShorthand for place-[content|items|self].

This cl also refactors util functions and moves them from
CSSPropertyParser to CSSPropertyPlaceUtils file.

Bug: 668012
Change-Id: Ifbb4ae30df07555f0298bcd1618c23ca96b2cda5
Diff: https://gist.github.com/784f237041c1bd419a367bfd10b71a5d/revisions
Reviewed-on: https://chromium-review.googlesource.com/584637
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490344}
[modify] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[add] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/properties/CSSPropertyPlaceUtils.cpp
[add] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/properties/CSSPropertyPlaceUtils.h
[add] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceContent.cpp
[add] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceItems.cpp
[add] https://crrev.com/e106f712e6f24ca68964a126693e6d0c57c02226/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceSelf.cpp

Project Member

Comment 174 by bugdroid1@chromium.org, Jul 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8

commit 26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8
Author: Bugs Nash <bugsnash@chromium.org>
Date: Sun Jul 30 21:55:29 2017

Added null safety to CSSParserContext args in CSSProperty utils files

This patch
- Changed CSSParserContext argument from * to & for null safety and
  readability in the remaining utils files in core/css/properties
- Changed the CSSPropertyParserHelpers::ConsumeCommaSeparatedList
  parameter pack argument to a universal reference with perfect
  forwarding so that reference arguments can be passed through it.

Bug: 668012
Change-Id: I5e607c9a1f8e26d7848092468d666f9879711941
Reviewed-on: https://chromium-review.googlesource.com/590910
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490691}
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationName.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderImage.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxReflect.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSPropertyTransformUtils.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/26f38f3f2c001ff2d3ca31354cd88a7a5817c4c8/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp

Project Member

Comment 175 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a68f1fc165546a950bc013ad0e72399dbba91af

commit 4a68f1fc165546a950bc013ad0e72399dbba91af
Author: Bugs Nash <bugsnash@chromium.org>
Date: Mon Jul 31 06:13:38 2017

Deleted duplicate methods accidentally introduced in 578538

This patch deleted the duplicated methods accudentally introdued in
https://chromium-review.googlesource.com/c/578538/ when they were
supposed to be moved from CSSPropertyParser.cpp to
CSSPropertyGridTemplateAreasUtils.cpp but instead they were copied.

Bug: 668012
Change-Id: I3c7b32911fcc8ff64a200f1bdfb06cd17d15fd0a
Reviewed-on: https://chromium-review.googlesource.com/593371
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490716}
[modify] https://crrev.com/4a68f1fc165546a950bc013ad0e72399dbba91af/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 176 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/264ba72311c29b759385d2c58bddeb993f500245

commit 264ba72311c29b759385d2c58bddeb993f500245
Author: Bugs Nash <bugsnash@chromium.org>
Date: Wed Aug 02 07:10:04 2017

Moved parsing logic to property APIs for grouped longhand properties

This patch:
- Moved parsing logic to property APIs for the following grouped
  properties:
    border-image-repeat
    border-image-slice
    border-image-outset
    border-image-width
    background-clip
    background-image
    background-origin
    -webkit-transform-origin-x
    -webkit-transform-origin-y
   -webkit-perspective-origin-x
    -webkit-perspective-origin-y
    -webkit-mask-box-image-repeat
    -webkit-mask-box-image-slice
    -webkit-mask-box-image-outset
    -webkit-mask-box-image-width
    -webkit-mask-image
- Replaced the bool literal argument in BorderImageUtils with a
  new enum class to comply with the style guide
- Added #includes to PositionUtils that should have been there
  when the file was created. For some reason this only started
  causing build errors in this patch

Bug: 668012
Change-Id: I796f0967e4222689c14700b12d7726df7ab35170
Reviewed-on: https://chromium-review.googlesource.com/597378
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491288}
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBox.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskImage.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageOutset.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageRepeat.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageSlice.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageWidth.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDelay.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDuration.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
[add] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITimingFunction.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginX.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginY.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/264ba72311c29b759385d2c58bddeb993f500245/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp

Project Member

Comment 177 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd3e05690c2e00c4603cdcb2f135d7901619516

commit 3dd3e05690c2e00c4603cdcb2f135d7901619516
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Aug 02 12:16:30 2017

Revert "Moved parsing logic to property APIs for grouped longhand properties"

This reverts commit 264ba72311c29b759385d2c58bddeb993f500245.

Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot.

Sample failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635

Will reland if it does not fix the problem.

Original change's description:
> Moved parsing logic to property APIs for grouped longhand properties
> 
> This patch:
> - Moved parsing logic to property APIs for the following grouped
>   properties:
>     border-image-repeat
>     border-image-slice
>     border-image-outset
>     border-image-width
>     background-clip
>     background-image
>     background-origin
>     -webkit-transform-origin-x
>     -webkit-transform-origin-y
>    -webkit-perspective-origin-x
>     -webkit-perspective-origin-y
>     -webkit-mask-box-image-repeat
>     -webkit-mask-box-image-slice
>     -webkit-mask-box-image-outset
>     -webkit-mask-box-image-width
>     -webkit-mask-image
> - Replaced the bool literal argument in BorderImageUtils with a
>   new enum class to comply with the style guide
> - Added #includes to PositionUtils that should have been there
>   when the file was created. For some reason this only started
>   causing build errors in this patch
> 
> Bug: 668012
> Change-Id: I796f0967e4222689c14700b12d7726df7ab35170
> Reviewed-on: https://chromium-review.googlesource.com/597378
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Commit-Queue: Bugs Nash <bugsnash@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491288}

TBR=meade@chromium.org,bugsnash@chromium.org

Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668012
Reviewed-on: https://chromium-review.googlesource.com/597888
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491346}
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBox.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskImage.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageOutset.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageRepeat.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageSlice.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageWidth.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDelay.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDuration.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
[delete] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITimingFunction.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginX.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginY.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/3dd3e05690c2e00c4603cdcb2f135d7901619516/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp

Project Member

Comment 178 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a27a65933598dfa8795bdf04e31ac5a94002619

commit 8a27a65933598dfa8795bdf04e31ac5a94002619
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Aug 02 14:14:53 2017

Revert "Revert "Moved parsing logic to property APIs for grouped longhand properties""

This reverts commit 3dd3e05690c2e00c4603cdcb2f135d7901619516.

Reason for revert: Relanding original CL since the revert did not fix the bot.

Original change's description:
> Revert "Moved parsing logic to property APIs for grouped longhand properties"
> 
> This reverts commit 264ba72311c29b759385d2c58bddeb993f500245.
> 
> Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot.
> 
> Sample failed build:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635
> 
> Will reland if it does not fix the problem.
> 
> Original change's description:
> > Moved parsing logic to property APIs for grouped longhand properties
> > 
> > This patch:
> > - Moved parsing logic to property APIs for the following grouped
> >   properties:
> >     border-image-repeat
> >     border-image-slice
> >     border-image-outset
> >     border-image-width
> >     background-clip
> >     background-image
> >     background-origin
> >     -webkit-transform-origin-x
> >     -webkit-transform-origin-y
> >    -webkit-perspective-origin-x
> >     -webkit-perspective-origin-y
> >     -webkit-mask-box-image-repeat
> >     -webkit-mask-box-image-slice
> >     -webkit-mask-box-image-outset
> >     -webkit-mask-box-image-width
> >     -webkit-mask-image
> > - Replaced the bool literal argument in BorderImageUtils with a
> >   new enum class to comply with the style guide
> > - Added #includes to PositionUtils that should have been there
> >   when the file was created. For some reason this only started
> >   causing build errors in this patch
> > 
> > Bug: 668012
> > Change-Id: I796f0967e4222689c14700b12d7726df7ab35170
> > Reviewed-on: https://chromium-review.googlesource.com/597378
> > Reviewed-by: meade_UTC10 <meade@chromium.org>
> > Commit-Queue: Bugs Nash <bugsnash@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#491288}
> 
> TBR=meade@chromium.org,bugsnash@chromium.org
> 
> Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 668012
> Reviewed-on: https://chromium-review.googlesource.com/597888
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491346}

TBR=guidou@chromium.org,meade@chromium.org,bugsnash@chromium.org

Change-Id: I719f967cb722285f771fd123042da35996f4d284
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668012
Reviewed-on: https://chromium-review.googlesource.com/598167
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491365}
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBox.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskImage.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageOutset.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageRepeat.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageSlice.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageWidth.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDelay.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDuration.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
[add] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITimingFunction.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginX.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginY.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/8a27a65933598dfa8795bdf04e31ac5a94002619/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp

Project Member

Comment 179 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7370d7a77e6bcecf02914c3710c9fc28427f54e

commit c7370d7a77e6bcecf02914c3710c9fc28427f54e
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Aug 02 16:41:42 2017

Implements CSSPropertyAPI for logical width/height properties

As part of Project Ribbon, separate the parsing logic for these CSS
properties from the parser into an API:
- block-size
- inline-size
- min-block-size
- min-inline-size
- -webkit-min-logical-width
- -webkit-min-logical-height
- -webkit-logical-width
- -webkit-logical-height

Bug: 668012

Signed-off-by: Rob Buis <rob.buis@samsung.com>
Change-Id: I1689c5df226f0dd0adf660705ba80c5ed4c7bd9e
Reviewed-on: https://chromium-review.googlesource.com/589607
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491402}
[modify] https://crrev.com/c7370d7a77e6bcecf02914c3710c9fc28427f54e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/c7370d7a77e6bcecf02914c3710c9fc28427f54e/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/c7370d7a77e6bcecf02914c3710c9fc28427f54e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/c7370d7a77e6bcecf02914c3710c9fc28427f54e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/c7370d7a77e6bcecf02914c3710c9fc28427f54e/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILogicalWidthOrHeight.cpp
[delete] https://crrev.com/aa14880e020c72fad191ea95846296b2e320346a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLogicalWidthOrHeight.cpp

Project Member

Comment 180 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4bb81bf023901d629086e8eb7fd1f252da3ae7

commit bf4bb81bf023901d629086e8eb7fd1f252da3ae7
Author: Jia <jiameng@chromium.org>
Date: Thu Aug 03 09:55:14 2017

Implement parseShorthand API for marker and grid-gap.

For marker property, CSSPropertyInvalid was used as the 
"current_shorthand" in the old/non-API parsing method 
because it's not used. In its API, we use 
CSSPropertyMarker just to avoid confusion.  There is no 
real difference.

Bug: 668012
Change-Id: I528f7da64d6dc6537a248e8b6a08b3940c0f3b90
Reviewed-on: https://chromium-review.googlesource.com/597092
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491688}
[modify] https://crrev.com/bf4bb81bf023901d629086e8eb7fd1f252da3ae7/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/bf4bb81bf023901d629086e8eb7fd1f252da3ae7/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/bf4bb81bf023901d629086e8eb7fd1f252da3ae7/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/bf4bb81bf023901d629086e8eb7fd1f252da3ae7/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridGap.cpp
[add] https://crrev.com/bf4bb81bf023901d629086e8eb7fd1f252da3ae7/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMarker.cpp

Project Member

Comment 181 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41390e8028d8bbe0deb48b3a41017342b57b7eb9

commit 41390e8028d8bbe0deb48b3a41017342b57b7eb9
Author: Jia <jiameng@chromium.org>
Date: Fri Aug 04 05:20:46 2017

Implement parseShorthand API for grid and grid-template.

This cl also refactors util functions and moves them from
CSSPropertyParser to CSSPropertyGridUtils and moves
functions from CSSPropertyGridTemplateAreasUtils to
CSSPropertyGridUtils as the functions are used by multiple
grid-related properties, and we won't have to call one util
file from another util file.

The old version of several util functions parse property values
and also add parsed values to the parsed-property-set, which
means these util functions need to take shorthand property id
as an input. A major change in this cl is splitting parsing
and adding values. Adding property values will be
handled by property API classes. The benefits of this refactoring
are
(i). util functions no longer need to take shorthand id as input,
and thus become pure util functions.
(ii). it is now more obvious which property values are added.
Previously property values are added at different places, but now
they are only added in the property API files.

Functions below have major changes mentioned above.
1. ConsumeGridTemplateRowsAndAreasAndColumns
- The old version parses and adds property values.
- The new version only parses values and returns values to the caller.

2. ConsumeGridTemplateShorthand
- The old version parses and adds property values (by calling
ConsumeGridTemplateRowsAndAreasAndColumns for some cases).
- The new version only parses values and returns values to the caller.
It is shared by both grid and grid-template APIs.

3. ConsumGridShorthand
- The old version is replaced by grid's parseShorthand method.
- The old version parses property values both directly and indirectly
(by calling ConsumeGridTemplateShorthand), and adds property values
at different places.
- The new version calls util functions for parsing only, and
explicitly adds property values itself.

Bug: 668012
Change-Id: I4808bd1f169bcad5b3d46a83fc897567f18a0e7e
Reviewed-on: https://chromium-review.googlesource.com/595293
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491944}
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateAreas.cpp
[delete] https://crrev.com/a512add2d9eb7e0dd75e0a874ea00e08275ba9da/third_party/WebKit/Source/core/css/properties/CSSPropertyGridTemplateAreasUtils.cpp
[delete] https://crrev.com/a512add2d9eb7e0dd75e0a874ea00e08275ba9da/third_party/WebKit/Source/core/css/properties/CSSPropertyGridTemplateAreasUtils.h
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/properties/CSSPropertyGridUtils.cpp
[modify] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/properties/CSSPropertyGridUtils.h
[add] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGrid.cpp
[add] https://crrev.com/41390e8028d8bbe0deb48b3a41017342b57b7eb9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridTemplate.cpp

Project Member

Comment 182 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09cc533b6782ec44e77b819baf816f9446ce05d5

commit 09cc533b6782ec44e77b819baf816f9446ce05d5
Author: Rob Buis <rob.buis@samsung.com>
Date: Mon Aug 07 19:11:35 2017

Implements CSSPropertyAPI for width/height properties

As part of Project Ribbon, separate the parsing logic for CSS
properties width, height, min-width and min-height from
the parser into an API.

Bug: 668012

Change-Id: I7d13ab6562abc77eea8a241515bfea6b42f5b152
Reviewed-on: https://chromium-review.googlesource.com/590078
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492378}
[modify] https://crrev.com/09cc533b6782ec44e77b819baf816f9446ce05d5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/09cc533b6782ec44e77b819baf816f9446ce05d5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/09cc533b6782ec44e77b819baf816f9446ce05d5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/09cc533b6782ec44e77b819baf816f9446ce05d5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[delete] https://crrev.com/ad3091ff99173a62e3e28a234ad08c83ab20da7f/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
[modify] https://crrev.com/09cc533b6782ec44e77b819baf816f9446ce05d5/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWidthOrHeight.cpp

Project Member

Comment 183 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ada3a0d05f66b96f079283dc43112247491698

commit 70ada3a0d05f66b96f079283dc43112247491698
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Aug 07 20:15:46 2017

Revert "Implements CSSPropertyAPI for width/height properties"

This reverts commit 09cc533b6782ec44e77b819baf816f9446ce05d5.

Reason for revert: This CL depends on crrev.com/492279, which is breaking GPU bots and is being reverted. See crbug.com/753010. Sorry for the disruption.

Original change's description:
> Implements CSSPropertyAPI for width/height properties
> 
> As part of Project Ribbon, separate the parsing logic for CSS
> properties width, height, min-width and min-height from
> the parser into an API.
> 
> Bug: 668012
> 
> Change-Id: I7d13ab6562abc77eea8a241515bfea6b42f5b152
> Reviewed-on: https://chromium-review.googlesource.com/590078
> Commit-Queue: Rob Buis <rob.buis@samsung.com>
> Reviewed-by: Bugs Nash <bugsnash@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492378}

TBR=rob.buis@samsung.com,meade@chromium.org,bugsnash@chromium.org

Change-Id: I782cc2d9a03d95dc3cbab6b543bd91f205ef929e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668012
Reviewed-on: https://chromium-review.googlesource.com/604427
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492390}
[modify] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[add] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
[modify] https://crrev.com/70ada3a0d05f66b96f079283dc43112247491698/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWidthOrHeight.cpp

Project Member

Comment 184 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89bef37c3c9db783fc09dd5222399821258f9c34

commit 89bef37c3c9db783fc09dd5222399821258f9c34
Author: Bugs Nash <bugsnash@chromium.org>
Date: Tue Aug 08 02:24:34 2017

Removed unused argument to ConsumePrefixedBackgroundBox

Seems to have been added without being used in
https://codereview.chromium.org/1706573002

Bug: 668012
Change-Id: Ic4ee338905eb87c6d336ea1585c867bb310cf269
Reviewed-on: https://chromium-review.googlesource.com/602839
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492508}
[modify] https://crrev.com/89bef37c3c9db783fc09dd5222399821258f9c34/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 185 by bugdroid1@chromium.org, Aug 9 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c

commit 3c5376dbfebd3b433caea902f2e4e9f15c9ee50c
Author: Naina Raisinghani <nainar@chromium.org>
Date: Wed Aug 09 00:52:19 2017

Merging the change below into M61

Revert "Implement API for shorthand properties animation and transition."

This reverts commit 51c2bff2427cc101d464b1c559c9cc868f0344c2.

Reason for revert: causing a crash on clusterfuzz (crbug.com/746769)

Original change's description:
> Implement API for shorthand properties animation and transition.
>
> This cl is a resubmission of an earlier cl (crrev.com/c/549675), which
> was reverted to fix a crash on one specific version of Google Pixel.
> The difference between this cl and the previous cl is in the
> implementation of CSSPropertyAnimationUtils::ConsumeAnimationShorthand:
> - The old version is a templated function that uses function callback
>   and variable number of args.
> - The new version uses a function pointer, which is simpler than a
>   callback.
>
> The original crash was not reproducible using the old patch.
> But it is probably better to use function pointers instead of
> a callback function with variable number of bugs.
>
> Have run this new patch on a pixel phone and there was not crash.
>
> Bug: 668012
> Change-Id: I183df5f3a168fffbed253a8b47b177fa72cd06b4
> Reviewed-on: https://chromium-review.googlesource.com/569505
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487372}

TBR=alancutter@chromium.org, jiameng@chromium.org


(cherry picked from commit 71aba56b3637c831d4b868fc7aa96184f58c63aa)

Bug: 746769
Change-Id: Ie93a301b97d599e593fcc4dac8c3a30ca972fcf3
Reviewed-on: https://chromium-review.googlesource.com/580588
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488601}
Reviewed-on: https://chromium-review.googlesource.com/606563
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#398}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/3c5376dbfebd3b433caea902f2e4e9f15c9ee50c/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.cpp
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationTimingFunctionUtils.h
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.cpp
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationUtils.h
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[delete] https://crrev.com/cf4ee0d3258c398aef4f7262273e0b257d86edd9/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp

Project Member

Comment 186 by bugdroid1@chromium.org, Aug 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d337b97d5495b3c09d0a3185cd11eaf131b3cc12

commit d337b97d5495b3c09d0a3185cd11eaf131b3cc12
Author: Jia <jiameng@chromium.org>
Date: Sun Aug 13 04:04:43 2017

Implement ParseShorthand for border property.

This cl also moves AddExpandedPropertyForValue from CSSPropertyParser
to CSSPropertyParserHelpers, with a small modification to make it work
in the Helpers file.

Bug: 668012
Change-Id: Iff9a834274d0899c2c0039238cd031254ca9e944
Reviewed-on: https://chromium-review.googlesource.com/611860
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493988}
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[add] https://crrev.com/d337b97d5495b3c09d0a3185cd11eaf131b3cc12/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorder.cpp

Project Member

Comment 187 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e205e8a59ac80617625dfdfaa286f68d76f735c

commit 7e205e8a59ac80617625dfdfaa286f68d76f735c
Author: Jia <jiameng@chromium.org>
Date: Wed Aug 16 08:37:18 2017

Change ParseShorthand signature to use local context.

Some shorthands will share APIs, hence we pass in local context as an
arg that contains the current shorthand id.

Bug: 668012
Change-Id: I69d9a38b590744dc163a13ec9b022202c6f4d5bb
Reviewed-on: https://chromium-review.googlesource.com/616488
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494725}
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIAnimation.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackgroundPosition.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorder.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderBottom.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderColor.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderImage.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderLeft.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRight.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderSpacing.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderStyle.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderTop.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderWidth.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIColumnRule.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIColumns.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlexFlow.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFontVariant.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGrid.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridArea.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridColumn.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridGap.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridRow.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIGridTemplate.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIListStyle.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMargin.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIMarker.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOffset.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOutline.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOverflow.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPadding.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakAfter.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakBefore.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPageBreakInside.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceContent.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceItems.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIPlaceSelf.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollBoundaryBehavior.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPadding.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPaddingBlock.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollPaddingInline.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMargin.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMarginBlock.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIScrollSnapMarginInline.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITextDecoration.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPITransition.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderAfter.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderBefore.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderEnd.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitBorderStart.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakAfter.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakBefore.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitColumnBreakInside.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskBoxImage.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskPosition.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextEmphasis.cpp
[modify] https://crrev.com/7e205e8a59ac80617625dfdfaa286f68d76f735c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitTextStroke.cpp

Project Member

Comment 188 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12988d35e9aba24644d512eae484b086528d0f4e

commit 12988d35e9aba24644d512eae484b086528d0f4e
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Aug 16 12:57:30 2017

Implements CSSPropertyAPI for width/height properties

As part of Project Ribbon, separate the parsing logic for CSS
properties width, height, min-width and min-height from
the parser into an API.

Bug: 668012
Change-Id: I8c295724765ac28f9542badc95adc4ce8cae5d06
Reviewed-on: https://chromium-review.googlesource.com/615663
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#494755}
[modify] https://crrev.com/12988d35e9aba24644d512eae484b086528d0f4e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/12988d35e9aba24644d512eae484b086528d0f4e/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/12988d35e9aba24644d512eae484b086528d0f4e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/12988d35e9aba24644d512eae484b086528d0f4e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[delete] https://crrev.com/ce9412c7f3092fad31ac060a00e52656c2cf66d6/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
[modify] https://crrev.com/12988d35e9aba24644d512eae484b086528d0f4e/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWidthOrHeight.cpp

Project Member

Comment 189 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e

commit 10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e
Author: Rob Buis <rob.buis@samsung.com>
Date: Wed Aug 16 16:06:51 2017

Implements CSSPropertyAPI for max-width/max-height properties

As part of Project Ribbon, separate the parsing logic for CSS
properties width, height, min-width and min-height from
the parser into an API.

Bug: 668012

Change-Id: I2c0894309be91fa552f6056cb7bc5818daba5598
Signed-off-by: Rob Buis <rob.buis@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/601054
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494805}
[modify] https://crrev.com/10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/10bb8f84df6ae32ba0a547f5e9b477e0cdc6319e/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMaxWidthOrHeight.cpp

Project Member

Comment 190 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34caacfb9801814660f68bdda82f0473fe1c752a

commit 34caacfb9801814660f68bdda82f0473fe1c752a
Author: Bugs Nash <bugsnash@chromium.org>
Date: Thu Aug 17 04:21:10 2017

Added null safety to CSSParserContext args in remaining custom parsing

Changed CSSParserContext argument from * to & for null safety and
readability in remaining locations in custom parsing, including a
private API method and a legacy method in CSSPropertyAPIBaseHelper.cpp

Bug: 668012
Change-Id: Ic76271cfff5386e96a7231a92d0985f9f41d9c23
Reviewed-on: https://chromium-review.googlesource.com/603034
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495069}
[modify] https://crrev.com/34caacfb9801814660f68bdda82f0473fe1c752a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/34caacfb9801814660f68bdda82f0473fe1c752a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp

Project Member

Comment 191 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd6fbd03df35d08a37ac52d767df937ef1ba50d2

commit bd6fbd03df35d08a37ac52d767df937ef1ba50d2
Author: Bugs Nash <bugsnash@chromium.org>
Date: Thu Aug 17 10:27:34 2017

Moved parsing logic to property APIs for grouped longhand properties

This patch:
- Moved parsing logic to property APIs for the following grouped
  properties:
    background-position-x
    background-position-y
    background-size
    grid-auto-columns
    grid-auto-rows
    grid-column-end
    grid-column-start
    grid-row-end
    grid-row-start
    grid-template-columns
    grid-template-rows
    -webkit-mask-position
    -webkit-mask-position
    -webkit-mask-size
- Moved ConsumeBackgroundSize method from CSSPropertyParser to
  CSSPropertyBackgroundUtils so it can be used from property APIs
- Replaced the bool literal argument to ConsumeBackgroundSize with a
  new enum class to comply with style guides

Bug: 668012
Change-Id: I1df4b0e06abc5a27cc646a83b5f4cf6ff87c8699
Reviewed-on: https://chromium-review.googlesource.com/618311
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495129}
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[add] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskSize.cpp
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoLine.cpp
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridLine.cpp
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateLine.cpp
[add] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPositionX.cpp
[add] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPositionY.cpp
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/bd6fbd03df35d08a37ac52d767df937ef1ba50d2/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h

Project Member

Comment 192 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f536902c5e94852ceb2e310799ffaf85cd025c36

commit f536902c5e94852ceb2e310799ffaf85cd025c36
Author: Rob Buis <rob.buis@samsung.com>
Date: Mon Aug 21 16:46:03 2017

Remove longhand handling for webkit-mask-repeat-x/y

As part of Project Ribbon, remove longhand handling for
properties -webkit-mask-repeat-x and -webkit-mask-repeat-y from
the parser because the fallback will be correct, i.e. the
property will be dropped. Note that we still use them indirectly
as part of the -webkit-mask-repeat and -webkit-mask shorthands.

Bug: 668012
Change-Id: Ice1e9df6b6bf8ddaf8cd660cbdd69ba364997606
Reviewed-on: https://chromium-review.googlesource.com/620907
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495962}
[modify] https://crrev.com/f536902c5e94852ceb2e310799ffaf85cd025c36/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/f536902c5e94852ceb2e310799ffaf85cd025c36/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/f536902c5e94852ceb2e310799ffaf85cd025c36/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/f536902c5e94852ceb2e310799ffaf85cd025c36/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[delete] https://crrev.com/102807063e0f77cda1abca68a1fabaa2a03dd04b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaskRepeat.cpp

Project Member

Comment 193 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4

commit b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4
Author: Rob Buis <rob.buis@samsung.com>
Date: Tue Aug 22 20:35:24 2017

Implements CSSPropertyAPI for clip/origin longhand properties

As part of Project Ribbon, separate the parsing logic for CSS properties
-webkit-mask-clip, -webkit-mask-origin, -webkit-background-clip and
-webkit-background-origin from the parser into an API.

Bug: 668012

Signed-off-by: Rob Buis <rob.buis@samsung.com>
Change-Id: I049f06489c33321e8a316b5eccaf7a77c9a80585
Reviewed-on: https://chromium-review.googlesource.com/619612
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496429}
[modify] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[add] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitClip.cpp
[add] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOrigin.cpp
[modify] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/b0b3d8d80f4de5ce1e75ef39d8ece56a63038ea4/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h

Project Member

Comment 194 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/164dc0f587dc3ded4aea236658864720ed6f7b68

commit 164dc0f587dc3ded4aea236658864720ed6f7b68
Author: Jia <jiameng@chromium.org>
Date: Wed Aug 23 05:38:54 2017

Implement parseShorthand API for 4 background related properties.

This cl implements parseShorthand APIs for background, -webkit-mask,
background-repeat and -webkit-mask-repeat.

Properties background and -webkit-mask are handled by the same API. 
This is because their parsing logic is too similar. In order to avoid
duplicating the code and also without having to pass shorthand id to
util functions, we check shorthand id within the API class and 
parses property according to shorthand id.

Bug: 668012
Change-Id: I0751a2b7517fb3fbff53adeb54797fda8f89dd80
Reviewed-on: https://chromium-review.googlesource.com/601770
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496591}
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[delete] https://crrev.com/1623c229c1ff1683e973261c1e3343a1b9afa057/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseHelper.cpp
[delete] https://crrev.com/1623c229c1ff1683e973261c1e3343a1b9afa057/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseHelper.h
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitClip.cpp
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOrigin.cpp
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.h
[add] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackground.cpp
[add] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackgroundRepeat.cpp
[add] https://crrev.com/164dc0f587dc3ded4aea236658864720ed6f7b68/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMaskRepeat.cpp

Project Member

Comment 195 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f4e5bd06c7d60961f2399fcfae4a837b78092e

commit 01f4e5bd06c7d60961f2399fcfae4a837b78092e
Author: Bugs Nash <bugsnash@chromium.org>
Date: Wed Sep 13 01:18:45 2017

Remove unused headers from CSSPropertyParser.cpp

Bug: 668012
Change-Id: Ib461879750e52584990e1547c3807b12e08d6972
Reviewed-on: https://chromium-review.googlesource.com/663103
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501499}
[modify] https://crrev.com/01f4e5bd06c7d60961f2399fcfae4a837b78092e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Project Member

Comment 196 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff940dfb7356b481b062274eab29453939bda7cc

commit ff940dfb7356b481b062274eab29453939bda7cc
Author: Bugs Nash <bugsnash@chromium.org>
Date: Wed Sep 13 05:13:46 2017

Deleted custom parsing code now that it has all moved to APIs.

This patch
- Deleted custom implementations of ParseSingleValue and ParseShorthand
  since all the properties handled here have been implemented in
  property APIs.
- Added default implementation to generated CSSProprtyAPI header instead
- Deleted CSSPropertyAPIBaseCustom.cpp as it was now empty.

Bug: 668012
Change-Id: Ib969064802eb2724556f1bfffc12761263d98081
Reviewed-on: https://chromium-review.googlesource.com/664457
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501547}
[modify] https://crrev.com/ff940dfb7356b481b062274eab29453939bda7cc/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/ff940dfb7356b481b062274eab29453939bda7cc/third_party/WebKit/Source/core/css/BUILD.gn
[delete] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp

Project Member

Comment 197 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ff18909e38d1cd242978ea082196c9881e212aa

commit 0ff18909e38d1cd242978ea082196c9881e212aa
Author: Bugs Nash <bugsnash@chromium.org>
Date: Wed Sep 13 08:44:15 2017

Removed CSSPropertyID argument to parsing methods in property APIs

Now that the legacy parsing code has been removed from the base API
the CSSPropertyID argument is not required.

This patch deletes the argument from the following base class methods
as well as all overrides.
- CSSPropertyAPI::ParseSingleValue
- CSSPropertyAPI::ParseShorthand

Bug: 668012
Change-Id: Iad91612b5917d7349cf4f6f3a1beb1286c7256fc
Reviewed-on: https://chromium-review.googlesource.com/662927
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501572}
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignSelf.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationDirection.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationFillMode.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationIterationCount.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationName.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAnimationPlayState.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAutoOrString.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackdropFilter.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundAttachment.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBlendMode.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundBox.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskImage.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundOrMaskSize.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaselineShift.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageOutset.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageRepeat.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageSlice.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderRadius.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBoxShadow.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColorNoQuirks.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnCount.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnGap.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnRuleWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnSpan.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContain.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterReset.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPID.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDelay.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIDuration.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFillOrStrokeOpacity.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFilter.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexBasis.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexGrowOrShrink.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFeatureSettings.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSize.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontSizeAdjust.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStretch.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontStyle.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantCaps.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantEastAsian.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantLigatures.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontWeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoFlow.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoLine.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridLine.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateAreas.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateLine.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageSource.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifyItems.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifySelf.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILength.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILetterAndWordSpacing.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILineHeightStep.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIListStyleImage.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILogicalWidthOrHeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMarker.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMask.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMaskSourceType.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMaxWidthOrHeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIObjectPosition.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffset.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetDistance.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetRotate.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOpacity.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrder.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrphansOrWidows.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineOffset.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOutlineWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPadding.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPage.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintOrder.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPaintStroke.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspective.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspectiveOrigin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPositionX.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPositionY.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIQuotes.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRadius.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScale.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollPadding.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapAlign.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapMargin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapType.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeImageThreshold.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeMargin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPISize.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDashoffsetOrStrokeWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeMiterlimit.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITabSize.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationLine.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationSkip.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextIndent.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextShadow.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextSizeAdjust.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITimingFunction.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITouchAction.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransformOrigin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransitionProperty.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVerticalAlign.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderImage.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlex.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlexGroup.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxOrdinalGroup.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxReflect.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitClip.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitColorNoQuirks.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitFontSizeDelta.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaskComposite.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaxLogicalWidthOrHeight.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOrigin.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginX.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginY.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitPadding.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextDecorationsInEffect.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisPosition.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeColor.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeWidth.cpp
[modify] https://crrev.com/0ff18909e38d1cd242978ea082196c9881e212aa/third_party/WebKit/So
Cc: -meade@chromium.org bugsnash@chromium.org
Owner: meade@chromium.org
I'm going to be taking this over for Q4.
Blockedon: 752745
Cc: -jiameng@chromium.org
Labels: -Update-Monthly Update-Quarterly
Changing to Update-Quarterly as I'm tracking my work in the blocking bug.
Labels: -Update-Quarterly
Cc: meade@chromium.org
Owner: e...@chromium.org
Status: Assigned (was: Started)
Handing this to eae for future work. An incomplete design doc for the remaining tasks can be found here: https://docs.google.com/document/d/13kseMTScxVzkXcsPkl258yKmjD8U2nhs6PJu_MiFlpc/edit

Comment 202 by e...@chromium.org, Feb 27 2018

Cc: -meade@chromium.org -bugsnash@chromium.org -rjwright@chromium.org e...@chromium.org
Labels: -Type-Feature Type-Task
Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)
We've decided to not peruse this for the time being.
Showing comments 104 - 203 of 203 Older

Sign in to add a comment