Regression:navigation of /importData dialog on chrome://md-settings is wonky
Reported by
dmascare...@etouch.net,
Nov 23 2016
|
|||||
Issue descriptionChrome Version:57.0.2928.0 (Official Build) 61ab768cc656a8bef5e8f08972d0f58a74f89c83-refs/heads/master@{#433845} OS:Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome and chrome://md-settings 2. Click on 'Import bookmarks and settings' and then press 'Alt + <-',observe. 3. Press 'Alt + ->' once and observe Actual: Forward Arrow navigation of browser window is disable and 'Alt + ->' does not navigate to chrome://md-settings/importData Expected: Forward Arrow navigation should be enable and 'Alt + ->' should navigate to chrome://md-settings/importData in first press. This is regression issue, broken in 'M 57' and below is manual bisect info; Good build:57.0.2926.0 Bad build:57.0.2928.0 Note: Will soon update the other OS info
,
Nov 24 2016
Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/32d4b3a47daccad1a7ea2612753292d3552f6412..4c429f9b2a054e4d8b26e4a907c1f3c04ca730a1?pretty=fuller&n=1000 Suspecting: r433589 Note: Issue is reproducible on Mac and Linux OS.
,
Dec 1 2016
yep, figured this one out. fixing <select> not to eat Alt+left/right was not the problem :)
,
Dec 1 2016
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9e7a101651feb98b6b05d3216c785cfb5175719 commit f9e7a101651feb98b6b05d3216c785cfb5175719 Author: dbeam <dbeam@chromium.org> Date: Thu Dec 01 17:48:09 2016 MD Settings: fix /importData dialog's back/forward navigation "Just ignore popstate events. I got this." - route.js R=tommycli@chromium.org BUG= 668004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2538393002 Cr-Commit-Position: refs/heads/master@{#435644} [modify] https://crrev.com/f9e7a101651feb98b6b05d3216c785cfb5175719/chrome/browser/resources/settings/people_page/import_data_dialog.html
,
Dec 1 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msrchandra@chromium.org
, Nov 23 2016Status: Untriaged (was: Unconfirmed)