A very common situation when sheriffing is:
1. See an issue in the SOM queue.
2. Perform a speculative fix (revert or disable test).
3. Wait -- potentially hours -- before the bots run a revision after your fix, to see if it fixes the issue.
I might be on Step 3 for three, four, five or more issues all at the same time, and while I'm waiting, those issues piling up in SOM are very stressful because I have to keep looking at them.
I could snooze them for a specified amount of time (like an hour), but they often come back still failing, and it turns out my CL hasn't run yet!
Eventually, there are two possible outcomes:
- It fails, because my fix didn't work. This failure is indistinguishable in SOM from my CL hasn't run yet, so I have to keep checking back to see whether it's still failing because my CL hasn't run, or if it failed after my CL.
- It passes, because my fix worked. In this case, it disappears from the SOM queue altogether, and I often don't even notice. I'd like if it shows some kind of positive notice (e.g., it appears with a green background until dismissed) for a) the psychological benefit* of seeing my fix working, and b) so I know it's passed and I can go mark bugs as Fixed, hand them off to the CL authors, etc.
Either way, I want those issues to get out of my face until my speculative fix has completed, and then I want to be notified (regardless of whether it passed or failed). From a technical standpoint, this would be an alternative snooze (from the time snooze) where I paste a Cr-Commit-Position or hash, and the issue comes back up if any bot has a matching failure from a build including this commit, or if bots that were previously failing have a pass from a build including this commit.
*It seems silly but I think this psychology benefit would actually be a big boost to my sanity when I spend all day looking at failures.
Comment 1 by seanmccullough@chromium.org
, Nov 23 2016