New issue
Advanced search Search tips

Issue 667990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add tail view to LUCI LogDog

Project Member Reported by alancutter@chromium.org, Nov 23 2016

Issue description

Often when looking at webkit_tests failures I want to look at the end of the output for the list of failures.

Example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_rel_ng%2F337323%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests__with_patch_%2F0%2Fstdout

The output can be prohibitively long to download/scroll through, especially on a mobile device where there's no "end" key. Being able to request the last n characters of the output would be very useful.
 

Comment 1 by d...@chromium.org, Nov 23 2016

This is a good idea, and definitely something that would be useful.

Comment 2 by d...@chromium.org, Dec 5 2016

So I actually went ahead and ran with this idea. I have a new viewer app up now that offers a "tail" icon during loading. Please give this a try and let me know if it's useful to you.
Excellent! I'm very happy to see this functionality available. Unfortunately it doesn't seem to work on mobile (where the capability would be most useful).
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281

commit 2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281
Author: dnj <dnj@chromium.org>
Date: Sat Dec 10 00:24:55 2016

Rewrite LogDog log viewer app.

Rewrite the LogDog log viewer app in TypeScript, and integrate it into
the Gulp viewer. This adds many features, including:
- Actual TypeScript 2.0 versions of the LogDog libraries.
- The ability to perform log tails and manual (on-demand) log loading.
- Much faster log rendering (by default).
- Prefetch initial log chunk so it feels more responsive.
- Better model/view/controller separation.
- Transient HTTP and RPC retries.
- A tighter authentication loop, hopefully better now.
- Better support for mobile apps.

The current state of things is hybrid JavaScript / Polymer / TypeScript
because too much change in one CL is bad. The minimum bridges were built
between the JavaScript libraries that weren't rewritten and the
TypeScript code that uses them.

The TypeScript code is smaller, cleaner, and (obivously) stronger typed.
This should lead to its significantly-increased enhancement and
maintainability.

Polymer integrates TypeScript by including it during vulcanization. This
requires the Gulp build system to include an intermediate "build"
directory step, where the original sources are copied over and the
transpiled JavaScript code is generated.

BUG= chromium:667990 
TEST=local
  - Ran the app locally, seems to work under all expected circumstances.

Review-Url: https://codereview.chromium.org/2543323004

[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/gulp-common.js
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/elements/elements.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/elements/logdog-app/logdog-app.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/elements/logdog-app/logdog-scripts-main.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/elements/routing.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/index.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/scripts-ts/main.ts
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-app/scripts-ts/tsconfig.json
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/elements/elements.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/elements/logdog-view/logdog-scripts-main.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/elements/logdog-view/logdog-view.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/gulpfile.js
[delete] https://crrev.com/ad2e521dd75ba10725fe15a4943aa9deada2106b/web/apps/logdog-view/inc
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/index.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/scripts-ts/main.ts
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/apps/logdog-view/scripts-ts/tsconfig.json
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/bower.json
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/README.md
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-app-base/logdog-app-base.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream-view/fetcher.ts
[delete] https://crrev.com/ad2e521dd75ba10725fe15a4943aa9deada2106b/web/inc/logdog-stream-view/logdog-stream-fetcher.html
[delete] https://crrev.com/ad2e521dd75ba10725fe15a4943aa9deada2106b/web/inc/logdog-stream-view/logdog-stream-query.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream-view/logdog-stream-view.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream-view/query.ts
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream-view/viewer.ts
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream/logdog-error.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/logdog-stream/logdog.ts
[delete] https://crrev.com/ad2e521dd75ba10725fe15a4943aa9deada2106b/web/inc/luci-sleep-promise/luci-sleep-promise.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/luci-sleep-promise/promise.ts
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/rpc/client.ts
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/rpc/rpc-call.html
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/rpc/rpc-error.html
[add] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/inc/tsconfig.json
[modify] https://crrev.com/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281/web/package.json

Comment 5 by d...@chromium.org, Dec 10 2016

Can you elaborate on the mobile problem?

Comment 6 by estaab@chromium.org, Dec 13 2016

Cc: alancutter@chromium.org
Alan, can you tell us what happened when you tried it on mobile? I just tested with mobile view in chrome dev tools and it mostly worked (besides being pretty heavyweight).

Comment 7 by estaab@chromium.org, Dec 13 2016

Status: Available (was: Untriaged)
Screencast: https://youtu.be/RCjnb2UUULk

Comment 9 by d...@chromium.org, Dec 13 2016

Thanks for the video. It looks like mobile has a handful of problems here.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8

commit 4588c02fe11509e38d8192ee6d18c45bbc2d1ee8
Author: dnj <dnj@chromium.org>
Date: Tue Dec 13 23:42:03 2016

Revert of Rewrite LogDog log viewer app. (patchset #3 id:60001 of https://codereview.chromium.org/2543323004/ )

Reason for revert:
TypeScript is not ready yet.

Original issue's description:
> Rewrite LogDog log viewer app.
>
> Rewrite the LogDog log viewer app in TypeScript, and integrate it into
> the Gulp viewer. This adds many features, including:
> - Actual TypeScript 2.0 versions of the LogDog libraries.
> - The ability to perform log tails and manual (on-demand) log loading.
> - Much faster log rendering (by default).
> - Prefetch initial log chunk so it feels more responsive.
> - Better model/view/controller separation.
> - Transient HTTP and RPC retries.
> - A tighter authentication loop, hopefully better now.
> - Better support for mobile apps.
>
> The current state of things is hybrid JavaScript / Polymer / TypeScript
> because too much change in one CL is bad. The minimum bridges were built
> between the JavaScript libraries that weren't rewritten and the
> TypeScript code that uses them.
>
> The TypeScript code is smaller, cleaner, and (obivously) stronger typed.
> This should lead to its significantly-increased enhancement and
> maintainability.
>
> Polymer integrates TypeScript by including it during vulcanization. This
> requires the Gulp build system to include an intermediate "build"
> directory step, where the original sources are copied over and the
> transpiled JavaScript code is generated.
>
> BUG= chromium:667990 
> TEST=local
>   - Ran the app locally, seems to work under all expected circumstances.
>
> Review-Url: https://codereview.chromium.org/2543323004
> Committed: https://github.com/luci/luci-go/commit/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281

TBR=estaab@chromium.org,hinoka@chromium.org,hinoka@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= chromium:667990 

Review-Url: https://codereview.chromium.org/2570963003

[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/gulp-common.js
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-app/elements/elements.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-app/elements/logdog-app/logdog-app.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-app/elements/logdog-app/logdog-scripts-main.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-app/elements/routing.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-app/index.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-app/scripts-ts/main.ts
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-app/scripts-ts/tsconfig.json
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-view/elements/elements.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-view/elements/logdog-view/logdog-scripts-main.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-view/elements/logdog-view/logdog-view.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-view/gulpfile.js
[add] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-view/inc
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/apps/logdog-view/index.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-view/scripts-ts/main.ts
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/apps/logdog-view/scripts-ts/tsconfig.json
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/bower.json
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/README.md
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/logdog-app-base/logdog-app-base.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/logdog-stream-view/fetcher.ts
[add] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/logdog-stream-view/logdog-stream-fetcher.html
[add] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/logdog-stream-view/logdog-stream-query.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/logdog-stream-view/logdog-stream-view.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/logdog-stream-view/query.ts
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/logdog-stream-view/viewer.ts
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/logdog-stream/logdog-error.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/logdog-stream/logdog.ts
[add] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/luci-sleep-promise/luci-sleep-promise.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/luci-sleep-promise/promise.ts
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/rpc/client.ts
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/rpc/rpc-call.html
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/inc/rpc/rpc-error.html
[delete] https://crrev.com/df2d983dc49537f5ca6f8f33878930ca7a67cd5c/web/inc/tsconfig.json
[modify] https://crrev.com/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8/web/package.json

Project Member

Comment 11 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by d...@chromium.org, Feb 16 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment