New issue
Advanced search Search tips

Issue 667982 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Automated Tests Request]: https://codereview.chromium.org/2486033002

Project Member Reported by manoranj...@chromium.org, Nov 23 2016

Issue description

tbansal@, could you please help us to create an automated test for this change: https://codereview.chromium.org/2486033002 ?

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=663456

Thank you!
 

Comment 1 by mmenke@chromium.org, Nov 23 2016

That CL added a test, didn't it?
Not very sure and i am not seeing any "test= field" in the above commit.

tbansal@, could you please confirm?

Thank you!

Comment 3 by mmenke@chromium.org, Nov 23 2016

Most Chrome developers don't include a test= field in commits, as it was determined they were being used for multiple different things, and therefore were useless.  What do you want confirmed?
oh i see. Do we have any best way to see the respective commit is associated with the automated tests?

Thank you!
Labels: -Restrict-View-Google
Mergedinto: 663456
Status: Duplicate (was: Assigned)
Yes, the test was in that CL. I do not know of a standard way to see if the commit is associated with a test. The expectation from the developers is to include a regression test in the same CL that fixes the bug.

Sign in to add a comment