New issue
Advanced search Search tips

Issue 667977 link

Starred by 1 user
Status: Fixed
Owner:
skau@chromium.org
Closed: Dec 2016
Cc:
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Fix crash upon opening print preview with invalid printer.

Project Member Reported by manoranj...@chromium.org, Nov 23 2016 
npm@, could you please help us to create an automated test for this change: https://codereview.chromium.org/2487323002 ?

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=663679

Thank you!

Comment 1 by manoranj...@chromium.org, Nov 29 2016

Summary: [Missing Tests]: Fix crash upon opening print preview with invalid printer. (was: [Automated Tests Request]: https://codereview.chromium.org/2487323002)

Comment 2 by skau@chromium.org, Dec 7 2016

Status: Started (was: Assigned)

Comment 3 by skau@chromium.org, Dec 23 2016

Status: Fixed (was: Started)
Committed as https://crrev.com/a1e0b7a6d974932bbc1d8649d9cd3ddcbd4a3e67
Project Member

Comment 4 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Dec 23 2016

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.

Comment 5 by ligim...@chromium.org, Jan 3 2017 

Your bug is labelled as Stable Release Block, looks like a merge required here. If yes, please request a merge to M56 ASAP.

Comment 6 by skau@chromium.org, Jan 3 2017

Labels: -Merge-TBD
The CL just adds unit tests and is not critical for browser functionality.  I've removed the Merge-TBD label.
►

Sign in to add a comment