New issue
Advanced search Search tips

Issue 667964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Enable VR Shell unittests on main waterfall

Project Member Reported by bsheedy@chromium.org, Nov 23 2016

Issue description

The VR Shell unittests have been stable on the FYI bot for quite some time, so let's enable them on the main waterfall to catch any breakages.
 
Labels: -Type-Bug Type-Feature
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5750756522296b2a9a08009d8d2cc90db3b88f56

commit 5750756522296b2a9a08009d8d2cc90db3b88f56
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Nov 29 02:48:24 2016

Enabled VR Shell unittests on main waterfall

Changes the VR Shell unittests to compile when WebVR is enabled and enables
them on chromium.android builders.

BUG= 667964 

Review-Url: https://codereview.chromium.org/2521883003
Cr-Commit-Position: refs/heads/master@{#434843}

[modify] https://crrev.com/5750756522296b2a9a08009d8d2cc90db3b88f56/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/5750756522296b2a9a08009d8d2cc90db3b88f56/testing/buildbot/chromium.android.json

Status: Fixed (was: Started)
We are shipping a version of VR Shell/WebVR, and should enable our tests to ensure something doesn't break with a late merge.

Note that this depends on 666811 and 667900.
Note that this did not track addition to the main CQ and tryservers. That is tracked by  issue 670147 .

Sign in to add a comment