dragend event is sent to the render widget with wrong coordinates |
|||||||||
Issue descriptionRepro steps: 1. Drag-and-drop while listening to dragend DOM event 2. Note the clientX and clientY coordinates of the dragend DOM event The issue is that rather than passing (x,y) we pass (x,x) in one place in the code: https://chromium.googlesource.com/chromium/src/+/77fd2aecaa7e1db995e158fb095a72be385e333c/content/browser/web_contents/web_contents_view_aura.cc#565 : web_contents_->DragSourceEndedAt(client_loc.x(), client_loc.***x***(), screen_loc.x(), screen_loc.y(), ops, drag_start_rwh_.get());
,
Nov 23 2016
Fix is already in the CQ: https://codereview.chromium.org/2530663002/
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c098de407049a62aebef939cb7ce93200a5139 commit 94c098de407049a62aebef939cb7ce93200a5139 Author: paulmeyer <paulmeyer@chromium.org> Date: Thu Nov 24 00:20:26 2016 Fix for DragEnd event being sent with the wrong coordinates. This event was accidentally sent with (x, x) instead of (x, y). This patch corrects this. BUG= 667963 Review-Url: https://codereview.chromium.org/2530663002 Cr-Commit-Position: refs/heads/master@{#434295} [modify] https://crrev.com/94c098de407049a62aebef939cb7ce93200a5139/content/browser/web_contents/web_contents_view_aura.cc
,
Nov 24 2016
Thanks Paul! Can you verify this on tomorrow's canary and request a merge?
,
Nov 24 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 24 2016
,
Nov 24 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
Paul's OOO, so I'll try to merge this.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6de5ba0b21b7c8021a561e748fd113218d53cea commit a6de5ba0b21b7c8021a561e748fd113218d53cea Author: Charles Reis <creis@chromium.org> Date: Mon Nov 28 20:49:48 2016 Fix for DragEnd event being sent with the wrong coordinates. This event was accidentally sent with (x, x) instead of (x, y). This patch corrects this. BUG= 667963 TBR=paulmeyer, lukasza, nick Review-Url: https://codereview.chromium.org/2530663002 Cr-Commit-Position: refs/heads/master@{#434295} (cherry picked from commit 94c098de407049a62aebef939cb7ce93200a5139) Review URL: https://codereview.chromium.org/2533953002 . Cr-Commit-Position: refs/branch-heads/2924@{#126} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/a6de5ba0b21b7c8021a561e748fd113218d53cea/content/browser/web_contents/web_contents_view_aura.cc
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ligim...@chromium.org
, Nov 23 2016