New issue
Advanced search Search tips

Issue 667961 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
style-dev-current


Sign in to add a comment

[meta] Move CSSValue* into blink::cssvalue:: namespace.

Project Member Reported by slangley@chromium.org, Nov 23 2016 
The implementation of CSS OM has been hindered by name collisions in the blink namespace between values that derive from CSSValue and values that are associated with CSS OM types. In extreme circumstances ambiguous type names have had to be used to avoid a collision (e.g. CSSKeywordValue).

The intention is to introduce the nested namespaces blink::cssvalue:: and blink::cssom:: to prevent collisions and correctly scope the types. Introducing the nested namespaces also makes it possible to simplify the class names (e.g. blink::CSSAngleValue can be blink::cssvalue::AngleValue or even blink::cssvalue::Angle).

The blink IDL generator does not support nested namespaces so some changes will be required, however the scope is small.

Design doc: https://docs.google.com/document/d/1gmWnBA7fUCx49MZkpdZeyauzPfqMk4aQSmGilATt5WY/edit?usp=sharing

Comment 1 by ericwilligers@chromium.org, Feb 13 2017

Labels: Update-Monthly

Comment 2 by suzyh@chromium.org, Mar 27 2017

Labels: Objective
slangley: Is this actively being worked on?

Comment 3 by slangley@chromium.org, Mar 27 2017 

Not super active but i'd still like to fix it - is it urgent?

Comment 4 by suzyh@chromium.org, Mar 27 2017 

No, not urgent, just checking suitability of ownership and labelling. Please give an update on this bug monthly (if it's in active progress) or change Update-Monthly to Update-Quarterly so we know not to expect regular updates. Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80cc48147b27aa364144e4b6d49524fb111274a9

commit 80cc48147b27aa364144e4b6d49524fb111274a9
Author: slangley <slangley@chromium.org>
Date: Wed Apr 05 08:44:43 2017

Introduce the nested namespace ::blink::cssvalue, start with CSSColorValue.

This patch is the first in a series that will move all of the classes in the range CSS.*Value from the ::blink namespace to the ::blink::cssvalue namespace. It will be followed by work to introduce the ::blink::cssom namespace.

The original design doc for this work is linked in the attached bug. Note that this patch does not rename the class or move the file to a new subdirectory. The immediate goal is to prevent name collisions cssvalue and cssom types - there is no need to re-organize or rename the files to achieve this basic goal.

BUG=667961

Review-Url: https://codereview.chromium.org/2796183002
Cr-Commit-Position: refs/heads/master@{#462010}

[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/CSSColorValue.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/CSSColorValue.h
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/CSSValue.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/CSSValuePool.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/CSSValuePool.h
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/dom/TextLinkColors.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/html/HTMLFontElement.cpp
[modify] https://crrev.com/80cc48147b27aa364144e4b6d49524fb111274a9/third_party/WebKit/Source/core/html/HTMLHRElement.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d188dd210489eb0a70bd66af0a1cf1400331399

commit 4d188dd210489eb0a70bd66af0a1cf1400331399
Author: slangley <slangley@chromium.org>
Date: Fri Apr 07 01:41:34 2017

Move CSSCounterValue &  CSSCursorImageValue to the namespace blink::cssvalue.

This is a continuation of other work to move CSS.*Value types to the nested
namespace blink::cssvalue to avoid name collisions. I will be moving over type
2 or 3 at a time per CL. In some cases we need to temporarily introduce using
statements while we're shuffling the classes around. These will be cleaned up
once all types have been moved to blink::cssvalue.

BUG=667961

Review-Url: https://codereview.chromium.org/2804673003
Cr-Commit-Position: refs/heads/master@{#462740}

[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/CSSCounterValue.cpp
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/CSSCounterValue.h
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/CSSCursorImageValue.cpp
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/CSSCursorImageValue.h
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp
[modify] https://crrev.com/4d188dd210489eb0a70bd66af0a1cf1400331399/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4

commit ed6ee5290f1d2af95c565c9c0156a6ef449d27c4
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 03 05:57:57 2017

Put CSSPathValue into the blink::cssvalue:: nested namespace.

Update all call sites to use the nested namespace. In general, favour using
the right scope rather than a using statement to pull in the entire
namespace.

Bug: 667961
Change-Id: If18aa7a1aa61aed4a96cd4a803c3ce17b446b2a0
Reviewed-on: https://chromium-review.googlesource.com/558307
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Suzy Howlett <suzyh@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483951}
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/animation/SVGPathInterpolationType.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/css/CSSPathValue.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/css/CSSPathValue.h
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/style/StylePath.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/svg/SVGAnimatedPath.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/svg/SVGPath.cpp
[modify] https://crrev.com/ed6ee5290f1d2af95c565c9c0156a6ef449d27c4/third_party/WebKit/Source/core/svg/SVGPath.h
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94e0073e5dfa965074528f10e8bf7e960544be0

commit b94e0073e5dfa965074528f10e8bf7e960544be0
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Aug 02 03:12:20 2017

Put CSS*GradientValue types inside of the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive from
CSSValue into blink::cssvalue:: namespace.

Bug: 667961
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ida38ef3b65ff8977c286e4bcd71fa9e416fe1ff2
Reviewed-on: https://chromium-review.googlesource.com/595369
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491243}
[modify] https://crrev.com/b94e0073e5dfa965074528f10e8bf7e960544be0/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/b94e0073e5dfa965074528f10e8bf7e960544be0/third_party/WebKit/Source/core/css/CSSGradientValue.h
[modify] https://crrev.com/b94e0073e5dfa965074528f10e8bf7e960544be0/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/b94e0073e5dfa965074528f10e8bf7e960544be0/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/b94e0073e5dfa965074528f10e8bf7e960544be0/third_party/WebKit/Source/core/paint/NinePieceImageGridTest.cpp

Comment 10 by slangley@chromium.org, Nov 1 2017

Owner: lucmult@chromium.org

Comment 11 by lucmult@chromium.org, Nov 13 2017

Status: Started (was: Assigned)
I'm starting with a small CL for CSSBorderImageSliceValue.
https://chromium-review.googlesource.com/c/chromium/src/+/765621
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc

commit 0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Nov 17 05:19:56 2017

Wrap CSSBorderImageSliceValue on blink::cssvalue:: namespace

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961
Change-Id: I5d90a018fa7e23cacf2bf9c9f7001f8ce1304ba1
Reviewed-on: https://chromium-review.googlesource.com/765621
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517315}
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/css/CSSBorderImageSliceValue.cpp
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/css/CSSBorderImageSliceValue.h
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp
[modify] https://crrev.com/0251ee2d9b155bfe1c9a3948e3739a6c9b4121bc/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

Comment 13 by nainar@chromium.org, Dec 6 2017

Labels: -Update-Monthly
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc90cf0751bb70daa953df04fc06f108fe4ada5

commit bbc90cf0751bb70daa953df04fc06f108fe4ada5
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Dec 14 01:30:32 2017

Move CSSFontFeatureValue into the blink::cssvalue namespace

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961
Change-Id: I6ea5a93ba53d08f6c006874eebd82d93a3fb5758
Reviewed-on: https://chromium-review.googlesource.com/816476
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523972}
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/CSSFontFeatureValue.cpp
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/CSSFontFeatureValue.h
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/CSSValue.cpp
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.h
[modify] https://crrev.com/bbc90cf0751bb70daa953df04fc06f108fe4ada5/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Comment 15 by slangley@chromium.org, Jan 9 2018

Owner: ----
Status: Available (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4beaeb270d199269f9e2947308a655ff0ab62c60

commit 4beaeb270d199269f9e2947308a655ff0ab62c60
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Tue Jan 30 10:58:21 2018

Put CSSLayoutFunctionValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I3dd4453a51f04490b25d9f2540a9f0df5bd116ca
Reviewed-on: https://chromium-review.googlesource.com/892542
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532832}
[modify] https://crrev.com/4beaeb270d199269f9e2947308a655ff0ab62c60/third_party/WebKit/Source/core/css/CSSLayoutFunctionValue.cpp
[modify] https://crrev.com/4beaeb270d199269f9e2947308a655ff0ab62c60/third_party/WebKit/Source/core/css/CSSLayoutFunctionValue.h
[modify] https://crrev.com/4beaeb270d199269f9e2947308a655ff0ab62c60/third_party/WebKit/Source/core/css/properties/longhands/DisplayCustom.cpp
[modify] https://crrev.com/4beaeb270d199269f9e2947308a655ff0ab62c60/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd

commit f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Tue Jan 30 11:00:32 2018

Put CSS*TimingFunctionValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ifaaa877a2395e1eb876624b2f351d6ace325b913
Reviewed-on: https://chromium-review.googlesource.com/892547
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532833}
[modify] https://crrev.com/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd/third_party/WebKit/Source/core/css/CSSTimingFunctionValue.cpp
[modify] https://crrev.com/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd/third_party/WebKit/Source/core/css/CSSTimingFunctionValue.h
[modify] https://crrev.com/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp
[modify] https://crrev.com/f9517ac92ca832a2c0fd4de8c77f0d564c47c5fd/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b4607ae1ea1e824568fbc4f0450ac238480c12d

commit 0b4607ae1ea1e824568fbc4f0450ac238480c12d
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Jan 31 07:03:22 2018

Put CSSBasicShape*Value into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Iefb3980ce006b1f69c326c639134fe2b7bf6426e
Reviewed-on: https://chromium-review.googlesource.com/895023
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533220}
[modify] https://crrev.com/0b4607ae1ea1e824568fbc4f0450ac238480c12d/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
[modify] https://crrev.com/0b4607ae1ea1e824568fbc4f0450ac238480c12d/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
[modify] https://crrev.com/0b4607ae1ea1e824568fbc4f0450ac238480c12d/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp
[modify] https://crrev.com/0b4607ae1ea1e824568fbc4f0450ac238480c12d/third_party/WebKit/Source/core/css/CSSBasicShapeValues.h
[modify] https://crrev.com/0b4607ae1ea1e824568fbc4f0450ac238480c12d/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e07efab830589a48f2980fb31c39220b24fa9e5

commit 5e07efab830589a48f2980fb31c39220b24fa9e5
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Tue Feb 06 05:03:51 2018

Put CSSFontVariationValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I8ad99a68098458d7bc4e34a3c06a461c3dcdd68b
Reviewed-on: https://chromium-review.googlesource.com/903204
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534632}
[modify] https://crrev.com/5e07efab830589a48f2980fb31c39220b24fa9e5/third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.cpp
[modify] https://crrev.com/5e07efab830589a48f2980fb31c39220b24fa9e5/third_party/WebKit/Source/core/css/CSSFontVariationValue.cpp
[modify] https://crrev.com/5e07efab830589a48f2980fb31c39220b24fa9e5/third_party/WebKit/Source/core/css/CSSFontVariationValue.h
[modify] https://crrev.com/5e07efab830589a48f2980fb31c39220b24fa9e5/third_party/WebKit/Source/core/css/properties/longhands/FontVariationSettingsCustom.cpp
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1285f6b1e65accbfb5ddebd8aa402d7eaca89226

commit 1285f6b1e65accbfb5ddebd8aa402d7eaca89226
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Mon Feb 12 03:16:25 2018

Put CSSReflectValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I755e7f48ea7f7f558e9ed6cc386af8e87b20ec66
Reviewed-on: https://chromium-review.googlesource.com/910473
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536025}
[modify] https://crrev.com/1285f6b1e65accbfb5ddebd8aa402d7eaca89226/third_party/WebKit/Source/core/css/CSSReflectValue.cpp
[modify] https://crrev.com/1285f6b1e65accbfb5ddebd8aa402d7eaca89226/third_party/WebKit/Source/core/css/CSSReflectValue.h
[modify] https://crrev.com/1285f6b1e65accbfb5ddebd8aa402d7eaca89226/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp
[modify] https://crrev.com/1285f6b1e65accbfb5ddebd8aa402d7eaca89226/third_party/WebKit/Source/core/css/properties/longhands/WebkitBoxReflectCustom.cpp
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1f5e9674ded3bb7455242ddcac01dcad95dfb48

commit e1f5e9674ded3bb7455242ddcac01dcad95dfb48
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Feb 14 00:45:44 2018

Put CSSRayValue and CSSContentDistributionValue into blink::cssvalue.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Iee0f3b2e2db9e67084828f83edffa8489132c43a
Reviewed-on: https://chromium-review.googlesource.com/915381
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536577}
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/animation/CSSRayInterpolationType.cpp
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/css/CSSContentDistributionValue.h
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/css/CSSRayValue.cpp
[modify] https://crrev.com/e1f5e9674ded3bb7455242ddcac01dcad95dfb48/third_party/WebKit/Source/core/css/CSSRayValue.h
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f

commit f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Feb 28 02:44:16 2018

Put CSSUnsetValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Idbe048f2563c9e47fe5db56fe3e4b27b1a376a4b
Reviewed-on: https://chromium-review.googlesource.com/938884
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539672}
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/CSSUnsetValue.cpp
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/CSSUnsetValue.h
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/CSSValuePool.h
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/f72cddeb8b18ffaf85a40d2bf4d4e759963a5b0f/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b4014d9b801d0a25ae721a7aeb5593016f56854

commit 1b4014d9b801d0a25ae721a7aeb5593016f56854
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Mar 15 10:43:26 2018

Put CSSFontStyleRangeValue into the blink::cssvalue namespace.

This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.

Bug: 667961

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ia34819a0518e339ed2d310361452355207346801
Reviewed-on: https://chromium-review.googlesource.com/956165
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543339}
[modify] https://crrev.com/1b4014d9b801d0a25ae721a7aeb5593016f56854/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.cpp
[modify] https://crrev.com/1b4014d9b801d0a25ae721a7aeb5593016f56854/third_party/WebKit/Source/core/css/CSSFontStyleRangeValue.h
[modify] https://crrev.com/1b4014d9b801d0a25ae721a7aeb5593016f56854/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/1b4014d9b801d0a25ae721a7aeb5593016f56854/third_party/WebKit/Source/core/css/FontFaceCacheTest.cpp

Comment 24 by e...@chromium.org, Dec 13

Labels: -Type-Feature Type-Task
Summary: [meta] Move CSSValue* into blink::cssvalue:: namespace. (was: Introduce nested namespaces for blink::cssvalue and blink::cssom)
►

Sign in to add a comment