MD Settings: Page does not scroll to section when using nav menu after searching |
|||
Issue description1. chrome://md-settings 2. search for "setting" 3. open nav menu, choose "On startup" Expected: page scrolls to "On startup" after all sections show Actual: page does not scroll after all sections show Cause: The section is "scrolled into view" before it is actually shown. This issue existed in M55 as well. 0. make the window quite tall, or scroll out 1. chrome://md-settings 2. search for "setting" 3. open nav menu, choose "Appearance" Expected: page scrolls to "Appearance" after all sections show Actual: page scrolls to "Appearance" after all sections show but immediately scrolls back up to the top. Cause: Unclear, because "Appearance" is already shown. Probably something with overscroll. This one doesn't seem to repro in 55.0.2883.54, so maybe a regression. Not the same root cause as issue 662004 , so not fixed by the CL to combine Basic and Advanced. dpapad: do you know whether this used to work?
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73b5f1096d7fb361d7e6797ede8100de39279749 commit 73b5f1096d7fb361d7e6797ede8100de39279749 Author: tommycli <tommycli@chromium.org> Date: Thu Dec 08 03:28:26 2016 MD Settings: Scroll correctly for navigations that exit search mode. Previously, exiting search mode by clicking on a section link did not work. This was because we tried to scroll to the section before the search mode exited. This CL adds another attempt to scroll AFTER search mode exits. BUG= 667958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2552393002 Cr-Commit-Position: refs/heads/master@{#437165} [modify] https://crrev.com/73b5f1096d7fb361d7e6797ede8100de39279749/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/73b5f1096d7fb361d7e6797ede8100de39279749/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/73b5f1096d7fb361d7e6797ede8100de39279749/chrome/test/data/webui/settings/basic_page_browsertest.js
,
Dec 15 2016
,
Apr 3 2017
9426.0.0 / 59.0.3055.0
,
Apr 3 2017
Verified on ChromeOS |
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Dec 6 2016Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)