Add a presubmit check on CQ to prevent mapping from same component to different team |
|||||||||
Issue descriptionAfter we have a single source for the directory -> component and component -> team mappings, we also need a presubmit check to prevent duplicate mappings which would be confusing. Two cases here: 1. A component maps to only one team. 2. A directory maps to only one pair of component + team.
,
Nov 23 2016
,
Nov 23 2016
,
Nov 23 2016
As discussed, we could start the second case right away (a directory maps to only one pair of component + team). We could follow most of the current checkperms setup. We could start with the presubmit check, while postsubmit check is lower priority and is needed ideally, because some CL might bypass CQ. Presubmit on CQ: https://cs.chromium.org/chromium/src/tools/checkperms/checkperms.py https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=759&q=CheckFilePermissions Example execution on CQ: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/311547/steps/presubmit/logs/stdio Postsubmit check on Waterfall: https://cs.chromium.org/chromium/src/testing/scripts/checkperms.py https://cs.chromium.org/chromium/src/testing/buildbot/chromium.linux.json?q=checkperms&l=3475 Example execution on Waterfall: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/49280/steps/checkperms/logs/stdio
,
Dec 19 2016
,
Dec 20 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/832f59964c871959a85b6b64fb2ae81dc5e6441d commit 832f59964c871959a85b6b64fb2ae81dc5e6441d Author: robertocn <robertocn@chromium.org> Date: Wed Jan 04 19:01:30 2017 Adding check for team and component tags in owners files. As a part of presubmit, if an OWNERS file is modified or added the following checks will be performed: - Ensure that at most one line starts with `# COMPONENT: ` exists in the file. - Ensure that at most one line starts with `# TEAM: ` exists in the file, and that it contains exactly one email address. R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org BUG= 667954 Review-Url: https://codereview.chromium.org/2601773004 Cr-Commit-Position: refs/heads/master@{#441420} [modify] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/PRESUBMIT.py [add] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/tools/checkteamtags/OWNERS [add] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/tools/checkteamtags/PRESUBMIT.py [add] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/tools/checkteamtags/checkteamtags.py [add] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/tools/checkteamtags/checkteamtags_test.py [add] https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d/tools/checkteamtags/run_tests
,
Jan 10 2017
,
Jan 13 2017
,
Jan 30 2017
Roberto, is there anything left here or can we close and reopen if something else comes up that needs to be added to the presubmit?
,
Mar 17 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sshru...@google.com
, Nov 23 2016Cc: sshruthi@chromium.org