New issue
Advanced search Search tips

Issue 667953 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: ----
Type: ----



Sign in to add a comment

virtual/android/media/mediadocument/media-document-with-download-button.html flaky

Project Member Reported by piman@chromium.org, Nov 22 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Type: build-failure

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29


It looks like the test is fundamentally flaky where the image depends on load timing (progress cursor).
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14346f829f16c989f59e726b5bc88316cd1ccdab

commit 14346f829f16c989f59e726b5bc88316cd1ccdab
Author: piman <piman@chromium.org>
Date: Wed Nov 23 01:20:04 2016

Mark more tests flaky

idle-callback.html was also seen to fail on Linux Debug
media-document-with-download-button.htm was seen to flake on Linux Debug - test
looks fundamentally racy though

BUG= 667875 , 667953 
TBR=caseq,qinmin
NOTRY=true

Review-Url: https://codereview.chromium.org/2523883002
Cr-Commit-Position: refs/heads/master@{#434067}

[modify] https://crrev.com/14346f829f16c989f59e726b5bc88316cd1ccdab/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by magjed@chromium.org, Nov 28 2016

Labels: -Sheriff-Chromium
Components: Tests>Flaky
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc595432d97064286db8e2bdda3d8eb2119dbfc

commit fdc595432d97064286db8e2bdda3d8eb2119dbfc
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Dec 07 19:49:24 2016

Update TestExpectations by running Tools/Scripts/update-test-expectations.

This script removes lines for tests that appear to no longer flakily fail or timeout on the applicable platforms, according to recent results on the flakiness dashboard.

BUG=248938,446385, 513143 ,518987,522647, 532643 , 564403 , 569901 , 581468 , 605525 , 658311 , 658414 ,660308, 667953 , 671618 

Review-Url: https://codereview.chromium.org/2557593006
Cr-Commit-Position: refs/heads/master@{#437038}

[modify] https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc/third_party/WebKit/LayoutTests/TestExpectations

Cc: qin...@chromium.org
Owner: wangxianzhu@chromium.org
Summary: virtual/android/media/mediadocument/media-document-with-download-button.html flaky (was: virtual/android/media/mediadocument/media-document-with-download-button.html flaky on chromium.webkit/WebKit Linux Trusty (dbg))
It's flaky on all Linux bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fandroid%2Fmedia%2Fmediadocument%2Fmedia-document-with-download-button.html

It's now blocking CQ. Instead of marking it flaky again, I will create a quick patch to fix the flakiness which is caused by different position of the slider thumb because of different playing progress.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01fc4dd9113c80a0250bba1b6ac4d5d177298a3

commit e01fc4dd9113c80a0250bba1b6ac4d5d177298a3
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Dec 09 01:09:18 2016

Fix flakiness of virtual/android/media/mediadocument/media-document-with-download-button.html

The timer and slider may be different causing flakiness.
Mask out the timer and slider.

BUG= 667953 
NOTRY=true
TBR=qinmin@chromium.org

Review-Url: https://codereview.chromium.org/2555373005
Cr-Commit-Position: refs/heads/master@{#437397}

[modify] https://crrev.com/e01fc4dd9113c80a0250bba1b6ac4d5d177298a3/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/media-document-with-download-button-expected.html
[modify] https://crrev.com/e01fc4dd9113c80a0250bba1b6ac4d5d177298a3/third_party/WebKit/LayoutTests/virtual/android/media/mediadocument/media-document-with-download-button.html

Status: Fixed (was: Assigned)
Cc: wangxianzhu@chromium.org
 Issue 672696  has been merged into this issue.

Sign in to add a comment