New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667950 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 618368



Sign in to add a comment

abstract CVV and DialogSurface from AVDA

Project Member Reported by liber...@chromium.org, Nov 22 2016

Issue description

abstract surface creation / destruction from AVDA for CVV and DialogSurface.  we want AVDA to be able to support both implementations.

 
Salimantok117@gmail.com
Salimantok117@gmail.com
mini_mmssms.bk
72.0 KB Download
Salimantok
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c58e8f82526098f4ef3dca5f957a46c439540a59

commit c58e8f82526098f4ef3dca5f957a46c439540a59
Author: liberato <liberato@chromium.org>
Date: Fri Mar 10 19:45:48 2017

Add ContentVideoViewOverlay to AVDA.

Wrap usage of ContentVideoView in an AndroidOverlay interface.  This
doesn't change the functionality, but starts to move AVDA towards
using AndroidOverlays rather than hard-coding CVV.

Much of Allocate/DeallocateSurface could be moved from
AVDACodecAllocator to ContentVideoViewOverlay.  However, to keep the
size of this change small, it isn't yet.

There shouldn't be any functional difference with this CL.

BUG= 667950 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692863011
Cr-Commit-Position: refs/heads/master@{#456135}

[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/base/android/BUILD.gn
[add] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/base/android/android_overlay.cc
[add] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/base/android/android_overlay.h
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/BUILD.gn
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_codec_allocator.cc
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_codec_allocator.h
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_codec_allocator_unittest.cc
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_picture_buffer_manager.h
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_surface_bundle.cc
[modify] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/avda_surface_bundle.h
[add] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/content_video_view_overlay.cc
[add] https://crrev.com/c58e8f82526098f4ef3dca5f957a46c439540a59/media/gpu/content_video_view_overlay.h

Status: Fixed (was: Assigned)

Sign in to add a comment