New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667941 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocked on:
issue 668098



Sign in to add a comment

system_health.memory_desktop failure on chromium.perf on Win 10 High DPI and Zen Book

Project Member Reported by fmea...@chromium.org, Nov 22 2016

Issue description

Revision range first seen: Very old, no record
Link to failing step log: https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%283%29/builds/2957/steps/system_health.memory_desktop/logs/stdio

Stack trace:
Traceback (most recent call last):
  RunBenchmark at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:343
    benchmark.ShouldTearDownStateAfterEachStorySetRun())
  Run at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:229
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:87
    state.RunStory(results)
  traced_function at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:75
    return func(*args, **kwargs)
  RunStory at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\page\shared_page_state.py:299
    self._current_page.Run(self)
  Run at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\page\__init__.py:109
    self.RunPageInteractions(action_runner)
  RunPageInteractions at C:\b\c\b\Win_Zenbook_Perf__3_\src\tools\perf\page_sets\system_health\system_health_story.py:113
    self._Measure(action_runner)
  _Measure at C:\b\c\b\Win_Zenbook_Perf__3_\src\tools\perf\page_sets\system_health\system_health_story.py:96
    action_runner.MeasureMemory(deterministic_mode=True)
  traced_function at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:75
    return func(*args, **kwargs)
  MeasureMemory at C:\b\c\b\Win_Zenbook_Perf__3_\src\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py:158
    assert dump_id, 'Unable to obtain memory dump'
AssertionError: Unable to obtain memory dump

This issue seems to be affect 2 of the 3 win10 configurations, for simplicity disabling it for all win10 configurations for now.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e6a48f576f8130788f731c8d8e6c7525118edf

commit a3e6a48f576f8130788f731c8d8e6c7525118edf
Author: fmeawad <fmeawad@chromium.org>
Date: Wed Nov 23 08:18:12 2016

[Telemetry] Disable system_health.memory_desktop on win10

It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations.

BUG= 667941 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2520423005
Cr-Commit-Position: refs/heads/master@{#434132}

[modify] https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf/tools/perf/benchmarks/system_health.py

Cc: -primiano@chromium.org fmea...@chromium.org
Owner: primiano@chromium.org
Status: Assigned (was: Started)
Blockedon: 668098
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fa4049b9bf140f14ae31b2bd6bdac5b81df4ad

commit c1fa4049b9bf140f14ae31b2bd6bdac5b81df4ad
Author: nednguyen <nednguyen@google.com>
Date: Wed Nov 23 18:13:07 2016

Revert of [Telemetry] Disable system_health.memory_desktop on win10 (patchset #1 id:1 of https://codereview.chromium.org/2520423005/ )

Reason for revert:
System health benchmark should be disabled at story level, not the whole benchmark level (if possible).

Original issue's description:
> [Telemetry] Disable system_health.memory_desktop on win10
>
> It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations.
>
> BUG= 667941 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Committed: https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf
> Cr-Commit-Position: refs/heads/master@{#434132}

TBR=eakuefner@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 667941 

Review-Url: https://codereview.chromium.org/2522273002
Cr-Commit-Position: refs/heads/master@{#434200}

[modify] https://crrev.com/c1fa4049b9bf140f14ae31b2bd6bdac5b81df4ad/tools/perf/benchmarks/system_health.py

Cc: primiano@chromium.org picksi@chromium.org
Owner: kraynov@chromium.org
This should be fixed as per https://codereview.chromium.org/2528053002/

Kraynov can you re-enable the benchmarks disabled here and keep an eye?
Sure,
siggi@ change has been landed https://codereview.chromium.org/2552333002
So I can proceed now.
Owner: perezju@chromium.org
I guess it can be merged into https://crbug.com/665465
Could you take a look? Thanks!
Cc: kraynov@chromium.org
Mergedinto: 665465
Status: Duplicate (was: Assigned)

Sign in to add a comment