Re-enable UseCounterTest.InspectorDisablesMeasurement and UseCounterTest.SVGImageContext on Android |
||||||||||
Issue descriptionwebkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4) Type: build-failure Builders failed on: - WebKit Android (Nexus4): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29 The failure is consistent and stared with https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/57305 (note that because of crbug.com/667838 the list of CLs is wrong. Correct list https://chromium.googlesource.com/chromium/src/+log/65157fe7b75097e92a381363b6ef49291d538593..2c99fc2edeac87418e8b24939acc78a0ed628270?pretty=fuller ) Failure logs: I 107.609s run_tests_on_device(01cb7ce0cfe305ae) [----------] 2 tests from UseCounterTest I 107.609s run_tests_on_device(01cb7ce0cfe305ae) [ RUN ] UseCounterTest.SVGImageContext I 107.609s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:40: Failure I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.Features" does not exist. I 107.609s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:40: Failure I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.CSSProperties" does not exist. I 107.609s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.609s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.Features" does not exist. I 107.610s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:77: Failure I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Value of: 0 I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Expected: count I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Which is: 2 I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.Features" does not exist. I 107.610s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.CSSProperties" does not exist. I 107.610s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:77: Failure I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Value of: 0 I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Expected: count I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Which is: 2 I 107.610s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.SVGImage.CSSProperties" does not exist. I 107.610s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver" does not exist. I 107.611s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver" does not exist. I 107.611s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:77: Failure I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Value of: 0 I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Expected: count I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Which is: 2 I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver" does not exist. I 107.611s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.611s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver.CSSProperties" does not exist. I 107.611s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:57: Failure I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver.CSSProperties" does not exist. I 107.612s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:77: Failure I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Value of: 0 I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Expected: count I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Which is: 2 I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.FeatureObserver.CSSProperties" does not exist. I 107.612s run_tests_on_device(01cb7ce0cfe305ae) [ FAILED ] UseCounterTest.SVGImageContext (4 ms) I 107.612s run_tests_on_device(01cb7ce0cfe305ae) [ RUN ] UseCounterTest.InspectorDisablesMeasurement I 107.612s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:40: Failure I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.Features" does not exist. I 107.612s run_tests_on_device(01cb7ce0cfe305ae) ../../base/test/histogram_tester.cc:40: Failure I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL I 107.612s run_tests_on_device(01cb7ce0cfe305ae) Histogram "WebCore.UseCounter_TEST.CSSProperties" does not exist. I 107.612s run_tests_on_device(01cb7ce0cfe305ae) [ FAILED ] UseCounterTest.InspectorDisablesMeasurement (0 ms) I 107.612s run_tests_on_device(01cb7ce0cfe305ae) [----------] 2 tests from UseCounterTest (6 ms total) Only CL that standed out was https://chromium.googlesource.com/chromium/src/+/3c30ee3e18065db69c15c2f6abf8d912f573bb4f but revert didn't help.
,
Nov 22 2016
Also, I tried reproducing on my N5X but couldn't.
,
Nov 22 2016
->rbyers to triage. A bit out of options here as a sheriff, so I disabled the tests in https://codereview.chromium.org/2523083002/
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bd40f9f08505d8f857d84c40cfede672bc84ca6 commit 5bd40f9f08505d8f857d84c40cfede672bc84ca6 Author: piman <piman@chromium.org> Date: Tue Nov 22 22:59:20 2016 Disabling UseCounterTest.SVGImageContext and InspectorDisablesMeasurement on Android Consistently failing but no identified cause. BUG= 667913 NOTRY=true TBR=rbyers@chromium.org Review-Url: https://codereview.chromium.org/2523083002 Cr-Commit-Position: refs/heads/master@{#434013} [modify] https://crrev.com/5bd40f9f08505d8f857d84c40cfede672bc84ca6/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e34d1fee95c11fd7f43afa05d0ff0f6ae57885a commit 9e34d1fee95c11fd7f43afa05d0ff0f6ae57885a Author: piman <piman@chromium.org> Date: Wed Nov 23 01:52:55 2016 Correctly disable UseCounterTest.InspectorDisablesMeasurement BUG= 667913 NOTRY=true TBR=rbyers@chromium.org Review-Url: https://codereview.chromium.org/2528493003 Cr-Commit-Position: refs/heads/master@{#434078} [modify] https://crrev.com/9e34d1fee95c11fd7f43afa05d0ff0f6ae57885a/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
,
Nov 23 2016
WebKit Android (Nexus4) builder is green. Mark as Fixed.
,
Nov 23 2016
Re-opening to track getting the test re-enabled on Android. That's really weird that it would fail on the N4 bot but run locally. Thanks for the initial investigation. Maybe related to the 32/64bit histogram changes in https://chromium.googlesource.com/chromium/src/+/3c30ee3e18065db69c15c2f6abf8d912f573bb4f? Nexus 4 is a 32 bit device, but 5x is 64-bit, right? So perhaps histograms are busted on 32 bit Android devices somehow? bcwhite WDYT?
,
Nov 23 2016
@#7 I had tried reverting that particular change yesterday, but it didn't change anything. (I relanded).
,
Nov 28 2016
Removing sheriff-chromium, as this seems to be being worked on already
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8829f128045e6a01a2161a618573fc25410448fc commit 8829f128045e6a01a2161a618573fc25410448fc Author: battre <battre@chromium.org> Date: Tue Nov 29 11:28:06 2016 Disable UseCounterTest.RecordingFeatures on Android. Fails on Nexus 4 only with the following error: ../../base/test/histogram_tester.cc:40: Failure Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00> vs NULL Histogram "WebCore.UseCounter_TEST.Features" does not exist. BUG= 667913 TBR=rbyers@chromium.org Review-Url: https://codereview.chromium.org/2534833005 Cr-Commit-Position: refs/heads/master@{#434959} [modify] https://crrev.com/8829f128045e6a01a2161a618573fc25410448fc/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
,
Jan 3 2017
,
Apr 3 2017
,
Apr 27 2017
I am building / testing it locally. Hopefully I can find the root cause soon.
,
Apr 28 2017
I cannot reproduce it on Nexus 4 (lolipop). I suspect the bug is fixed?
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/285ad523ac8e142089580e9b2669926d6f9e46d8 commit 285ad523ac8e142089580e9b2669926d6f9e46d8 Author: lunalu <lunalu@chromium.org> Date: Fri Apr 28 19:42:27 2017 Re-enable UseCounterTests on Android Tests re-enabled are: UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures, UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments BUG= 667913 , 654502 Review-Url: https://codereview.chromium.org/2847173002 Cr-Commit-Position: refs/heads/master@{#468097} [modify] https://crrev.com/285ad523ac8e142089580e9b2669926d6f9e46d8/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
,
May 1 2017
,
Jul 18 2017
,
Jan 24 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by piman@chromium.org
, Nov 22 2016