Disable Cardboard WebVR on Daydream platforms for M56. |
||||||
Issue descriptionCurrently, the DON flow is broken when called from Chrome for users with their headset set to Cardboard. The root cause of this is ChromeTabbedActivity not being sniffable by VrCore, so it just assumes we only support full Daydream. b/33052570 tracks the issue of non-exported Activities, so when it's fixed we should re-enable the DON flow for cardboard, but for now we should disable it to prevent users getting stuck on the DON flow.
,
Nov 23 2016
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/108457cccefb7e044573a3d7b2cb56ce0c77c089 commit 108457cccefb7e044573a3d7b2cb56ce0c77c089 Author: bshe <bshe@chromium.org> Date: Wed Nov 30 21:29:44 2016 Disable WebVR presentation for Cardboard viewers. BUG= 667908 Review-Url: https://codereview.chromium.org/2524883002 Cr-Commit-Position: refs/heads/master@{#434023} (cherry picked from commit 197a42ece84e4dbb583290d53f28b5501dc43619) Review URL: https://codereview.chromium.org/2540103004 . Cr-Commit-Position: refs/branch-heads/2924@{#210} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/108457cccefb7e044573a3d7b2cb56ce0c77c089/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java [modify] https://crrev.com/108457cccefb7e044573a3d7b2cb56ce0c77c089/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java [modify] https://crrev.com/108457cccefb7e044573a3d7b2cb56ce0c77c089/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Nov 30 2016
Marking as fixed for now, will file separate bug to re-enable.
,
Nov 30 2016
,
Jan 19 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 22 2016