Re-enable rappor for vrshell |
|||||
Issue descriptionThere was a dependency cycle and resulting test code build break in 666811. This was fixed by removing the cycle, but also removing RAPPOR measurements in vrshell. This bug is the work to properly removing the dependency cycle and re-enable RAPPOR from vrshell.
,
Nov 28 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc622a50ae2f9501d07b271fe22181ed23bde1f5 commit fc622a50ae2f9501d07b271fe22181ed23bde1f5 Author: billorr <billorr@chromium.org> Date: Wed Nov 30 01:55:15 2016 Re-enable rappor for vrshell There was a dependency cycle and resulting test code build break when consuming g_browser_process from vr_shell. This fix provides a way to report rappor metrics in components that don't depend on chrome/browser. BUG= 667900 Review-Url: https://codereview.chromium.org/2526643002 Cr-Commit-Position: refs/heads/master@{#435119} [modify] https://crrev.com/fc622a50ae2f9501d07b271fe22181ed23bde1f5/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/fc622a50ae2f9501d07b271fe22181ed23bde1f5/chrome/browser/android/vr_shell/vr_usage_monitor.cc [modify] https://crrev.com/fc622a50ae2f9501d07b271fe22181ed23bde1f5/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/fc622a50ae2f9501d07b271fe22181ed23bde1f5/components/rappor/rappor_utils.cc [modify] https://crrev.com/fc622a50ae2f9501d07b271fe22181ed23bde1f5/components/rappor/rappor_utils.h
,
Dec 1 2016
See 667964, as this is a dependent change to enable tests for VRShell.
,
Dec 1 2016
This is still M57, isn't it? The original disabling didn't go into M56 iirc.
,
Dec 5 2016
,
Dec 5 2016
Not needed in M56. Fixed in M57. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by billorr@chromium.org
, Nov 22 2016