New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667898 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 652781



Sign in to add a comment

WebRTC blocks building Chromoting for target_os = ios

Project Member Reported by nicho...@chromium.org, Nov 22 2016

Issue description

Getting linking errors when enabling remoting and attempting to build.

Got the following errors:

Undefined symbols for architecture x86_64:
  "cricket::ApplyPacketOptions(unsigned char*, unsigned long, rtc::PacketTimeUpdateParams const&, unsigned long long)"

Undefined symbols for architecture x86_64:
  "webrtc::DesktopCapturerDifferWrapper::DesktopCapturerDifferWrapper(std::__1::unique_ptr<webrtc::DesktopCapturer, std::__1::default_delete<webrtc::DesktopCapturer> >)"


was able to fix it locally, required change:

[01:35:12] nicholss@nicholss-macpro ~/ios/bling/src/third_party/webrtc/modules/desktop_capture
⦿ git diff BUILD.gn
diff --git a/modules/desktop_capture/BUILD.gn b/modules/desktop_capture/BUILD.gn
index b43d90513..fb7e3a89a 100644
--- a/modules/desktop_capture/BUILD.gn
+++ b/modules/desktop_capture/BUILD.gn
@@ -9,8 +9,7 @@
 import("//build/config/ui.gni")
 import("../../build/webrtc.gni")

-use_desktop_capture_differ_sse2 =
-    !is_ios && (current_cpu == "x86" || current_cpu == "x64")
+use_desktop_capture_differ_sse2 = (current_cpu == "x86" || current_cpu == "x64")

 rtc_static_library("primitives") {
   sources = [
@@ -176,14 +175,14 @@ rtc_static_library("desktop_capture") {
     ]
   }

-  if (!is_ios) {
+#  if (!is_ios) {
     sources += [
       "desktop_capturer_differ_wrapper.cc",
       "desktop_capturer_differ_wrapper.h",
       "differ_block.cc",
       "differ_block.h",
     ]
-  }
+#  }

   if (is_mac) {
     libs = [
 
Blocking: 652781
Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
Fixed by https://codereview.webrtc.org/2522083002/
Labels: M-57

Sign in to add a comment