New issue
Advanced search Search tips

Issue 667892 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Deprecate SequencedWorkerPool

Project Member Reported by fdoray@chromium.org, Nov 22 2016

Issue description

Remove all usage of SequencedWorkerPool. Use TaskScheduler instead.
 
Showing comments 332 - 431 of 431 Older
Project Member

Comment 332 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61269077f9faa81be6143fd2abb55d27e7d90d0

commit c61269077f9faa81be6143fd2abb55d27e7d90d0
Author: isherman <isherman@chromium.org>
Date: Mon Jun 26 22:58:27 2017

[Cleanup] Migrate ImporterList to use the TaskScheduler API.

BUG=667892
TEST=none
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2961713002
Cr-Commit-Position: refs/heads/master@{#482449}

[modify] https://crrev.com/c61269077f9faa81be6143fd2abb55d27e7d90d0/chrome/browser/importer/importer_list.cc
[modify] https://crrev.com/c61269077f9faa81be6143fd2abb55d27e7d90d0/chrome/browser/importer/importer_list.h

Project Member

Comment 333 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/587eef11c3078e0706b54247efccb8bde6b4b359

commit 587eef11c3078e0706b54247efccb8bde6b4b359
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Tue Jun 27 08:04:41 2017

arc: Switch from BlockingPool to TaskScheduler

BUG=667892

Change-Id: Ic1113e7da8020f4529a554a9d4483a147ebc59be
Reviewed-on: https://chromium-review.googlesource.com/549521
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482567}
[modify] https://crrev.com/587eef11c3078e0706b54247efccb8bde6b4b359/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc

Project Member

Comment 334 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715cc9a29f6d78cf129f319a6f0b028a961fc5ed

commit 715cc9a29f6d78cf129f319a6f0b028a961fc5ed
Author: isherman <isherman@chromium.org>
Date: Tue Jun 27 17:36:00 2017

[Cleanup] Remove a reference to the FILE thread.

BUG=667892
TEST=none
R=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2960763002
Cr-Commit-Position: refs/heads/master@{#482667}

[modify] https://crrev.com/715cc9a29f6d78cf129f319a6f0b028a961fc5ed/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc

Project Member

Comment 335 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d380bea073931bcc05118e861ffe2d8fe0d9403

commit 7d380bea073931bcc05118e861ffe2d8fe0d9403
Author: thestig <thestig@chromium.org>
Date: Tue Jun 27 19:42:07 2017

Remove GetBlockingPool() usage in PrinterCapabilitiesTest.

The function being tested only cares about enforcing ThreadRestrictions
now. Since the unit test does not enforce ThreadRestrictions, just call
the function being tested.

Also put the test in the printing namespace.

BUG=667892

Review-Url: https://codereview.chromium.org/2959823003
Cr-Commit-Position: refs/heads/master@{#482714}

[modify] https://crrev.com/7d380bea073931bcc05118e861ffe2d8fe0d9403/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

Project Member

Comment 336 by bugdroid1@chromium.org, Jun 28 2017

Project Member

Comment 337 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c542b721769c8eea65fd1be790f66cb77768913

commit 8c542b721769c8eea65fd1be790f66cb77768913
Author: isherman <isherman@chromium.org>
Date: Wed Jun 28 22:40:26 2017

[Cleanup] Use a sequence checker rather than a thread checker for the metrics service.

BUG=667892
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2957383002
Cr-Commit-Position: refs/heads/master@{#483177}

[modify] https://crrev.com/8c542b721769c8eea65fd1be790f66cb77768913/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/8c542b721769c8eea65fd1be790f66cb77768913/chrome/browser/metrics/chrome_metrics_service_client.h

Project Member

Comment 340 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc8279c01912b090d276d9257c0407e31279a1d

commit 1dc8279c01912b090d276d9257c0407e31279a1d
Author: deadbeef <deadbeef@chromium.org>
Date: Thu Jun 29 13:07:07 2017

Use TaskScheduler instead of PostTask in P2PSocketDispatcherHost.

Using USER_VISIBLE priority, since updating the network list may be
needed to establish a WebRTC connection initiated by the user.

BUG=chromium:667892

Review-Url: https://codereview.chromium.org/2963733002
Cr-Commit-Position: refs/heads/master@{#483342}

[modify] https://crrev.com/1dc8279c01912b090d276d9257c0407e31279a1d/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/1dc8279c01912b090d276d9257c0407e31279a1d/content/browser/renderer_host/p2p/socket_dispatcher_host.h

Project Member

Comment 341 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c

commit bab2208a02c09baa03cb7cffd1bc3f6c996fa04c
Author: skau <skau@chromium.org>
Date: Thu Jun 29 17:00:40 2017

Convert to CupsPrintJobManagerImpl to TaskScheduler.

Place status polling on a sequenced task runner.  Run Cancel as a user visible task.

BUG=734280, 667892, 689520

Review-Url: https://codereview.chromium.org/2943843002
Cr-Commit-Position: refs/heads/master@{#483394}

[modify] https://crrev.com/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c/chrome/browser/chromeos/printing/cups_print_job_manager_impl.h

Project Member

Comment 343 by bugdroid1@chromium.org, Jun 30 2017

Project Member

Comment 346 by bugdroid1@chromium.org, Jun 30 2017

Project Member

Comment 347 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1966e9f24298b0a2183a362412c09d39f5d19c03

commit 1966e9f24298b0a2183a362412c09d39f5d19c03
Author: James Cook <jamescook@chromium.org>
Date: Wed Jul 05 02:36:26 2017

chromeos: Migrate ChromeScreenshotGrabber to TaskScheduler

Use the same sequenced task runner for ChromeScreenshotGrabber and
ui::ScreenshotGrabber to ensure that multiple screenshots taken
rapidly are processed in the same order.

Bug: 667892, 737162
Test: manually take screenshots with Ctrl-F5, check disk and clipboard
Change-Id: I48f557adb6dc9f7b63ab90c852947f6505e344de
Reviewed-on: https://chromium-review.googlesource.com/549970
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484181}
[modify] https://crrev.com/1966e9f24298b0a2183a362412c09d39f5d19c03/chrome/browser/ui/ash/chrome_screenshot_grabber.cc

Project Member

Comment 348 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f35d7feb5436027af2f931e5fa2932a1c24b9380

commit f35d7feb5436027af2f931e5fa2932a1c24b9380
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Jul 06 00:14:41 2017

Introduce GoogleUpdateSettings::CollectStatsConsentTaskRunner and get rid of FILE thread usage in callers.

An Android caller was also using BlockingPool() to make this call before
so this was potentially racy there.

R=asviktine@chromium.org, grt@chromium.org

Bug: 730170, 667892, 689520
Change-Id: I04aacb46379f4e6e6fc27df5ddf09b05a860e223
Reviewed-on: https://chromium-review.googlesource.com/543560
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484389}
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/browser/android/metrics/uma_session_stats.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/browser/google/google_update_settings_posix.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/browser/metrics/metrics_reporting_state.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/installer/util/google_update_settings.cc
[modify] https://crrev.com/f35d7feb5436027af2f931e5fa2932a1c24b9380/chrome/installer/util/google_update_settings.h

Project Member

Comment 349 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b408d71db763eeca8d9744ed97944fac5f5a22

commit 32b408d71db763eeca8d9744ed97944fac5f5a22
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Jul 06 06:57:19 2017

FileAPI: Use TaskScheduler in file_system_operation_runner_unittest.cc

BrowserThread::GetTaskRunnerForThread() is deprecated in favor of TaskScheduler
APIs.

Bug: 667892
Change-Id: I48023a77a5c175afbe99bb0c91240d563ba79f8c
Reviewed-on: https://chromium-review.googlesource.com/560933
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484490}
[modify] https://crrev.com/32b408d71db763eeca8d9744ed97944fac5f5a22/content/browser/fileapi/file_system_operation_runner_unittest.cc

Project Member

Comment 350 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3228e26006d95ce3e37ab5a428fd78787db5aa2

commit f3228e26006d95ce3e37ab5a428fd78787db5aa2
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Jul 06 08:20:46 2017

ServiceWorker: Use TaskScheduler in service_worker_browsertest.cc

BrowserThread::GetTaskRunnerForThread() is deprecated in favor of TaskScheduler
APIs.

Bug: 667892
Change-Id: Iac17b66d5369491f9493dcc28c920e198a737e60
Reviewed-on: https://chromium-review.googlesource.com/560815
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484492}
[modify] https://crrev.com/f3228e26006d95ce3e37ab5a428fd78787db5aa2/content/browser/service_worker/service_worker_browsertest.cc

Project Member

Comment 351 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7536deeef03830842a26867ea911535efd664954

commit 7536deeef03830842a26867ea911535efd664954
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 06 14:53:11 2017

chromeos: Make owner settings code not use blocking pool.

Update OwnerSettingsServiceChromeOS to call
base::CreateTaskRunnerWithTraits() instead of
content::BrowserThread::GetBlockingPool().

BUG=667892

Change-Id: I0e5d037e4081cf9ce79c908790eab20abd20c865
Reviewed-on: https://chromium-review.googlesource.com/560781
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484589}
[modify] https://crrev.com/7536deeef03830842a26867ea911535efd664954/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Project Member

Comment 352 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/661b99fc181c9ef15a707e72f1ed15d2b35079b7

commit 661b99fc181c9ef15a707e72f1ed15d2b35079b7
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 06 15:57:59 2017

chromeeos: Don't use GetBlockingPool for quirks code.

Update QuirksManager to use a base::TaskRunner from
base::CreateTaskRunnerWithTraits() instead of a
base::SequencedWorkerPool from
content::BrowserThread::GetBlockingPool(). As far as I can
tell, it was just treating the sequenced pool as a regular
task runner anyway.

BUG=667892

Change-Id: I2d198781bc27b17ad64b31b5f6c5b39bffee0406
Reviewed-on: https://chromium-review.googlesource.com/560897
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484613}
[modify] https://crrev.com/661b99fc181c9ef15a707e72f1ed15d2b35079b7/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/661b99fc181c9ef15a707e72f1ed15d2b35079b7/components/quirks/quirks_client.cc
[modify] https://crrev.com/661b99fc181c9ef15a707e72f1ed15d2b35079b7/components/quirks/quirks_manager.cc
[modify] https://crrev.com/661b99fc181c9ef15a707e72f1ed15d2b35079b7/components/quirks/quirks_manager.h

Project Member

Comment 353 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55a9844c4ce86bff603ae7662c399350e6ba6d40

commit 55a9844c4ce86bff603ae7662c399350e6ba6d40
Author: mek <mek@chromium.org>
Date: Thu Jul 06 16:57:05 2017

Revert of Remove usage of SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext. (patchset #1 id:1 of https://codereview.chromium.org/2883403002/ )

Reason for revert:
Seems to cause data races, since different FileSystemContexts are no longer sharing the same sequence.

Original issue's description:
> Remove usage of SequencedWorkerPool::GetNamedSequenceToken from content::CreateFileSystemContext.
>
> SequencedWorkerPool is being deprecated in favor of TaskScheduler.
>
> BUG=667892
>
> Review-Url: https://codereview.chromium.org/2883403002
> Cr-Commit-Position: refs/heads/master@{#474638}
> Committed: https://chromium.googlesource.com/chromium/src/+/bb731a6137ac921a8aa465613acab752b16f4666

TBR=tzik@chromium.org,fdoray@chromium.org
BUG=667892
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2969293003
Cr-Commit-Position: refs/heads/master@{#484638}

[modify] https://crrev.com/55a9844c4ce86bff603ae7662c399350e6ba6d40/content/browser/fileapi/browser_file_system_helper.cc

Project Member

Comment 355 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0

commit c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jul 07 05:51:06 2017

chromeos: Drop GetBlockingPool from kiosk code.

Update kiosk classes and AutomaticRebootManager, along with
related tests, to call base::PostTask* instead of
content::BrowserThread::GetBlockingPool().

BUG=667892

Change-Id: Ie6db5d105ab872af5d6688a274c6b4106ddf1072
Reviewed-on: https://chromium-review.googlesource.com/562632
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484842}
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.cc
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.h
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/system/automatic_reboot_manager.cc
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/system/automatic_reboot_manager.h
[modify] https://crrev.com/c4c8cd2c4f3c72e7cffd0ba33873586066dc05f0/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc

Project Member

Comment 357 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85f2caa791d58e72eb82957a05097ffa5559d513

commit 85f2caa791d58e72eb82957a05097ffa5559d513
Author: Mike West <mkwst@chromium.org>
Date: Fri Jul 07 12:55:30 2017

Migrate several instances of FILE to the new scheduler.

This patch addresses:

- chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
- content/shell/browser/layout_test/layout_test_browser_context.cc
- content/shell/browser/shell_download_manager_delegate.cc

Bug: 667892
Change-Id: If4898d243b820dab5a240eeb916508bf27beb1cd
Reviewed-on: https://chromium-review.googlesource.com/561006
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484906}
[modify] https://crrev.com/85f2caa791d58e72eb82957a05097ffa5559d513/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
[modify] https://crrev.com/85f2caa791d58e72eb82957a05097ffa5559d513/content/shell/browser/layout_test/layout_test_browser_context.cc
[modify] https://crrev.com/85f2caa791d58e72eb82957a05097ffa5559d513/content/shell/browser/shell_download_manager_delegate.cc

Project Member

Comment 358 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61c23ac2855588b44f7b4f0afc1b327517b2b02

commit e61c23ac2855588b44f7b4f0afc1b327517b2b02
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Fri Jul 07 16:25:06 2017

Migrate LogoTracker to TaskScheduler API.

Bug: 667892
Change-Id: Icaaef380816473c677cf0cbf9fd24e98dafd8325
Reviewed-on: https://chromium-review.googlesource.com/558919
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484947}
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/chrome/browser/android/logo_service.cc
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_cache.cc
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_cache.h
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_cache_unittest.cc
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_tracker.h
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/components/search_provider_logos/logo_tracker_unittest.cc
[modify] https://crrev.com/e61c23ac2855588b44f7b4f0afc1b327517b2b02/ios/chrome/browser/google/google_logo_service.mm

Project Member

Comment 359 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb93e73a8e634f18b0c52b2f9fb2dca557de9d9

commit 5cb93e73a8e634f18b0c52b2f9fb2dca557de9d9
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jul 10 19:59:57 2017

chromeos: Use base::PostTask in InputDeviceSettingsImplX11.

Use the new thing instead of the old thing.

BUG=667892

Change-Id: Ibc732bb4a4c285279ed6fa27885bb687a451b366
Reviewed-on: https://chromium-review.googlesource.com/560562
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485354}
[modify] https://crrev.com/5cb93e73a8e634f18b0c52b2f9fb2dca557de9d9/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc

Project Member

Comment 360 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bd962c230c78176250bfa9f7b63e068dc18a6ac

commit 1bd962c230c78176250bfa9f7b63e068dc18a6ac
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jul 10 22:59:48 2017

chromeos: Update FileFlusherTest to not use BrowserThread.

Remove calls to
content::BrowserThread::GetBlockingPool()->FlushForTesting()
and base::RunLoop().RunUntilIdle() from TearDown().
content::TestBrowserThreadBundle is documented as already
running remaining tasks during destruction.

BUG=667892

Change-Id: I0368a0f94e9ddbfde284b18e3222894ee1d80b55
Reviewed-on: https://chromium-review.googlesource.com/560643
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485435}
[modify] https://crrev.com/1bd962c230c78176250bfa9f7b63e068dc18a6ac/chrome/browser/chromeos/base/file_flusher_unittest.cc

Project Member

Comment 361 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4922b5d46d4aeda4e08d26b5c7092606e1b5e132

commit 4922b5d46d4aeda4e08d26b5c7092606e1b5e132
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jul 11 13:55:50 2017

Rewrite much of //components/upload_list.

- Make UploadList an abstract interface, and split out the text log parsing
  into a concrete TextLogUploadList subclass.
- Convert UploadList to use the TaskScheduler.
- Remove the UploadList::Delegate in favor of a OnceClosure callback.
- Remove most of CrashUploadList, except a string constant it defines.

Bug: 667892
Change-Id: Ibeaf37eaa608ae2d673e3706b68618aefbe0340b
Reviewed-on: https://chromium-review.googlesource.com/563979
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Christopher Lam <calamity@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485619}
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list_android.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list_android.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/crash_upload_list/crash_upload_list_crashpad.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/feedback/system_logs/log_sources/crash_ids_source.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/feedback/system_logs/log_sources/crash_ids_source.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/media/webrtc/webrtc_log_list.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/media/webrtc/webrtc_log_list.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/BUILD.gn
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/crash_upload_list.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/crash_upload_list.h
[add] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/text_log_upload_list.cc
[add] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/text_log_upload_list.h
[rename] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/text_log_upload_list_unittest.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/upload_list.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/components/upload_list/upload_list.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/ios/chrome/browser/crash_report/crash_upload_list.cc
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/ios/chrome/browser/crash_report/crash_upload_list.h
[modify] https://crrev.com/4922b5d46d4aeda4e08d26b5c7092606e1b5e132/ios/chrome/browser/ui/webui/crashes_ui.cc

Project Member

Comment 362 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d71d53f0142954869b02fb1a93d8c790e1743c3

commit 2d71d53f0142954869b02fb1a93d8c790e1743c3
Author: isherman <isherman@chromium.org>
Date: Wed Jul 12 21:54:55 2017

[Cleanup] Migrate ChromeBrowserMainExtraPartsMetrics to use the Task Scheduler.

This also changes the timing with which startup metrics are recorded: Previously they were recorded ~45 seconds after startup; now they're recorded whenever the TaskScheduler schedules them to be.  This is not expected to change the values recorded to these metrics.

BUG=667892, 741816
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2955063005
Cr-Commit-Position: refs/heads/master@{#486114}

[modify] https://crrev.com/2d71d53f0142954869b02fb1a93d8c790e1743c3/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Project Member

Comment 363 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5bb97a108dffe01857912df100b5cc4964437d

commit 3a5bb97a108dffe01857912df100b5cc4964437d
Author: Ilya Sherman <isherman@chromium.org>
Date: Fri Jul 14 23:26:14 2017

[Cleanup] Define TaskTraits as constexpr.

BUG=667892
R=gab@chromium.org

Change-Id: If4c7bdd1a8109a38cf0dc1081234e025e267f217
Reviewed-on: https://chromium-review.googlesource.com/570732
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486935}
[modify] https://crrev.com/3a5bb97a108dffe01857912df100b5cc4964437d/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Project Member

Comment 364 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d43422a781c01fb054594ebb44ca0fd606e61d

commit d9d43422a781c01fb054594ebb44ca0fd606e61d
Author: xdai <xdai@chromium.org>
Date: Fri Jul 14 23:45:29 2017

Remove GetBlockingPool() in wallpaper_manager.cc file.

The blocking pool has been deprecated in favor of TaskScheduler.

Bug: 667892
Change-Id: Iabaa23abc14ade5b5c0e4ed9bee6b8f574d7b689
Reviewed-on: https://chromium-review.googlesource.com/571306
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486943}
[modify] https://crrev.com/d9d43422a781c01fb054594ebb44ca0fd606e61d/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/d9d43422a781c01fb054594ebb44ca0fd606e61d/components/wallpaper/wallpaper_manager_base.h

Project Member

Comment 365 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5433182d717ccdc0674ed67aed28db5b8b7e0cae

commit 5433182d717ccdc0674ed67aed28db5b8b7e0cae
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jul 18 02:06:17 2017

Move the Mac WebDragSource to use the TaskScheduler.

BUG=667892

Change-Id: I25c809655f4be1f170bcd07e25574766348c2de8
Reviewed-on: https://chromium-review.googlesource.com/575670
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487343}
[modify] https://crrev.com/5433182d717ccdc0674ed67aed28db5b8b7e0cae/content/browser/web_contents/web_drag_source_mac.mm

Project Member

Comment 366 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d075ed52552ba9ca748acf0efc807b594d44d69b

commit d075ed52552ba9ca748acf0efc807b594d44d69b
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Jul 19 14:55:58 2017

Replace explicit GetBlockingPool() flush with RunAllBlockingPoolTasksUntilIdle().

Adresses
content/public/test/download_test_observer.cc : GetBlockingPool()
entry of
https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit#gid=0

Bug: 667892
Change-Id: I74311b46bdf7e3ddda94bd868fbf4472b5a39609
Reviewed-on: https://chromium-review.googlesource.com/576372
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487863}
[modify] https://crrev.com/d075ed52552ba9ca748acf0efc807b594d44d69b/content/public/test/download_test_observer.cc

Project Member

Comment 368 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da23293e16e7900e01162edb6f9b6e05d73254e8

commit da23293e16e7900e01162edb6f9b6e05d73254e8
Author: Yusuke Sato <yusukes@chromium.org>
Date: Fri Jul 21 03:33:00 2017

Use task_scheduler in c/b/chromeos/arc/process/arc_process_service.cc

BUG=chromium:667892
TEST=try, start ARC, press Search+ESC to show the UI

Change-Id: I96b9cefaddbe26dc78edcb5217cae58d3c4a6a81
Reviewed-on: https://chromium-review.googlesource.com/580012
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488569}
[modify] https://crrev.com/da23293e16e7900e01162edb6f9b6e05d73254e8/chrome/browser/chromeos/arc/process/arc_process_service.cc

Project Member

Comment 369 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9cff12b94e2eb935595e7705ecb40dbe0f977f5

commit b9cff12b94e2eb935595e7705ecb40dbe0f977f5
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jul 21 23:38:51 2017

Post VerifyInstallation() to TaskScheduler instead of BlockingPool.

TODO(robertshield): remove this call and everything that falls off of it.

R=robertshield@chromium.org, thakis@chromium.org

Bug: 667892, 747557
Change-Id: I1ddad1db01f18db6b7121945c1313933c9e2e16b
Reviewed-on: https://chromium-review.googlesource.com/581634
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488797}
[modify] https://crrev.com/b9cff12b94e2eb935595e7705ecb40dbe0f977f5/chrome/browser/chrome_browser_main_win.cc

Project Member

Comment 370 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee207f8e168f76deb5855f119816bbcbf2fe480

commit 2ee207f8e168f76deb5855f119816bbcbf2fe480
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Sat Jul 22 01:38:18 2017

Migrate history_report to TaskScheduler API

GetBlockingPool() is replaced by SequencedTaskRunner. There's no
per-task trait in SequencedTaskRunner, so the shutdown behavior are
all set to BLOCK_SHUTDOWN.

Bug: 667892
Change-Id: I6e8f2507b201a8cb077d7338f504684ca1e232c8
Reviewed-on: https://chromium-review.googlesource.com/580620
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488836}
[modify] https://crrev.com/2ee207f8e168f76deb5855f119816bbcbf2fe480/chrome/browser/android/history_report/delta_file_service.cc
[modify] https://crrev.com/2ee207f8e168f76deb5855f119816bbcbf2fe480/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/2ee207f8e168f76deb5855f119816bbcbf2fe480/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/2ee207f8e168f76deb5855f119816bbcbf2fe480/chrome/browser/android/history_report/usage_reports_buffer_service.h

Project Member

Comment 371 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75e87d2c7e2b5747112d6c5e0fdc8d30a532a94

commit e75e87d2c7e2b5747112d6c5e0fdc8d30a532a94
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jul 24 18:55:39 2017

Remove redundant GetBlockingPool()->FlushForTesting().

~TestBrowserThreadBundle() (fixture member) already does this.

R=sky@chromium.org

Bug: 667892
Change-Id: I55dba86325285c34313c32247d8b4ae68a7649ce
Reviewed-on: https://chromium-review.googlesource.com/583471
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489038}
[modify] https://crrev.com/e75e87d2c7e2b5747112d6c5e0fdc8d30a532a94/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

Project Member

Comment 372 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac17b63497b5c34c647276247ff71139e83d891

commit eac17b63497b5c34c647276247ff71139e83d891
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jul 24 19:01:48 2017

Replace GetBlockingPool()->FlushForTesting() with RunAllBlockingPoolTasksUntilIdle() in prerender unittests.

RunAllBlockingPoolTasksUntilIdle() also flushes the main loop so an
explicit RunEvents() becomes unecessary.

R=davidben@chromium.org

Bug: 667892
Change-Id: Iecf2e386c55cacadb9f064509ed5b109ce70e23a
Reviewed-on: https://chromium-review.googlesource.com/583569
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489039}
[modify] https://crrev.com/eac17b63497b5c34c647276247ff71139e83d891/chrome/browser/prerender/prerender_resource_throttle_unittest.cc

Project Member

Comment 373 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd895fc68d672eea839263d051775226fac20bf

commit ffd895fc68d672eea839263d051775226fac20bf
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jul 24 23:17:36 2017

Revert "Migrate history_report to TaskScheduler API"

This reverts commit 2ee207f8e168f76deb5855f119816bbcbf2fe480.

Reason for revert: Caused Icing crashes. https://crbug.com/747849

Original change's description:
> Migrate history_report to TaskScheduler API
> 
> GetBlockingPool() is replaced by SequencedTaskRunner. There's no
> per-task trait in SequencedTaskRunner, so the shutdown behavior are
> all set to BLOCK_SHUTDOWN.
> 
> Bug: 667892
> Change-Id: I6e8f2507b201a8cb077d7338f504684ca1e232c8
> Reviewed-on: https://chromium-review.googlesource.com/580620
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488836}

TBR=nyquist@chromium.org,wychen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Presubmit: true
Bug: 667892
Change-Id: Id6dcee0dd905a6322f2ee2d46a5072d0f6e7bed7
Reviewed-on: https://chromium-review.googlesource.com/583907
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489132}
[modify] https://crrev.com/ffd895fc68d672eea839263d051775226fac20bf/chrome/browser/android/history_report/delta_file_service.cc
[modify] https://crrev.com/ffd895fc68d672eea839263d051775226fac20bf/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/ffd895fc68d672eea839263d051775226fac20bf/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/ffd895fc68d672eea839263d051775226fac20bf/chrome/browser/android/history_report/usage_reports_buffer_service.h

Project Member

Comment 374 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd5214f6efc02a459d85f09cb9d09383083ea27d

commit dd5214f6efc02a459d85f09cb9d09383083ea27d
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 25 00:31:48 2017

Reland "Migrate history_report to TaskScheduler API"

GetBlockingPool() is replaced by SequencedTaskRunner. There's no
per-task trait in SequencedTaskRunner, so the shutdown behavior are
all set to BLOCK_SHUTDOWN.

The reland allows IO in history_report tasks, in order to fix the
Icing crash.

Bug: 667892, 747849
Change-Id: I82efc0c6f215c04f26d2b599d24dbee650fe99b6
Reviewed-on: https://chromium-review.googlesource.com/583580
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489161}
[modify] https://crrev.com/dd5214f6efc02a459d85f09cb9d09383083ea27d/chrome/browser/android/history_report/delta_file_service.cc
[modify] https://crrev.com/dd5214f6efc02a459d85f09cb9d09383083ea27d/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/dd5214f6efc02a459d85f09cb9d09383083ea27d/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/dd5214f6efc02a459d85f09cb9d09383083ea27d/chrome/browser/android/history_report/usage_reports_buffer_service.h

Project Member

Comment 376 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e0a2fcb0139350217c887a3ebe4059e1a2fd42

commit 70e0a2fcb0139350217c887a3ebe4059e1a2fd42
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Jul 26 10:52:24 2017

Migrate CreateFileSystemContext() to TaskScheduler.

This is take #2 after https://codereview.chromium.org/2883403002

R=tzik@chromium.org

Bug: 667892
Change-Id: Ibb08b11efecdb380fb7adff143ee2ba48b726380
Reviewed-on: https://chromium-review.googlesource.com/585588
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489602}
[modify] https://crrev.com/70e0a2fcb0139350217c887a3ebe4059e1a2fd42/content/browser/fileapi/browser_file_system_helper.cc

Project Member

Comment 377 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ae90404e07ed58775a83b1dd70e7c70412b921

commit f6ae90404e07ed58775a83b1dd70e7c70412b921
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Jul 27 03:48:48 2017

TaskScheduler migration for ServiceWorkerURLRequestJob.

GetBlockingPool() -> PostTask()

Bug: 667892
Change-Id: I147c392124beb69d379a2e586eddeb872ac99d54
Reviewed-on: https://chromium-review.googlesource.com/586354
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489852}
[modify] https://crrev.com/f6ae90404e07ed58775a83b1dd70e7c70412b921/content/browser/service_worker/service_worker_url_request_job.cc

Project Member

Comment 378 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7

commit b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Jul 27 06:10:35 2017

Move Local State's task runner to TaskScheduler.

The CrOS restart logic now has to reach into BrowserProcess to
ask for Local State to be flushed and get called back when it did.
There's quite a history there:
 * https://crbug.com/302578 is the reason EndSession() doesn't flush
   local_state() on CrOS.
 * But then it's explicitly needed on restarts (but still has to happen
   async so the kernel doesn't think the main thread is hung):
   https://codereview.chromium.org/6710001 + 
   https://codereview.chromium.org/6713032

R=robliao@chromium.org

Bug: 667892, 195612, chromium-os:13102, chromium-os:6924, 747495
Change-Id: I8fca8dba6a2f6c85b032367d78a26b1a92ae1b7a
Reviewed-on: https://chromium-review.googlesource.com/580336
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489871}
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/browser/browser_process.h
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/common/chrome_constants.cc
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/common/chrome_constants.h
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/b1af7ffb1f92f8ca46c32e330a6f715fc1bed0a7/chrome/test/base/testing_browser_process.h

Project Member

Comment 379 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b20d8ef2273bd947156ccdf07af5aaa321be322

commit 9b20d8ef2273bd947156ccdf07af5aaa321be322
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Jul 27 11:54:17 2017

TaskScheduler migration for ServiceWorkerStorage (database task runner)

GetBlockingPool() -> CreateSequencedTaskRunnerWithTraits()

This is BLOCK_SHUTDOWN for now until task runner gains the feature to
mix task shutdown behaviors.

Bug: 667892
Change-Id: Ic15f2bb2730d8b44dac2ade64f062fdca40d517e
Reviewed-on: https://chromium-review.googlesource.com/588607
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489902}
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/BUILD.gn
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_context_wrapper.h
[delete] https://crrev.com/ddf5acab903eaca3a63d65b0558c6bf7680864d8/content/browser/service_worker/service_worker_database_task_manager.cc
[delete] https://crrev.com/ddf5acab903eaca3a63d65b0558c6bf7680864d8/content/browser/service_worker/service_worker_database_task_manager.h
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/9b20d8ef2273bd947156ccdf07af5aaa321be322/content/browser/service_worker/service_worker_storage.h

Project Member

Comment 380 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b48b3e4878624375427d69bf077f1179d17dcd5

commit 7b48b3e4878624375427d69bf077f1179d17dcd5
Author: David Roger <droger@chromium.org>
Date: Thu Jul 27 12:44:37 2017

Remove BlockingPool usage from ProfileImpl

This CL moves away from the JsonPrefStore::GetTaskRunnerForFile()
function, which was requiring a blocking pool.
Instead the task runner management is done by hand in the class.

Bug: 667892
Change-Id: Ie2485a70d79f75b69c3bf4543d48815bc1d78904
Reviewed-on: https://chromium-review.googlesource.com/575229
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489906}
[modify] https://crrev.com/7b48b3e4878624375427d69bf077f1179d17dcd5/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/7b48b3e4878624375427d69bf077f1179d17dcd5/chrome/browser/profiles/profile_impl.h

Project Member

Comment 381 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b86ce3b3213ba3b0639ac9a9d67e184340a9836

commit 4b86ce3b3213ba3b0639ac9a9d67e184340a9836
Author: Marc Treib <treib@chromium.org>
Date: Thu Jul 27 15:30:24 2017

Remove WebThread::GetBlockingPool usage in iOS SuggestionsServiceFactory

Bug: 667892
Change-Id: I94e25170fe53b2fc35d99a2492d74c3ffaf5b529
Reviewed-on: https://chromium-review.googlesource.com/589029
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489934}
[modify] https://crrev.com/4b86ce3b3213ba3b0639ac9a9d67e184340a9836/ios/chrome/browser/suggestions/suggestions_service_factory.mm

Project Member

Comment 382 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c6845293aa427e7dacf40897f331928a8a46f1

commit 32c6845293aa427e7dacf40897f331928a8a46f1
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Jul 28 03:05:02 2017

Use task scheduler in chrome_browser_main_mac.mm.

This CL removes the usage of the FILE thread from chrome_browser_main_mac.mm
and resolves an old TODO to make a metadata file only write on Chrome's
first run.

Bug: 667892
Change-Id: I980776c1eeec13a711a74051ac3a436b4b9c5025
Reviewed-on: https://chromium-review.googlesource.com/587703
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490231}
[modify] https://crrev.com/32c6845293aa427e7dacf40897f331928a8a46f1/chrome/browser/chrome_browser_main_mac.mm

Project Member

Comment 383 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9afb1bc9edbcb4b5af26121606edcb8c12241e

commit ca9afb1bc9edbcb4b5af26121606edcb8c12241e
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Fri Jul 28 03:16:04 2017

Removes BlockingPool usage from chromecast::PrefServiceHelper.

Instead of using JsonPrefStore::GetTaskRunnerForFile, which requires a
blocking pool, we now instantiate JsonPrefStore directly which creates
an internal default task runner.

Bug: 667892
Change-Id: I3e0e037363efbc3fa806f5a7cbec0d4c7ec3a26b
Reviewed-on: https://chromium-review.googlesource.com/590482
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490236}
[modify] https://crrev.com/ca9afb1bc9edbcb4b5af26121606edcb8c12241e/chromecast/browser/pref_service_helper.cc

Project Member

Comment 384 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea4dd7af75674258d41828bff1ffa1fcf1e33e13

commit ea4dd7af75674258d41828bff1ffa1fcf1e33e13
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jul 28 05:38:15 2017

Convert CrashHandlerHostLinux to use the TaskScheduler.

BUG=667892

Change-Id: Iac13a3891fa01edfc9979470b3dd09e6e0ec03f4
Reviewed-on: https://chromium-review.googlesource.com/588338
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490287}
[modify] https://crrev.com/ea4dd7af75674258d41828bff1ffa1fcf1e33e13/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/ea4dd7af75674258d41828bff1ffa1fcf1e33e13/components/crash/content/browser/crash_handler_host_linux.h

Project Member

Comment 385 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0

commit d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Jul 28 07:42:28 2017

Replace DB thread usage in WebDataService with task scheduler.

Bug: 667892
Change-Id: I368b234d63c6cf46e2b32532ae11e011b04abbc6
Reviewed-on: https://chromium-review.googlesource.com/566181
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490312}
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/aw_form_database_service.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/android_webview/browser/aw_form_database_service_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/browsing_data/autofill_counter_browsertest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/search_engines/template_url_service_factory_test_util.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/browser/web_data_service_factory.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/components/autofill/core/browser/webdata/web_data_service_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/components/webdata_services/web_data_service_wrapper.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/components/webdata_services/web_data_service_wrapper.h
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/d3e6933ae6f81b4ec00027eefc7d2f04e78d14b0/ios/chrome/browser/web_data_service_factory.cc

Project Member

Comment 386 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93fb886bbf983cf7026a6aa3357b15da8f203648

commit 93fb886bbf983cf7026a6aa3357b15da8f203648
Author: Biao She <bshe@chromium.org>
Date: Sat Jul 29 20:35:31 2017

Remove usage of SequencedWorkerPool::GetNamedSequenceToken from WallpaperApi and WallpaperPrivateApi

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

Bug: 667892
Change-Id: Id4b1bdfba4b5f004bea8985925f23d5211016280
Reviewed-on: https://chromium-review.googlesource.com/561657
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490672}
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/chrome/browser/chromeos/extensions/wallpaper_api.h
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/93fb886bbf983cf7026a6aa3357b15da8f203648/components/wallpaper/wallpaper_manager_base.h

Project Member

Comment 387 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c

commit 7cfb8d0d59aaf783845accc7d41a5a63f9413c2c
Author: gambard <gambard@chromium.org>
Date: Mon Jul 31 13:24:28 2017

Remove WebThread::GetBlockingPool usage for IOSImageDecoderImpl

Removes the plumbing for the pool and creates it directly in the class.

Bug: 667892
Change-Id: Idf70d171f20d5f649978ef36db9988c4918430f5
Reviewed-on: https://chromium-review.googlesource.com/591128
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490752}
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/components/image_fetcher/ios/ios_image_decoder_impl.h
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/components/image_fetcher/ios/ios_image_decoder_impl.mm
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/components/image_fetcher/ios/ios_image_decoder_impl_unittest.mm
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
[modify] https://crrev.com/7cfb8d0d59aaf783845accc7d41a5a63f9413c2c/ios/chrome/browser/suggestions/suggestions_service_factory.mm

Project Member

Comment 388 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10dba963e93ddcde2058dcdc0dbf9ffa6f0ddf67

commit 10dba963e93ddcde2058dcdc0dbf9ffa6f0ddf67
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jul 31 15:29:02 2017

Migrate iOS ApplicationContext to TaskScheduler.

(this doesn't use the TaskScheduler API directly because that's the
default behavior on JsonPrefStore now when not provided an explicit
SequencedTaskRunner at construction :))

R=rohitrao@chromium.org

Bug: 667892
Change-Id: Ifa0549e4ddf65ad8606451a47724234981c35467
Reviewed-on: https://chromium-review.googlesource.com/590573
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490766}
[modify] https://crrev.com/10dba963e93ddcde2058dcdc0dbf9ffa6f0ddf67/ios/web_view/internal/app/application_context.cc
[modify] https://crrev.com/10dba963e93ddcde2058dcdc0dbf9ffa6f0ddf67/ios/web_view/internal/app/application_context.h

Project Member

Comment 389 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d085cd8ded89f7851344262873379a0ab9e6d9f4

commit d085cd8ded89f7851344262873379a0ab9e6d9f4
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jul 31 15:40:52 2017

Migrate iOS DownloadManagerController to TaskScheduler

R=rohitrao@chromium.org

Bug: 667892
Change-Id: Ia6cd649c678a65a1f16351864d6a88c9a8e4b9d2
Reviewed-on: https://chromium-review.googlesource.com/590080
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490770}
[modify] https://crrev.com/d085cd8ded89f7851344262873379a0ab9e6d9f4/ios/chrome/browser/ui/downloads/download_manager_controller.mm

Project Member

Comment 390 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295

commit d11bd2ebf1a4aa4278f91c0b3f77f849b500e295
Author: Scott Violet <sky@chromium.org>
Date: Tue Aug 01 05:13:06 2017

Converts session service related code to TaskScheduler

BUG=667892
TEST=covered by tests

Change-Id: Id7cdd67a82281d9a95bef680b4fabb58c67263fc
Reviewed-on: https://chromium-review.googlesource.com/592463
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490855}
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/chrome/browser/sessions/chrome_tab_restore_service_client.cc
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/chrome/browser/sessions/chrome_tab_restore_service_client.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/chrome/browser/sessions/session_service.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/chrome/browser/sessions/session_service_unittest.cc
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/components/sessions/core/base_session_service.cc
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/components/sessions/core/base_session_service.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/components/sessions/core/base_session_service_delegate.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/components/sessions/core/persistent_tab_restore_service.cc
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/components/sessions/core/tab_restore_service_client.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h
[modify] https://crrev.com/d11bd2ebf1a4aa4278f91c0b3f77f849b500e295/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm

Project Member

Comment 391 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de0f5816ded9c8841262ccb34433a338fa5d5ec5

commit de0f5816ded9c8841262ccb34433a338fa5d5ec5
Author: gambard <gambard@chromium.org>
Date: Tue Aug 01 07:41:09 2017

Remove WebThread::GetBlockingPool usage for LargeIconService

Bug: 667892
Change-Id: I6a044a60e212c8cd8f264a8d6c6d3e2c74a3bcdf
Reviewed-on: https://chromium-review.googlesource.com/591147
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490904}
[modify] https://crrev.com/de0f5816ded9c8841262ccb34433a338fa5d5ec5/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

Project Member

Comment 392 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/828fb5916f4111e9bf0780b84517ce7c61263fd2

commit 828fb5916f4111e9bf0780b84517ce7c61263fd2
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Aug 01 15:25:15 2017

Use TaskScheduler instead of SequencedWorkerPool in session_manager_operation.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

Already reviewed on Gerrit: https://codereview.chromium.org/2875393002/

TBR=bartfab@chromium.org

Bug: 667892
Change-Id: I1e89eac5f3464f0f939494f7fff14510f51f1030
Reviewed-on: https://chromium-review.googlesource.com/595874
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490999}
[modify] https://crrev.com/828fb5916f4111e9bf0780b84517ce7c61263fd2/chrome/browser/chromeos/settings/session_manager_operation.cc

Project Member

Comment 393 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54

commit c4a9c77f6e6c59b02fbb09db8da441f630b9ac54
Author: rogerta <rogerta@chromium.org>
Date: Tue Aug 01 16:40:30 2017

Remove call to GetBlockingPool in RLZ.

BUG=667892, 618530

Review-Url: https://codereview.chromium.org/2949263003
Cr-Commit-Position: refs/heads/master@{#491013}

[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/chrome/browser/rlz/chrome_rlz_tracker_delegate.h
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/chrome/browser/rlz/chrome_rlz_tracker_delegate_unittest.cc
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/components/rlz/rlz_tracker.cc
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/components/rlz/rlz_tracker.h
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/components/rlz/rlz_tracker_delegate.h
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/components/rlz/rlz_tracker_unittest.cc
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h
[modify] https://crrev.com/c4a9c77f6e6c59b02fbb09db8da441f630b9ac54/rlz/lib/financial_ping.cc

Project Member

Comment 394 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d7eafafe79091499d715b3e2162e9773ec90a09

commit 9d7eafafe79091499d715b3e2162e9773ec90a09
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Aug 04 15:28:42 2017

Make //ios validation_rules_storage_factory match //chrome's

JsonPrefStore grabs an independent SequencedTaskRunner per store by
default now.

R=mahmadi@chromium.org

Bug: 667892
Change-Id: Ied4fb6b10bb4c6cc8be4fc66fedd8a9c0ff64a74
Reviewed-on: https://chromium-review.googlesource.com/600508
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492039}
[modify] https://crrev.com/9d7eafafe79091499d715b3e2162e9773ec90a09/ios/chrome/browser/autofill/validation_rules_storage_factory.cc

Project Member

Comment 395 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8acb83af4c25780479863880c2ce4074f5098de

commit c8acb83af4c25780479863880c2ce4074f5098de
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Aug 04 17:03:06 2017

Remove ViewsDelegate::GetBlockingPoolTaskRunner().

Consequentially cleaning up another use of deprecated GetBlockingPool().

R=sky@chromium.org

Bug: 667892
Change-Id: Iaf99f86311f9d14e6dcc25eab71d83026a59e9bf
Reviewed-on: https://chromium-review.googlesource.com/600507
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492053}
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/chrome/browser/ui/views/chrome_views_delegate.cc
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/chrome/browser/ui/views/chrome_views_delegate.h
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/accessibility/platform/atk_util_auralinux.cc
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/accessibility/platform/atk_util_auralinux.h
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/accessibility/platform/ax_platform_node_auralinux.h
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/views/views_delegate.cc
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/views/views_delegate.h
[modify] https://crrev.com/c8acb83af4c25780479863880c2ce4074f5098de/ui/views/win/windows_session_change_observer.cc

Project Member

Comment 396 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc920595a7cfd76b7e9c04a3b555e5f533deb36

commit 2dc920595a7cfd76b7e9c04a3b555e5f533deb36
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Aug 08 02:19:54 2017

Drop |background_task_runner| parameter from async snapshot.h methods.

TaskRunners being passed in were already all parallel anyways, so use
base::PostTask directly.

Intentionally not setting TaskPriority in TaskTraits as the default is
to inherit priority from the caller's context.

Cleans up one more GetBlockingPool() callsite.

Bug: 667892
Change-Id: Ic1a919945496a6bc49579ef684b810112d7960bf
Reviewed-on: https://chromium-review.googlesource.com/600531
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492506}
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/android/feedback/screenshot_task.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/policy/remote_commands/device_commands_factory_chromeos.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/media/webrtc/desktop_media_list_ash.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/media/webrtc/desktop_media_list_ash.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/chrome/browser/ui/ash/chrome_screenshot_grabber.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/screenshot_grabber.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/screenshot_grabber.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_android.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_async.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_async.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_aura.cc
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_aura.h
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_ios.mm
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_mac.mm
[modify] https://crrev.com/2dc920595a7cfd76b7e9c04a3b555e5f533deb36/ui/snapshot/snapshot_win.cc

Project Member

Comment 397 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a45b3bcf80fd46340c84188ce1f2d00272717fe6

commit a45b3bcf80fd46340c84188ce1f2d00272717fe6
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Aug 09 00:25:01 2017

Migrate FILE WebThread getter to new Task Runner API

Bug: 667892
Change-Id: Ie91699d5b921213e3606b2a81225d5a96ecc415a
Reviewed-on: https://chromium-review.googlesource.com/596496
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492787}
[modify] https://crrev.com/a45b3bcf80fd46340c84188ce1f2d00272717fe6/ios/web_view/internal/web_view_browser_state.mm
[modify] https://crrev.com/a45b3bcf80fd46340c84188ce1f2d00272717fe6/ios/web_view/internal/web_view_url_request_context_getter.h
[modify] https://crrev.com/a45b3bcf80fd46340c84188ce1f2d00272717fe6/ios/web_view/internal/web_view_url_request_context_getter.mm

Project Member

Comment 398 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5200820217b0c78c18f880fe6b355c393b65faa8

commit 5200820217b0c78c18f880fe6b355c393b65faa8
Author: Brad Nelson <bradnelson@chromium.org>
Date: Thu Aug 10 14:58:12 2017

Remove another GetBlockingPool use in nacl.

BUG=667892
R=bbudge@chromium.org,gab@chromium.org

Change-Id: I589b1ad14e14bfdf6824a14bc9ed8aa83662cd83
Reviewed-on: https://chromium-review.googlesource.com/609452
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493388}
[modify] https://crrev.com/5200820217b0c78c18f880fe6b355c393b65faa8/components/nacl/browser/nacl_process_host.cc

Project Member

Comment 399 by bugdroid1@chromium.org, Aug 10 2017

Project Member

Comment 400 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/872e0455c73e3f4eac4cc89565611dae57683715

commit 872e0455c73e3f4eac4cc89565611dae57683715
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Aug 11 15:40:32 2017

Migrate FILE WebThread getter to new Task Runner API

Bug: 667892
Change-Id: I3bc66e50af4df14bb9a371d2e586e1c8c9a8daf1
Reviewed-on: https://chromium-review.googlesource.com/609304
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493754}
[modify] https://crrev.com/872e0455c73e3f4eac4cc89565611dae57683715/ios/web/shell/shell_browser_state.mm
[modify] https://crrev.com/872e0455c73e3f4eac4cc89565611dae57683715/ios/web/shell/shell_url_request_context_getter.h
[modify] https://crrev.com/872e0455c73e3f4eac4cc89565611dae57683715/ios/web/shell/shell_url_request_context_getter.mm

Project Member

Comment 401 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d

commit 2ec9112c3d6a882d931af30a21ab71d26c0bfa5d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Aug 22 16:11:02 2017

Remove uses of GetBlockingPool() from ios/.

This is the ios/ mirror to http://crrev.com/c/575229.

Using NOPRESUBMIT as I move the use of ScopedAllowIO around while
merging two functions and this confuse the presubmit check.

NOPRESUBMIT=true

Bug: 667892
Change-Id: I813b7ea5d3a673ce242644173f870e5faa3977eb
Reviewed-on: https://chromium-review.googlesource.com/618929
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496319}
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/app/application_delegate/url_opener_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state.h
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state_impl.cc
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state_impl.h
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ios_chrome_main_parts.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/browser_list/BUILD.gn
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/browser_list/browser_list_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/coordinators/BUILD.gn
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller_unittest.mm
[modify] https://crrev.com/2ec9112c3d6a882d931af30a21ab71d26c0bfa5d/ios/web_view/internal/web_view_browser_state.mm

Project Member

Comment 402 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12a3c050364b533c9683973fac7d0bc5d082450e

commit 12a3c050364b533c9683973fac7d0bc5d082450e
Author: Ben Wells <benwells@chromium.org>
Date: Tue Aug 22 22:25:19 2017

Remove FILE thread usage from extensions file handlers API.

Bug: 667892
Change-Id: Ibe58ddb8fbb688cc4103604b379552463c0ea926
Reviewed-on: https://chromium-review.googlesource.com/625544
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496473}
[modify] https://crrev.com/12a3c050364b533c9683973fac7d0bc5d082450e/extensions/browser/api/file_handlers/app_file_handler_util.cc

Project Member

Comment 403 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19d407699e8401d5665ec341b79d094533b96eca

commit 19d407699e8401d5665ec341b79d094533b96eca
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Sep 06 15:28:37 2017

Migrate BattOrConnectionImpl to new task running architecture

The unit tests already use TestMockTimeTaskRunner, which is compliant
with the new architecture.

Bug: 761498, 667892
Change-Id: I9230055fe2636d3690c88fe961713736e179981b
Reviewed-on: https://chromium-review.googlesource.com/652508
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499967}
[modify] https://crrev.com/19d407699e8401d5665ec341b79d094533b96eca/tools/battor_agent/battor_connection_impl.cc

Project Member

Comment 406 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80f11cb5a7b81f93ce4ac2e15651c71803555a68

commit 80f11cb5a7b81f93ce4ac2e15651c71803555a68
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Sep 12 14:15:51 2017

Remove the blocking pool from the service process.

The blocking pool is deprecated.

The only remaining user was the ServiceProcessPrefs' JsonPrefStore,
which now uses TaskScheduler instead.

Bug: 667892
Change-Id: Ic4739018ff111b7886bbc186e50f40408a8d9367
Reviewed-on: https://chromium-review.googlesource.com/660677
Reviewed-by: Gene Gutnik <gene@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501264}
[modify] https://crrev.com/80f11cb5a7b81f93ce4ac2e15651c71803555a68/chrome/service/service_process.cc
[modify] https://crrev.com/80f11cb5a7b81f93ce4ac2e15651c71803555a68/chrome/service/service_process.h

Project Member

Comment 407 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af186af41565fb0e0d0046ffa01ea3419c1dc13d

commit af186af41565fb0e0d0046ffa01ea3419c1dc13d
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Sep 12 22:14:27 2017

Migrate VisitedLinkMaster off of BlockingPool

R=sky@chromium.org

Bug: 667892
Change-Id: Ia354d4cc615983d0ac6650a98a70903484e5ecb8
Reviewed-on: https://chromium-review.googlesource.com/657807
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501424}
[modify] https://crrev.com/af186af41565fb0e0d0046ffa01ea3419c1dc13d/components/visitedlink/browser/visitedlink_master.cc
[modify] https://crrev.com/af186af41565fb0e0d0046ffa01ea3419c1dc13d/components/visitedlink/browser/visitedlink_master.h

Project Member

Comment 409 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea953e3646ddca6880f95eef9c65e1962e50120

commit 4ea953e3646ddca6880f95eef9c65e1962e50120
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Sep 13 13:15:19 2017

Migrate ContentHashFetcher off of BlockingPool

R=rdevlin.cronin@chromium.org

Bug: 667892
Change-Id: I21df3c5a2eac7d6a5d2b1a3bc0322d752baca286
Reviewed-on: https://chromium-review.googlesource.com/663767
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501607}
[modify] https://crrev.com/4ea953e3646ddca6880f95eef9c65e1962e50120/extensions/browser/content_hash_fetcher.cc

Project Member

Comment 410 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e6bf933b7a02d6f7194483883d1c331890ddf91

commit 5e6bf933b7a02d6f7194483883d1c331890ddf91
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Sep 13 14:06:13 2017

Migrate ManagedValueStoreCache off of BlockingPool.

R=rdevlin.cronin@chromium.org

Bug: 667892
Change-Id: I56f8529830ea5ec8e0684088448b99bc5b29a31d
Reviewed-on: https://chromium-review.googlesource.com/664300
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501619}
[modify] https://crrev.com/5e6bf933b7a02d6f7194483883d1c331890ddf91/chrome/browser/extensions/api/storage/managed_value_store_cache.cc

Project Member

Comment 411 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe54b346e4538fccaedabebbfeffa1d0f157ad0

commit ebe54b346e4538fccaedabebbfeffa1d0f157ad0
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Sep 13 16:36:54 2017

Migrate the BattOr agent to use sequences instead of thread affinity

This is part of a larger migration described here: http://bit.ly/2jr4bIn

Bug: 667892, 761498
Change-Id: I459de60aedc4ad6bd1cf08177690229644eb1037
Reviewed-on: https://chromium-review.googlesource.com/665164
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501660}
[modify] https://crrev.com/ebe54b346e4538fccaedabebbfeffa1d0f157ad0/tools/battor_agent/battor_agent.cc
[modify] https://crrev.com/ebe54b346e4538fccaedabebbfeffa1d0f157ad0/tools/battor_agent/battor_agent.h

Project Member

Comment 412 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e

commit 8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Sep 13 19:58:42 2017

Migrate nacl off of deprecated BlockingPool

These are the very last calls in the codebase!

R=bradnelson@chromium.org

Bug: 667892
Change-Id: Ifd44215b9df0b47af2c83e64646d4a794df2222c
Reviewed-on: https://chromium-review.googlesource.com/663887
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501720}
[modify] https://crrev.com/8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e/components/nacl/browser/nacl_browser.cc
[modify] https://crrev.com/8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e/components/nacl/browser/nacl_browser.h
[modify] https://crrev.com/8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e/components/nacl/browser/pnacl_host.cc
[modify] https://crrev.com/8ff28f47ca8e31bf7bdf4651ad2eca9a3f48824e/components/nacl/browser/pnacl_host.h

Project Member

Comment 413 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e0a375eb4fbd011befa0bba5956b2488de32e8

commit a1e0a375eb4fbd011befa0bba5956b2488de32e8
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Sep 14 18:48:21 2017

Remove now unused BrowserThread's BlockingPool!!!

Bug: 667892
Change-Id: I98f41c80f6f7e041db2fa3713d531ce8db9932ec
Reviewed-on: https://chromium-review.googlesource.com/664219
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502004}
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/PRESUBMIT.py
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/browser/browser_thread_impl.h
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/public/browser/browser_thread.h
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/public/test/test_browser_thread_bundle.cc
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/public/test/test_browser_thread_bundle.h
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/public/test/test_utils.cc
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/content/public/test/test_utils.h
[modify] https://crrev.com/a1e0a375eb4fbd011befa0bba5956b2488de32e8/docs/threading_and_tasks.md

Project Member

Comment 414 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b6932663ad4a39622231cf8a25b53fe215a4c9

commit 19b6932663ad4a39622231cf8a25b53fe215a4c9
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Sep 14 22:42:48 2017

Migrate the PowerTracingAgent away from using BrowserThread::FILE

This is part of a broader migration (see http://bit.ly/2f8ookS), after
which BrowserThread::FILE will be no more.

Bug: 761496, 667892
Change-Id: I7a6542091a86e6e84b0f83dd799567232473a699
Reviewed-on: https://chromium-review.googlesource.com/665386
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502054}
[modify] https://crrev.com/19b6932663ad4a39622231cf8a25b53fe215a4c9/content/browser/tracing/power_tracing_agent.cc
[modify] https://crrev.com/19b6932663ad4a39622231cf8a25b53fe215a4c9/content/browser/tracing/power_tracing_agent.h

Project Member

Comment 416 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01507a2a20c4d6acfc4338b1caf1763a95a29b99

commit 01507a2a20c4d6acfc4338b1caf1763a95a29b99
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Sep 27 21:30:08 2017

Mass rename RunAllBlockingPoolTasksUntilIdle to RunAllTasksUntilIdle in content::

TBR=jam@chromium.org

Bug: 667892
Change-Id: I9c0900c171e9fd808e34c6db85e3e0633e8de14e
Reviewed-on: https://chromium-review.googlesource.com/687755
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504775}
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/drive/download_handler_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/drive/write_on_cache_file_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/extensions/external_cache_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/file_manager/fileapi_util_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/preferences_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/settings/device_settings_test_helper.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/download/download_path_reservation_tracker_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/engagement/important_sites_usage_counter_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/events_apitest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_disabled_ui_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_garbage_collector_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_service_test_with_install.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/extension_user_script_loader_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/extensions/user_script_listener_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/net/file_downloader_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/notifications/notification_channels_provider_android_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/loading_data_collector_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/loading_predictor_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/loading_stats_collector_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/prerender/prerender_resource_throttle_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/profile_resetter/profile_resetter_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/safe_browsing/download_protection/download_feedback_service_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/safe_browsing/download_protection/download_feedback_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/search_engines/template_url_service_factory_test_util.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/sessions/session_service_test_helper.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/sync/test/integration/printers_helper.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/views/frame/test_with_browser_view.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/chromeos/drive_test_util.h
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/copy_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/create_directory_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/create_file_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/download_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/get_file_for_saving_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/move_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/open_file_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/operation_test_base.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/remove_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/search_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/set_property_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/touch_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system/truncate_operation_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/file_system_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/sync/entry_revert_performer_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/sync/entry_update_performer_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/drive/sync/remove_performer_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/nacl/browser/pnacl_host_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/storage_monitor/storage_monitor_win_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/visitedlink/test/visitedlink_perftest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/components/visitedlink/test/visitedlink_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/blob_storage/blob_storage_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/indexed_db/indexed_db_quota_client_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/loader/temporary_file_stream_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/public/test/download_test_observer.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/public/test/test_browser_thread_bundle.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/public/test/test_browser_thread_bundle.h
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/public/test/test_utils.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/content/public/test/test_utils.h
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/docs/task_scheduler_migration.md
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/extensions/browser/api/file_handlers/directory_util_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/extensions/browser/api/file_handlers/mime_util_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/extensions/browser/api/storage/storage_frontend_unittest.cc
[modify] https://crrev.com/01507a2a20c4d6acfc4338b1caf1763a95a29b99/extensions/browser/value_store/value_store_frontend_unittest.cc

Project Member

Comment 417 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30abaff35cfa985f0eafaf4d00f171281db971a0

commit 30abaff35cfa985f0eafaf4d00f171281db971a0
Author: Francois Doray <fdoray@chromium.org>
Date: Wed Jan 10 19:38:20 2018

Use TaskScheduler instead of SequencedWorkerPool in blockfile cache.

This CL migrates calls from SequencedWorkerPool to TaskScheduler in
the posix blockfile cache. The calls were already redirected to
TaskScheduler under the hood (via
EnableWithRedirectionToTaskSchedulerForProcess).

Bug: 667892
Change-Id: I8abdb3df6d0fc4b35ad96109c8af818828a4df79
Reviewed-on: https://chromium-review.googlesource.com/850754
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528385}
[modify] https://crrev.com/30abaff35cfa985f0eafaf4d00f171281db971a0/net/disk_cache/blockfile/file.h
[modify] https://crrev.com/30abaff35cfa985f0eafaf4d00f171281db971a0/net/disk_cache/blockfile/file_posix.cc

Project Member

Comment 418 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b92dc9ecb99652778099e3777d1c887ca76429ae

commit b92dc9ecb99652778099e3777d1c887ca76429ae
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jan 12 18:56:35 2018

Initialize BackgroundServiceManager at the test case level in views mus tests.

It was previously initialized at the test suite level, before
TaskScheduler initialization. That prevented adding calls to
base/task_scheduler/post_task.h in the BackgroundServiceManager
initialization code (see
https://chromium-review.googlesource.com/c/chromium/src/+/850736).

Bug: 667892
Change-Id: I94d1ded90d4cfdb11422813014ce9e13f4260c6e
Reviewed-on: https://chromium-review.googlesource.com/861201
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529009}
[modify] https://crrev.com/b92dc9ecb99652778099e3777d1c887ca76429ae/ui/views/mus/pointer_watcher_event_router_unittest.cc
[modify] https://crrev.com/b92dc9ecb99652778099e3777d1c887ca76429ae/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/b92dc9ecb99652778099e3777d1c887ca76429ae/ui/views/mus/views_mus_test_suite.h

Project Member

Comment 419 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b41fa047f7eeb4180273809e4c432753252053

commit e2b41fa047f7eeb4180273809e4c432753252053
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jan 12 19:46:02 2018

Migrate from SequencedWorkerPool to TaskScheduler in service_manager.

SequencedWorkerPool was deprecated in favor of TaskScheduler.

Bug: 667892
Change-Id: I2eceef51bee0ce0138a6c30a5c55df1db6228888
Reviewed-on: https://chromium-review.googlesource.com/850736
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529027}
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/background/tests/BUILD.gn
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/background/tests/background_service_manager_unittest.cc
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/runner/host/service_process_launcher.h
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/runner/host/service_process_launcher_unittest.cc
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/standalone/context.cc
[modify] https://crrev.com/e2b41fa047f7eeb4180273809e4c432753252053/services/service_manager/standalone/context.h

Project Member

Comment 420 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11072052528a411cc1f5f1f0035e37f9183278bc

commit 11072052528a411cc1f5f1f0035e37f9183278bc
Author: Francois Doray <fdoray@chromium.org>
Date: Mon Jan 15 14:49:05 2018

Remove JsonPrefStore::GetTaskRunnerForFile.

Bug: 667892
Change-Id: I07a16b512814e313be1628d93d3ceacdfb173bb2
Reviewed-on: https://chromium-review.googlesource.com/864839
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529278}
[modify] https://crrev.com/11072052528a411cc1f5f1f0035e37f9183278bc/components/prefs/json_pref_store.cc
[modify] https://crrev.com/11072052528a411cc1f5f1f0035e37f9183278bc/components/prefs/json_pref_store.h

Project Member

Comment 421 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4f92cc31ff0e1e598b8e023a40a0409a766a60

commit cb4f92cc31ff0e1e598b8e023a40a0409a766a60
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Jan 23 17:34:21 2018

Remove usage of SequencedWorkerPool in GN.

SequencedWorkerPool is deprecated. A process-wide TaskScheduler
must be used instead.

Bug: 667892
Change-Id: I67f5bafe5e5eaba3aeb40664dea7cdd7d4250b60
Reviewed-on: https://chromium-review.googlesource.com/879354
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531270}
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/BUILD.gn
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/action_target_generator_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/command_format_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/function_forward_variables_from_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/function_toolchain_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/function_write_file_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/functions_target_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/gn_main.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/header_checker.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/header_checker.h
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/header_checker_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/input_conversion_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/loader_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/ninja_binary_target_writer_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/ninja_build_writer_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/runtime_deps_unittest.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/scheduler.cc
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/scheduler.h
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/target.h
[modify] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/target_unittest.cc
[add] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/test_with_scheduler.cc
[add] https://crrev.com/cb4f92cc31ff0e1e598b8e023a40a0409a766a60/tools/gn/test_with_scheduler.h

Project Member

Comment 422 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a27abd29f967f530c620acd7ab302066ee205382

commit a27abd29f967f530c620acd7ab302066ee205382
Author: Robert Liao <robliao@chromium.org>
Date: Wed Jan 24 18:46:48 2018

Change Autofill Helper TaskScheduler::FlushForTesting() to Wait on TaskRunner tasks

base::TaskScheduler::GetInstance()->FlushForTesting() may have been too
big of a hammer to use here. I've moved this code back to a previous
style of waiting for the DB task runner to flush
(http://crrev.com/490312).

The main issue here is that FlushForTesting() often gets called on the
main thread, and with MessageLoop Task Scheduler redirection,
FlushForTesting will wait for MessageLoop tasks to complete. If a
MessageLoop task is waiting for the main thread to process a task and
the main thread is calling FlushForTesting(), a deadlock will occur.

If these components start using other task runners, a completion
callback mechanism will best support this file going forward.

BUG=667892,749310

Change-Id: I0693bf7a00b25be9a95e2bae89ec3b4167ba4d4a
Reviewed-on: https://chromium-review.googlesource.com/874817
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531624}
[modify] https://crrev.com/a27abd29f967f530c620acd7ab302066ee205382/chrome/browser/sync/test/integration/autofill_helper.cc

Project Member

Comment 423 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d38ad404677dd8e71d9a0b4f6d143cfb6966ac

commit 23d38ad404677dd8e71d9a0b4f6d143cfb6966ac
Author: Francois Doray <fdoray@chromium.org>
Date: Wed Jan 24 21:38:01 2018

Remove usage of SequencedWorkerPool in ColorProfileReader.

Bug: 667892
Change-Id: I59ba41ab12c7a29a7011a7dc6bca16b0daa38895
Reviewed-on: https://chromium-review.googlesource.com/881582
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531686}
[modify] https://crrev.com/23d38ad404677dd8e71d9a0b4f6d143cfb6966ac/ui/display/win/color_profile_reader.cc

Comment 424 by w...@chromium.org, Jan 25 2018

Blocking: 805502
Project Member

Comment 425 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6c42954a1c032f68e54ede02b84da2e7efa9e46

commit b6c42954a1c032f68e54ede02b84da2e7efa9e46
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Jan 25 17:53:47 2018

Remove unused sequenced_worker_pool(_owner).h includes.

TBR=jochen@chromium.org

Bug: 667892
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If125f2f33081fb39184ad13594f187e8ec165148
Reviewed-on: https://chromium-review.googlesource.com/883767
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531935}
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ash/shell.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ash/test/ash_test_helper.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ash/window_manager_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/android/history_report/usage_reports_buffer_service.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/android/metrics/uma_session_stats.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/base/file_flusher_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/drive/write_on_cache_file.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/chromeos/settings/device_settings_test_helper.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/api/messaging/native_process_launcher.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/memory/memory_kills_monitor.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/prefs/profile_pref_store_manager_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/printing/print_job.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/supervised_user/supervised_user_settings_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/sync/test/integration/printers_helper.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/task_manager/sampling/shared_sampler_win_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/themes/theme_service_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/ash/ash_shell_init.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/webui/chromeos/image_source.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/chromecast/browser/pref_service_helper.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/crash/content/browser/crash_dump_observer_android.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/data_reduction_proxy/core/browser/data_usage_store.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/data_reduction_proxy/core/browser/db_data_owner.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/drive/file_system_core_util.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/favicon/core/large_icon_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/favicon/ios/web_favicon_driver.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/feedback/feedback_report.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/leveldb_proto/proto_database_impl.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/nacl/browser/nacl_file_host.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/nacl/browser/pnacl_host_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/prefs/json_pref_store_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/proximity_auth/bluetooth_util_chromeos.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/update_client/update_client.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/components/variations/service/variations_service.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/blob_storage/blob_storage_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/dom_storage/dom_storage_area_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/dom_storage/dom_storage_context_impl_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/dom_storage/dom_storage_message_filter.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/public/test/download_test_observer.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/content/public/test/test_utils.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/api/api_resource_manager.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/api/networking_private/networking_private_service_client.h
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/api/system_storage/storage_info_provider.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/content_hash_fetcher_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/extensions/components/native_app_window/native_app_window_views.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/payments/ios_payment_instrument_finder.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/suggestions/suggestions_service_factory.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/ui/first_run/first_run_util.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/net/url_request/url_request_file_job_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/services/preferences/pref_service_factory_unittest.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/services/preferences/pref_store_manager_impl.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/services/preferences/public/cpp/pref_service_main.cc
[modify] https://crrev.com/b6c42954a1c032f68e54ede02b84da2e7efa9e46/ui/snapshot/screenshot_grabber.cc

Project Member

Comment 426 by bugdroid1@chromium.org, Jan 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b

commit c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b
Author: Francois Doray <fdoray@chromium.org>
Date: Sun Jan 28 01:32:18 2018

Remove usage of SequencedWorkerPoolOwner.

Replace usage with ScopedTaskEnvironment.

TBR=glider@chromium.org

Bug: 667892
Change-Id: I93d25b143a39f8966d425d98954bec28c710857a
Reviewed-on: https://chromium-review.googlesource.com/881532
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532260}
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/ash/display/display_color_manager_chromeos_unittest.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/base/test/launcher/test_launcher.h
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/base/timer/timer_unittest.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/build/sanitizers/tsan_suppressions.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/chrome/browser/extensions/updater/local_extension_cache_unittest.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/components/browser_sync/profile_sync_test_util.h
[modify] https://crrev.com/c3b4d56a01fb89d9b290214a36beb2f1eafa5c5b/content/public/test/test_launcher.cc

Project Member

Comment 428 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4914ec14f5baf0bfdc7ca1733391358f60cec360

commit 4914ec14f5baf0bfdc7ca1733391358f60cec360
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Feb 22 12:48:38 2018

Remove SequencedWorkerPool.

TBR=dgozman@chromium.org

Bug: 667892
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f8284681c4e77b82b2337e8732b09231eef8b72
Reviewed-on: https://chromium-review.googlesource.com/881882
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538416}
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/BUILD.gn
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/sequence_checker_impl.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/sequence_checker_unittest.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/test/BUILD.gn
[delete] https://crrev.com/ec436e4b375c5c3cf8f02b5a69141654cc6b4834/base/test/sequenced_worker_pool_owner.cc
[delete] https://crrev.com/ec436e4b375c5c3cf8f02b5a69141654cc6b4834/base/test/sequenced_worker_pool_owner.h
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/test/test_suite.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/threading/sequenced_task_runner_handle.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/threading/sequenced_task_runner_handle.h
[delete] https://crrev.com/ec436e4b375c5c3cf8f02b5a69141654cc6b4834/base/threading/sequenced_worker_pool.cc
[delete] https://crrev.com/ec436e4b375c5c3cf8f02b5a69141654cc6b4834/base/threading/sequenced_worker_pool.h
[delete] https://crrev.com/ec436e4b375c5c3cf8f02b5a69141654cc6b4834/base/threading/sequenced_worker_pool_unittest.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/base/threading/thread_restrictions.h
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/chrome/service/service_process.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/content/browser/browser_main_loop.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/content/public/test/browser_test_base.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/ios/web/app/web_main_loop.mm
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/net/url_request/test_url_request_interceptor.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/services/service_manager/embedder/main.cc
[modify] https://crrev.com/4914ec14f5baf0bfdc7ca1733391358f60cec360/tools/metrics/histograms/histograms.xml

Project Member

Comment 429 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e771dfe452d108ab7172ddb8d03d51f540e0fa40

commit e771dfe452d108ab7172ddb8d03d51f540e0fa40
Author: glevin <glevin@chromium.org>
Date: Thu Feb 22 14:56:06 2018

Removal of unneeded task_runner arg from Quirks init

Bug: 667892
Test: None (code refactor; no observable change)

This is a small cleanup resulting from crbug.com/667892#c352.  Unlike the
blocking_pool it replaced, creating the task_runner in Quirks code doesn't
cause a dependency violation, so no need to pass it as an init argument.

Change-Id: I3226a659ebbfa795e894a16b8ba9c55021fff118
Reviewed-on: https://chromium-review.googlesource.com/930026
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538434}
[modify] https://crrev.com/e771dfe452d108ab7172ddb8d03d51f540e0fa40/ash/display/display_color_manager_chromeos_unittest.cc
[modify] https://crrev.com/e771dfe452d108ab7172ddb8d03d51f540e0fa40/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/e771dfe452d108ab7172ddb8d03d51f540e0fa40/components/quirks/quirks_manager.cc
[modify] https://crrev.com/e771dfe452d108ab7172ddb8d03d51f540e0fa40/components/quirks/quirks_manager.h

Status: Fixed (was: Started)
Blockedon: 873771
Showing comments 332 - 431 of 431 Older

Sign in to add a comment