New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667885 link

Starred by 2 users
Status: WontFix
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Verify correct parameters for opening Connection Help page

Project Member Reported by elawrence@chromium.org, Nov 22 2016 
https://chromium.googlesource.com/chromium/src.git/+/7ef72beedd573b8a81ad2f88e53f760c87bc34f1 was checked in to resolve  Issue 646465 .

I had questions about two of the parameters passed in the navigation call:

1. Does this end up sending Google the URL of the page on which the user asked for info on the connection? If so, is that desirable?

   webContents_->OpenURL(content::OpenURLParams(
   GURL(chrome::kPageInfoHelpCenterURL), content::Referrer(),
   WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK

2. Also, is there a reason to use PAGE_TRANSITION_LINK instead of e.g.  PAGE_TRANSITION_AUTO_TOPLEVEL?

Comment 1 by elawrence@chromium.org, Jan 4 2017 

I think my concern about #1 was misplaced; the content::Referrer() parameter ends up creating a blank referrer.

The ChromeAutofillClient::ShowHttpNotSecureExplanation() method uses the same parameters.

I'm still not sure what how PAGE_TRANSITION_LINK is vs. PAGE_TRANSITION_AUTO_TOPLEVEL but it looks like your current code is in good company.

Comment 2 by lgar...@chromium.org, Feb 10 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment