CrSettingsMainPageTest.All failing on basically all the bots |
||||||||||
Issue descriptionbrowser_side_navigation_browser_tests on Ubuntu-12.04 failing on chromium.linux/Linux Tests (dbg)(1) Type: build-failure Builders failed on: - Linux Tests (dbg)(1): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29 This test fails flakily on 3 targets (browser_tests, browser_side_navigation_browser_tests, site_per_process_browser_tests). It fails in 2 different ways (crash on teardown, JS errors): CrSettingsMainPageTest.All (run #1): [ RUN ] CrSettingsMainPageTest.All Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [21083:21083:1122/030703:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [21083:21083:1122/030703:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [21083:21083:1122/030703:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [1:1:1122/030705:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES [21083:21083:1122/030713:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-shadow-flex-layout-extracted.js (1) [21083:21083:1122/030713:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout-extracted.js (1) [21083:21083:1122/030716:INFO:CONSOLE(1209)] "Running TestCase CrSettingsMainPageTest.MAYBE_MainPage_All", source: test_api.js (1209) [21083:21083:1122/030717:WARNING:CONSOLE(126)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://md-settings/settings_main/settings_main.js (126) [21083:21083:1122/030744:INFO:CONSOLE(125)] "Page load time: 11410 ms", source: polymer_browser_test_base.js (125) [21083:21083:1122/030744:INFO:CONSOLE(127)] "Test run time: 27634 ms", source: polymer_browser_test_base.js (127) [21083:21083:1122/030744:INFO:CONSOLE(129)] "Total time: 39044 ms", source: polymer_browser_test_base.js (129) BrowserTestBase received signal: Terminated. Backtrace: #0 0x7f165209d79e base::debug::StackTrace::StackTrace() #1 0x000003831117 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f1639e500b0 <unknown> #3 0x7f165207a5b1 std::_Iter_base<>::_S_base() #4 0x7f165208e41d base::debug::ScopedLockAcquireActivity::ScopedLockAcquireActivity() #5 0x7f165221819d base::debug::ScopedLockAcquireActivity::ScopedLockAcquireActivity() #6 0x7f1652217f4f base::internal::LockImpl::Lock() #7 0x7f1652069493 base::Lock::Acquire() #8 0x7f1652069133 base::AutoLock::AutoLock() #9 0x7f16522866d4 base::ThreadCheckerImpl::CalledOnValidThread() #10 0x7f165226aa65 base::NonThreadSafeImpl::CalledOnValidThread() #11 0x7f164d43ff56 JsonPrefStore::IsInitializationComplete() #12 0x000005f2129c SegregatedPrefStore::IsInitializationComplete() #13 0x7f164d46974c PrefService::GetInitializationStatus() #14 0x000002a7a587 ProfileImpl::~ProfileImpl() #15 0x000002a7a839 ProfileImpl::~ProfileImpl() #16 0x0000030c5736 ProfileDestroyer::DestroyProfileWhenAppropriate() #17 0x000002abdd01 ProfileManager::ProfileInfo::~ProfileInfo() #18 0x0000026d47ae linked_ptr<>::depart() #19 0x0000026d4755 linked_ptr<>::~linked_ptr() #20 0x0000026d4723 std::pair<>::~pair() #21 0x0000026d46f9 std::_Rb_tree_node<>::~_Rb_tree_node() #22 0x0000026d46d9 __gnu_cxx::new_allocator<>::destroy() #23 0x0000026d46ac std::_Rb_tree<>::_M_destroy_node() #24 0x000002ac4118 std::_Rb_tree<>::_M_erase() #25 0x000002ac40a5 std::_Rb_tree<>::~_Rb_tree() #26 0x000002ac4075 std::__cxx1998::map<>::~map() #27 0x000002ac1e1f std::__debug::map<>::~map() #28 0x000002ab3c44 ProfileManager::~ProfileManager() #29 0x000002ab3cf9 ProfileManager::~ProfileManager() #30 0x00000082014f std::default_delete<>::operator()() #31 0x0000026c1aac std::unique_ptr<>::reset() #32 0x000003007e50 BrowserProcessImpl::StartTearDown() #33 0x00000336c4a1 ChromeBrowserMainParts::PostMainMessageLoopRun() #34 0x7f1649baccf8 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #35 0x7f1649bb8b03 content::BrowserMainRunnerImpl::Shutdown() #36 0x7f1649ba61a5 content::BrowserMain() #37 0x7f164b35e756 content::RunNamedProcessTypeMain() #38 0x7f164b360bd2 content::ContentMainRunnerImpl::Run() #39 0x7f164b35da42 content::ContentMain() #40 0x000003830b3b content::BrowserTestBase::SetUp() #41 0x0000027040b4 InProcessBrowserTest::SetUp() #42 0x000001058eae _ZN7testing8internal12InvokeHelperIvSt5tupleIJEEE12InvokeMethodI14ServiceProcessMS6_FvvEEEvPT_T0_RKS3_ #43 0x0000039d4402 testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x0000039c91f4 testing::Test::Run() #45 0x0000039c99fd testing::TestInfo::Run() #46 0x0000039c9f9f testing::TestCase::Run() #47 0x0000039cf2ec testing::internal::UnitTestImpl::RunAllTests() #48 0x0000010584de _ZN7testing8internal12InvokeHelperIbSt5tupleIJEEE12InvokeMethodI20MockServiceIPCServerMS6_FbvEEEbPT_T0_RKS3_ #49 0x0000039d5ad2 testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x0000039cef8f testing::UnitTest::Run() #51 0x000002717891 RUN_ALL_TESTS() #52 0x0000027167c2 base::TestSuite::Run() #53 0x0000026bdc60 ChromeTestSuiteRunner::RunTestSuite() #54 0x0000026bdd59 ChromeTestLauncherDelegate::RunTestSuite() #55 0x0000038b67d2 content::LaunchTests() #56 0x0000026be0e9 LaunchChromeTests() #57 0x0000026bdb85 main #58 0x7f1639e3b7ed __libc_start_main #59 0x000000794f35 <unknown> CrSettingsMainPageTest.All (run #2): [ RUN ] CrSettingsMainPageTest.All Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [29636:29636:1122/031117:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [29636:29636:1122/031117:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [29636:29636:1122/031118:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [1:1:1122/031119:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES [29636:29636:1122/031123:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-shadow-flex-layout-extracted.js (1) [29636:29636:1122/031123:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout-extracted.js (1) [29636:29636:1122/031126:INFO:CONSOLE(1209)] "Running TestCase CrSettingsMainPageTest.MAYBE_MainPage_All", source: test_api.js (1209) [29636:29636:1122/031126:WARNING:CONSOLE(126)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://md-settings/settings_main/settings_main.js (126) [29636:29636:1122/031139:ERROR:CONSOLE(48)] "Mocha test failed: MainPageTests exiting search mode, advanced expanded AssertionError: expected 'none' to equal '' at Function.assert.strictEqual (chai.js:2277:32) at assertEquals (test_api.js:893:17) at settings_main_test.js:165:11 ", source: mocha_adapter.js (48) [29636:29636:1122/031147:INFO:CONSOLE(125)] "Page load time: 6469 ms", source: polymer_browser_test_base.js (125) [29636:29636:1122/031147:INFO:CONSOLE(127)] "Test run time: 20993 ms", source: polymer_browser_test_base.js (127) [29636:29636:1122/031147:INFO:CONSOLE(129)] "Total time: 27462 ms", source: polymer_browser_test_base.js (129) [29636:29636:1122/031147:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/8 tests had failed assertions. [29636:29636:1122/031147:ERROR:web_ui_browser_test.cc(473)] CONDITION FAILURE: encountered javascript console error(s): [29636:29636:1122/031147:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[29636:29636:1122/031139:ERROR:CONSOLE(48)] "Mocha test failed: MainPageTests exiting search mode, advanced expanded AssertionError: expected 'none' to equal '' at Function.assert.strictEqual (chai.js:2277:32) at assertEquals (test_api.js:893:17) at settings_main_test.js:165:11 ", source: mocha_adapter.js (48) ' [29636:29636:1122/031147:ERROR:web_ui_browser_test.cc(477)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc:1186: Failure Value of: RunJavascriptTestF( true, "CrSettingsMainPageTest", "MAYBE_MainPage_All") Actual: false Expected: true [29636:29636:1122/031147:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] CrSettingsMainPageTest.All, where TypeParam = and GetParam() = (30957 ms) First failing build: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/59002 . Nothing obvious in the logs. Before that it failed flakily in a different ways, e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/58993 CrSettingsMainPageTest.All (run #1): [ RUN ] CrSettingsMainPageTest.All Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [26009:26009:1121/181310:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [26009:26009:1121/181310:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [26009:26009:1121/181310:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [1:1:1121/181312:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES [26009:26009:1121/181320:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-shadow-flex-layout-extracted.js (1) [26009:26009:1121/181320:WARNING:CONSOLE(1)] "This file is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead", source: chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout-extracted.js (1) [26009:26009:1121/181323:INFO:CONSOLE(1209)] "Running TestCase CrSettingsMainPageTest.MAYBE_MainPage_All", source: test_api.js (1209) [26009:26009:1121/181324:WARNING:CONSOLE(126)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://md-settings/settings_main/settings_main.js (126) BrowserTestBase received signal: Terminated. Backtrace: #0 0x7fcc1fab077e base::debug::StackTrace::StackTrace() #1 0x00000382fb57 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fcc078030b0 <unknown> #3 0x7fcc078b4993 __poll #4 0x7fcc0a342ff6 <unknown> #5 0x7fcc0a343124 g_main_context_iteration #6 0x7fcc1fb6086f base::MessagePumpGlib::Run() #7 0x7fcc1fb4799a base::MessageLoop::RunHandler() #8 0x7fcc1fbf0414 base::RunLoop::Run() #9 0x0000038c31e3 content::RunThisRunLoop() #10 0x0000038c316a content::RunMessageLoop() #11 0x000001355e25 WebUITestHandler::WaitForResult() #12 0x000001355aca WebUITestHandler::RunJavaScriptTestWithResult() #13 0x000001464e9e WebUIBrowserTest::RunJavascriptUsingHandler() #14 0x000001465414 WebUIBrowserTest::RunJavascriptAsyncTest() #15 0x00000146532d WebUIBrowserTest::RunJavascriptTestF() #16 0x0000016c05d0 CrSettingsMainPageTest_All_Test::RunTestOnMainThread() #17 0x0000027042c8 InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x00000382f873 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x0000008392f5 _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_ #20 0x000000839211 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #21 0x000003830967 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #22 0x0000038308ac _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x00000081f59b base::internal::RunMixin<>::Run() #24 0x000003369433 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x000003367e30 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x7fcc175cf171 content::BrowserMainLoop::PreMainMessageLoopRun() #27 0x7fcc16c01f15 _ZN4base8internal13FunctorTraitsIMN7content22IndexedDBCallbacksImpl13InternalStateEFvvEvE6InvokeIPS4_JEEEvS6_OT_DpOT0_ #28 0x7fcc175d7651 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #29 0x7fcc175d75f7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #30 0x7fcc175d753c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #31 0x7fcc16aef20b base::internal::RunMixin<>::Run() #32 0x7fcc1818210b content::StartupTaskRunner::RunAllTasksNow() #33 0x7fcc175ccf70 content::BrowserMainLoop::CreateStartupTasks() #34 0x7fcc175db25d content::BrowserMainRunnerImpl::Initialize() #35 0x7fcc175c91bf content::BrowserMain() #36 0x7fcc18d82006 content::RunNamedProcessTypeMain() #37 0x7fcc18d84482 content::ContentMainRunnerImpl::Run() #38 0x7fcc18d812f2 content::ContentMain() #39 0x00000382f57b content::BrowserTestBase::SetUp() #40 0x000002702b14 InProcessBrowserTest::SetUp() #41 0x000001058bde _ZN7testing8internal12InvokeHelperIvSt5tupleIJEEE12InvokeMethodI14ServiceProcessMS6_FvvEEEvPT_T0_RKS3_ #42 0x0000039d2e42 testing::internal::HandleExceptionsInMethodIfSupported<>() #43 0x0000039c7c34 testing::Test::Run() #44 0x0000039c843d testing::TestInfo::Run() #45 0x0000039c89df testing::TestCase::Run() #46 0x0000039cdd2c testing::internal::UnitTestImpl::RunAllTests() #47 0x00000105820e _ZN7testing8internal12InvokeHelperIbSt5tupleIJEEE12InvokeMethodI20MockServiceIPCServerMS6_FbvEEEbPT_T0_RKS3_ #48 0x0000039d4512 testing::internal::HandleExceptionsInMethodIfSupported<>() #49 0x0000039cd9cf testing::UnitTest::Run() #50 0x0000027162f1 RUN_ALL_TESTS() #51 0x000002715222 base::TestSuite::Run() #52 0x0000026bc6c0 ChromeTestSuiteRunner::RunTestSuite() #53 0x0000026bc7b9 ChromeTestLauncherDelegate::RunTestSuite() #54 0x0000038b5212 content::LaunchTests() #55 0x0000026bcb49 LaunchChromeTests() #56 0x0000026bc5e5 main #57 0x7fcc077ee7ed __libc_start_main #58 0x000000794c65 <unknown>
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66c57201b6ab1cef64d02a80b782feecc24913f1 commit 66c57201b6ab1cef64d02a80b782feecc24913f1 Author: piman <piman@chromium.org> Date: Tue Nov 22 20:54:22 2016 Disable CrSettingsMainPageTest.All on Linux (flaky) BUG= 667882 TBR=dpapad@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2521823005 Cr-Commit-Position: refs/heads/master@{#433970} [modify] https://crrev.com/66c57201b6ab1cef64d02a80b782feecc24913f1/chrome/test/data/webui/settings/cr_settings_browsertest.js
,
Nov 22 2016
,
Nov 22 2016
,
Dec 17 2016
Issue 675233 has been merged into this issue.
,
Dec 17 2016
,
Dec 20 2016
FWIW, I've been trying to reproduce the flakiness (in order to fix it). Unsuccessful so far (on Linux). Trying Mac shortly.
,
Jan 10 2017
,
Jan 11 2017
,
Apr 27 2017
,
May 3 2017
A lot has changed since these tests were disabled. I'm fixing the tests and will re-enable this and keep an eye on the results.
,
May 4 2017
,
May 4 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1510abbfe7ba6d200cfcc0f461c5a38c761fa353 commit 1510abbfe7ba6d200cfcc0f461c5a38c761fa353 Author: dpapad <dpapad@chromium.org> Date: Mon May 08 21:07:59 2017 MD Settings: Fix and re-enable settings-main tests. - Updated cases where the code had rotten (for example functions that used to return synchronously now return a Promise). - Updated test logic where Polymer.dom.flush() was not sufficient anymore, to use a MutationObserer (for detecting visibility changes). - Re-enable tests an all platforms, for non-debug builds. Debug builds remain disabled. The tests still use the real chrome.settingsPrivate API, which makes it likely that they could flake (timeout). Will address that if it happens. BUG= 667882 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2863213002 Cr-Commit-Position: refs/heads/master@{#470123} [modify] https://crrev.com/1510abbfe7ba6d200cfcc0f461c5a38c761fa353/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/1510abbfe7ba6d200cfcc0f461c5a38c761fa353/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/1510abbfe7ba6d200cfcc0f461c5a38c761fa353/chrome/test/data/webui/settings/settings_main_test.js [modify] https://crrev.com/1510abbfe7ba6d200cfcc0f461c5a38c761fa353/chrome/test/data/webui/settings/test_util.js
,
May 10 2017
@michaelpg: I see same flakes for the newly re-enabled tests, see [1]. Do you think that splitting the tests to different GTest test cases similar to what you are doing at [2] would help (essentially giving a larger timeout for each test)? [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsMainPageTest.MainPage_All [2] https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cr_settings_browsertest.js?l=1315,1319,1323,1327
,
May 10 2017
Example failure:
[14032:14032:0510/100056.443173:INFO:CONSOLE(1221)] "Running TestCase CrSettingsMainPageTest.MAYBE_MainPage_All", source: test_api.js (1221)
[14032:14032:0510/100234.171967:ERROR:CONSOLE(48)] "Mocha test failed: MainPageTests exiting search mode, advanced expanded
AssertionError: expected 'none' to equal 'block'
at Function.assert.strictEqual (chai.js:2277:32)
at assertEquals (test_api.js:893:17)
at assertPageVisibility (settings_main_test.js:177:9)
at settings_main_test.js:207:18
at <anonymous>
Given that the test fails in some cases, it does not just time out, it seems that the source of flakiness has not been fully fixed. I'll keep investigating, trying to repro the flakiness locally.
,
Jul 11 2017
Don't see any recent flakes at https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsMainPageTest.MainPage. Closing. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by piman@chromium.org
, Nov 22 2016