New issue
Advanced search Search tips

Issue 667874 link

Starred by 1 user
Status: Fixed
Owner:
bajones@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

WebVR sample page doesn't support WebVR

Project Member Reported by vsupruniuk@google.com, Nov 22 2016 
Version:Chrome Canary 57.0.2926.0
OS: Android 7.1
Test device: Pixel

Reproduction steps:
1. Make sure "WebVR" is not enabled on chrome://flags
2. Access https://webvr.info/samples/00-hello-webvr.html on the test device

Expected result:
Debug info with WebVR stats should be displayed

Actual result:
Error notification appears: "Your browser doesn't support WebVR."

Comment 1 by amp@chromium.org, Nov 22 2016 

What do you mean by 'not enabled'?

The origin trial is kind of like a per site runtime flag.

If you manually set the flag to 'disabled' for WebVR on chrome://flags that will take precedence over any origin trial.

If you have the flag set to 'Default' and still see this that would be a bug.

Comment 2 by vsupruniuk@google.com, Nov 22 2016 

I don't know how to set this flag to 'Default', when I go to chrome://flags I can only 'Enable' WebVR or "Disable' if it's enabled. By 'not enabled' I mean go to chrome://flags and make sure "Enable" option is available for WebVR flags.

Comment 3 by bsheedy@chromium.org, Nov 22 2016 

There is no "Default" option in chrome://flags for WebVR, only Enable/Disable. With it disabled, other samples still work, e.g. https://webvr.info/samples/03-vr-presentation.html. However, I tried reproducing this on a Pixel XL, and I am unable to. https://webvr.info/samples/00-hello-webvr.html seems to work properly with the flag disabled (and thus, using the origin trial)

Comment 4 by amp@chromium.org, Nov 22 2016

Owner: bajones@chromium.org
Status: Assigned (was: Untriaged)
Ah, it looks like I was mistaken about the origin trial.  Apparently it takes precedent (I forgot that we didn't have a default state for WebVR, I'm not sure if that impacts it).

Anyway I just repro'ed this on my Pixel and the same canary version.  @bsheedy I'm not sure why you don't see it on your Pixel XL, it should be failing for all devices.

It looks like the problem is that the origin trial token is missing from the 00-hello-webvr.html file (it should be a meta tag in the <head>).

Looking at the change that added the token to all the others the change does indeed not include the 00-hello-webvr file: https://github.com/toji/webvr.info/commit/aaa495c66671da84658dc38409ff1c2da7c376c8

Assigning to Brandon to update (but I don't think it's time critical).

Comment 5 by bajones@chromium.org, Nov 28 2016

Status: Fixed (was: Assigned)
Seems like I had made the change locally but it hadn't gotten saved/comitted? Was picked up in a later commit, so this should work now.

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment