Signout button has no icon on lock screen |
||||||||||||
Issue descriptionGoogle Chrome 57.0.2926.0 (Official Build) dev (64-bit) Revision 0 Platform 9011.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Search + L to show lock screen 2. Observe Sign-out button What happens instead? Sign-out button has no icon as shown in specs. Attached specs and screenshot.
,
Nov 22 2016
sgabriel@, Could you share the mocks for the sign out button?
,
Nov 22 2016
Specs are here: https://drive.google.com/drive/folders/0B6x6iYCtKinET21nYnVnUWJEcUk?usp=sharing Assets is attached.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ce15669e0917b7d72d2d36d40462009b296b3d4 commit 7ce15669e0917b7d72d2d36d40462009b296b3d4 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Wed Nov 30 21:25:16 2016 update signout icon and more_settings icon on the md shelf BUG= 667868 TEST=Manually tested on signin screen and lock screen. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2529433004 Cr-Commit-Position: refs/heads/master@{#435420} [delete] https://crrev.com/b7048f096092bcb293216921c35df413258dbd57/chrome/app/theme/default_100_percent/cros/icon_more_vert_white.png [delete] https://crrev.com/b7048f096092bcb293216921c35df413258dbd57/chrome/app/theme/default_200_percent/cros/icon_more_vert_white.png [modify] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/header_bar.css [modify] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/header_bar.html [add] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/images/1x/more-settings.svg [add] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/images/1x/signout.svg [add] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/images/2x/more-settings.svg [add] https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4/chrome/browser/resources/chromeos/login/images/2x/signout.svg
,
Dec 1 2016
,
Dec 1 2016
,
Dec 1 2016
,
Dec 1 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
It's been merged to M56, see https://chromium.googlesource.com/chromium/src/+/8f1ae4fb772d4f50336b0e9a556bba5ad6e4a8ac But this bug didn't pick up the information here.
,
Dec 2 2016
,
Dec 5 2016
Verified on ChromeOS 9000.18.0, 56.0.2924.17 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tdander...@chromium.org
, Nov 22 2016Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)