Issue metadata
Sign in to add a comment
|
Accessibility: Video Controls hide too fast to be accessible via TalkBack |
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.90 Safari/537.36 Example URL: https://output.jsbin.com/woqazehapo/quiet Steps to reproduce the problem: 1. Setup TalkBack 2. Go to https://output.jsbin.com/woqazehapo/quiet 3. Try to unmute the video. Notice that the controls disappear so quickly, one has no chance to get to the unmute button before they are gone. What is the expected behavior? Video controls should always be accessible to screen readers regardless of their visibility What went wrong? Video Controls hide too fast to be accessible via TalkBack Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 54.0.2840.90 Channel: n/a OS Version: Flash Version: Shockwave Flash 23.0 r0
,
Nov 22 2016
,
Nov 25 2016
Tried testing this issue on Ubuntu 14.04 using chrome stable #54.0.2840.100. The tool used in this case is chromeVox extension. I was unable to get any talkback related tool from accessibility of Ubuntu 14.04 and also i was unable to unmute the video at URL: https://output.jsbin.com/woqazehapo/quiet using chromeVox extension. aghassemi@ - Could you please let us know the source to get the talkback tool? This will help us in triaging the issue further. Thanks...!!
,
Nov 28 2016
TalkBack is the stock Screen Reader on Android (Settings->Accessibility). I do not believe there is desktop or emulator version of it. The issue here is that the UI controls for the HTML5 video player hide after a second or two and become inaccessible by screen-readers. Please also note that TalkBack and VoiceOver (iOS stock screenreader) behave very differently when it comes to activating buttons/links than desktop SRs like ChromeVox or JAWS. For instance the common approach of putting DOM elements off-screen (e.g. left:-10000px, top:-10000px) does not work for buttons/links with TalkBack as TalkBack is unable to "click" off-screen buttons.
,
Dec 5 2016
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
,
Dec 27 2016
aghassemi@ - As per comment #4, is it possible to check this issue on any HTML5 video player? Is there any tool apart from talkbalk (as it is specific to android) to check this issue? Thanks...!!
,
Jan 3 2017
well, desktop Chrome displays the Controls when user tabs to them, so this may not be an issue with desktop screen-readers. With mobile Chrome, the controls are not displayed when the accessibility focus is moved to the element (a11y focus != DOM focus), so this becomes a big issue on mobile.
,
Jan 11 2017
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 20 2017
As per comment #8, this issue seems to be related to android. Could anyone from android team plz have a look into this issue.
,
Mar 6 2017
,
Mar 7 2017
,
Mar 27 2017
,
Mar 31 2017
Accessibility: Video Controls hide too fast due to that reason user can't know where the control bar is located. User need to double tap below the video screen to see the controls and then Immediately double click on unmute button to unmute the video. Here we observe one more issue after some time of video play it stop playing the video. This issue also repro on latest M58 chrome apk. Expected results: the video control bar should be visible to user to control the video. Tested on Pixel XL / NOF27B Please find the logcat, bugreport & video @ http://go/chrome-androidlogs1/7/667833 dmazzoni@ Could you please look into once. Thanks
,
Apr 18 2017
,
Apr 21 2017
,
Apr 21 2017
,
Aug 7 2017
,
Aug 7 2017
qinmin@ can you please provide an update?
,
Aug 7 2017
,
Aug 7 2017
I no longer work on video, reassigning to liberato@
,
Aug 7 2017
over to mlamouri@, who handles media ux these days.
,
Apr 6 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5439425dd127207c2fec3f358d1f329428d0b71 commit a5439425dd127207c2fec3f358d1f329428d0b71 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Wed Apr 11 05:29:15 2018 Media Controls: allow navigation with accessibility tools. The media controls auto-hide mechanism breaks accessibility tools. This prevents the controls from fully hiding when navigated with accessibility tools. Instead of marking themselves as `display:none;`, this only mark the controls as hidden and will show them again if the user navigates trough them again. Similar to using a mouse. Bug: 667833 Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd Reviewed-on: https://chromium-review.googlesource.com/999637 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549774} [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.cc [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.h [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/a5439425dd127207c2fec3f358d1f329428d0b71/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f4ec64291d1c7057dcd91b07f9f77a118dacda commit 30f4ec64291d1c7057dcd91b07f9f77a118dacda Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Apr 11 06:48:08 2018 Revert "Media Controls: allow navigation with accessibility tools." This reverts commit a5439425dd127207c2fec3f358d1f329428d0b71. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 549774 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E1NDM5NDI1ZGQxMjcyMDdjMmZlYzNmMzU4ZDFmMzI5NDI4ZDBiNzEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/36918 Sample Failed Step: webkit_unit_tests Original change's description: > Media Controls: allow navigation with accessibility tools. > > The media controls auto-hide mechanism breaks accessibility tools. This > prevents the controls from fully hiding when navigated with > accessibility tools. Instead of marking themselves as `display:none;`, > this only mark the controls as hidden and will show them again if the > user navigates trough them again. Similar to using a mouse. > > Bug: 667833 > Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd > Reviewed-on: https://chromium-review.googlesource.com/999637 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549774} Change-Id: I24ff5ad8f2320562ad566b944d0126b8d2cf0c21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 667833 Reviewed-on: https://chromium-review.googlesource.com/1006535 Cr-Commit-Position: refs/heads/master@{#549795} [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.cc [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.h [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/30f4ec64291d1c7057dcd91b07f9f77a118dacda/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32bb93471e5b7e8f7ca85590ee54991d40a8a82 commit c32bb93471e5b7e8f7ca85590ee54991d40a8a82 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Apr 12 08:13:03 2018 Reland "Media Controls: allow navigation with accessibility tools." This is a reland of a5439425dd127207c2fec3f358d1f329428d0b71 The CL failed after CQ because another CL that landed a couple of commits prior broke some assumptions made in the unit tests. Original change's description: > Media Controls: allow navigation with accessibility tools. > > The media controls auto-hide mechanism breaks accessibility tools. This > prevents the controls from fully hiding when navigated with > accessibility tools. Instead of marking themselves as `display:none;`, > this only mark the controls as hidden and will show them again if the > user navigates trough them again. Similar to using a mouse. > > Bug: 667833 > Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd > Reviewed-on: https://chromium-review.googlesource.com/999637 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549774} TBR=dmazzoni@chromium.org, pfeldman@chromium.org Bug: 667833 Change-Id: I03bbe4858d456a9131b257ca709f7d8728e712f7 Reviewed-on: https://chromium-review.googlesource.com/1007075 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550096} [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.cc [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.h [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/c32bb93471e5b7e8f7ca85590ee54991d40a8a82/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
,
Apr 12 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Nov 22 2016