Issue metadata
Sign in to add a comment
|
AX trees out of sync |
||||||||||||||||||||||
Issue descriptionThere some cases where a client and source ax tree become out of sync. For example, if the client toggles off and then back on, if there are multiple clients, etc. In the short term, whenever a client fails to serialize something, we will re-publish the tree to all clients (at least through automation); this is likely an issue on native as well though native api's likely handle this properly via platform specific ipc mechanisms. In the long term, we should possibly look into have multiple client trees on the source end (multiple ax tree serializers) per client.
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38c63d7344c76d9fa58c84db6112daebbfefd3ab commit 38c63d7344c76d9fa58c84db6112daebbfefd3ab Author: dtseng <dtseng@chromium.org> Date: Tue Nov 22 21:27:38 2016 Generalized fix for serialization error/reset issues Whenever we see an AX tree fail to unserialize, request it be reset on the source end. TEST=in hotrod, repeatedly toggle on/off ChromeVox. Verify that we re-populate the tree when we get any events (e.g. focus). BUG= 667819 Review-Url: https://codereview.chromium.org/2522033002 Cr-Commit-Position: refs/heads/master@{#433985} [modify] https://crrev.com/38c63d7344c76d9fa58c84db6112daebbfefd3ab/chrome/common/extensions/api/automation_internal.idl [modify] https://crrev.com/38c63d7344c76d9fa58c84db6112daebbfefd3ab/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/38c63d7344c76d9fa58c84db6112daebbfefd3ab/chrome/renderer/resources/extensions/automation_custom_bindings.js
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a316708a12944f6222b0bba88dfddc767ffe893f commit a316708a12944f6222b0bba88dfddc767ffe893f Author: David Tseng <dtseng@chromium.org> Date: Thu Dec 01 17:14:43 2016 Merge to m56: Generalized fix for serialization error/reset issues Whenever we see an AX tree fail to unserialize, request it be reset on the source end. TEST=in hotrod, repeatedly toggle on/off ChromeVox. Verify that we re-populate the tree when we get any events (e.g. focus). BUG= 667819 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2522033002 Cr-Commit-Position: refs/heads/master@{#433985} (cherry picked from commit 38c63d7344c76d9fa58c84db6112daebbfefd3ab) Review URL: https://codereview.chromium.org/2542943002 . Cr-Commit-Position: refs/branch-heads/2924@{#249} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/a316708a12944f6222b0bba88dfddc767ffe893f/chrome/common/extensions/api/automation_internal.idl [modify] https://crrev.com/a316708a12944f6222b0bba88dfddc767ffe893f/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/a316708a12944f6222b0bba88dfddc767ffe893f/chrome/renderer/resources/extensions/automation_custom_bindings.js
,
Dec 1 2016
,
Dec 1 2016
,
Dec 1 2016
Is this change applicable to any specific OS or all OSs?
,
Dec 1 2016
This will only impact Chrome OS. The code in this changed is not used on any other platform.
,
Dec 1 2016
,
Dec 2 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Dec 5 2016
If this is Chrome OS specific, and critical to the GVC use case, and it has been on ToT for a couple weeks now without incident, we can go ahead and merge it.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1abab3b6017f1e75d2cc6734c333238b6cb0c856 commit 1abab3b6017f1e75d2cc6734c333238b6cb0c856 Author: David Tseng <dtseng@chromium.org> Date: Tue Dec 06 22:34:23 2016 Merge to m55: Geneneralized fix for serialization error/reset issues Whenever we see an AX tree fail to unserialize, request it be reset on the source end. TEST=in hotrod, repeatedly toggle on/off ChromeVox. Verify that we re-populate the tree when we get any events (e.g. focus). BUG= 667819 Review-Url: https://codereview.chromium.org/2522033002 Cr-Commit-Position: refs/heads/master@{#433985} (cherry picked from commit 38c63d7344c76d9fa58c84db6112daebbfefd3ab) TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/2557923002 . Cr-Commit-Position: refs/branch-heads/2883@{#717} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1abab3b6017f1e75d2cc6734c333238b6cb0c856/chrome/common/extensions/api/automation_internal.idl [modify] https://crrev.com/1abab3b6017f1e75d2cc6734c333238b6cb0c856/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/1abab3b6017f1e75d2cc6734c333238b6cb0c856/chrome/renderer/resources/extensions/automation_custom_bindings.js
,
Dec 12 2016
,
Feb 3 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Nov 22 2016