New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667813 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 637967

Blocking:
issue 664494



Sign in to add a comment

Return code bisect message sounds like a perf regression

Project Member Reported by sullivan@chromium.org, Nov 22 2016

Issue description

Example:
https://bugs.chromium.org/p/chromium/issues/detail?id=667432#c3

=== Auto-CCing suspected CL author lgarron@chromium.org ===

Hi lgarron@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


Note that  bug 637967  has some ideas about formatting bisect results better, we might consider that. I think that <b> tags work in monorail if the line starts with <b> and ends with </b>
 
Description: Show this description
Blockedon: 637967
Components: Tests>AutoBisect
Labels: -Pri-3 Pri-2
Owner: simonhatch@chromium.org
Description: Show this description
test bold
test

Comment 5 Deleted

Like the suggestions in 637967, but looks more like a complete overhaul on bisect output. What's the status on the proposal there, is anybody driving it?


Maybe this could be something simple like checking if the bisect was a return_code bisect and changing the text to reflect that, along with some bolds?



=== Auto-CCing suspected CL author lgarron@chromium.org ===

Hi lgarron@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


vs


=== Auto-CCing suspected CL author lgarron@chromium.org ===

Hi lgarron@chromium.org, the bisect results pointed to your CL below as possibly
causing test failures. Please have a look at this info and see whether
your CL be related.



Or adding a new header to clarify things:


=== PERF REGRESSION DETECTED ===

=== Auto-CCing suspected CL author lgarron@chromium.org ===

Hi lgarron@chromium.org, the bisect results pointed to your CL. Please have a look at this info and see whether
it's related.


=== TEST FAILURE DETECTED ===

There's currently no one working on  bug 637967 ; dtu was looking into it but it'll probably be rolled into pinpoint.

I'm totally fine with a smaller change in the text to reflect that it's a test failure, your suggestions all sound fine (except when you're in the code could you also fix "see whether your CL be related"?)
Blocking: 664494
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c60f3321df06eb2945441f7953e1747efadb943a

commit c60f3321df06eb2945441f7953e1747efadb943a
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Nov 25 00:25:59 2016

Roll src/third_party/catapult/ 3276375d2..671a65473 (7 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3276375d2563..671a654736c2

$ git log 3276375d2..671a65473 --date=short --no-merges --format='%ad %ae %s'
2016-11-24 simonhatch Bisect - Fix compare_samples to read scalar values.
2016-11-24 hjd Fix getBoundingVisibleRect with offscreen elements
2016-11-24 ulan Helper functions for computing expected queueing time.
2016-11-23 achuith Autotest extension fix.
2016-11-23 benjhayden Document customizeSummaryOptions in how-to-write-metrics.
2016-11-23 fmeawad runtime_stats metric: only display the average in the dashboard
2016-11-23 simonhatch [bisect] - Clearly state bisect type in output.

BUG= 668536 , 664515 ,625701, 654525 , 667813 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2530973002
Cr-Commit-Position: refs/heads/master@{#434413}

[modify] https://crrev.com/c60f3321df06eb2945441f7953e1747efadb943a/DEPS

Status: Fixed (was: Untriaged)
Components: Speed>Bisection

Sign in to add a comment