Variations simulator ends up activating trials |
||
Issue descriptionVariations simulator ends up activating trials. I noticed this while reviewing its code, but the problem is it calls VariationParamsAreEqual() - which ends up activating the trial in question.
,
Jan 24 2017
Actually, I think this is not the case. It's true, if we called VariationParamsAreEqual() on a trial that's not activated yet, it would cause the problem. However, we explicitly skip those studies (see "Skip studies that aren't activated in the current state." in variations_seed_simulator.cc). Yay! |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Jan 24 2017