New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SBNavigationObserverBrowserTest.SingleMetaRefreshRedirectTargetBlank" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 22 2016

Issue description

"SBNavigationObserverBrowserTest.SingleMetaRefreshRedirectTargetBlank" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTwsSBUZsYWtlIkRTQk5hdmlnYXRpb25PYnNlcnZlckJyb3dzZXJUZXN0LlNpbmdsZU1ldGFSZWZyZXNoUmVkaXJlY3RUYXJnZXRCbGFuaww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Services>Safebrowsing
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
jialiul@, could you please take a look (I see that you've added this test 3 weeks ago in r429976).

FWIW, the test seems to only fail on linux_chromium_rel_ng.  I'll go ahead and put together a CL that disables this test on Linux.
Labels: -Sheriff-Chromium
CL that disables the flaky test is in CQ: https://codereview.chromium.org/2524163002
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e1c3cbe0d4a71600f5509937157742e4545bc2

commit b0e1c3cbe0d4a71600f5509937157742e4545bc2
Author: lukasza <lukasza@chromium.org>
Date: Fri Nov 25 21:04:33 2016

Disabling a flaky test (SingleMetaRefreshRedirectTargetBlank) on Linux.

BUG= 667784 
TBR=jialiul@chromium.org

Review-Url: https://codereview.chromium.org/2524163002
Cr-Commit-Position: refs/heads/master@{#434548}

[modify] https://crrev.com/b0e1c3cbe0d4a71600f5509937157742e4545bc2/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

Comment 4 by vakh@chromium.org, Dec 2 2016

Labels: SafeBrowsing-Triaged
I think this is actually due to a bug in PlzNavigate. 
Re-enable this test but filter it out in browser-side-navigation.linux.browser_tests.filter


Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e3c4b4536b96f914132d4c53f70b65fadeaf87d

commit 4e3c4b4536b96f914132d4c53f70b65fadeaf87d
Author: jialiul <jialiul@chromium.org>
Date: Wed Dec 21 18:38:52 2016

Add new download attribution logic to download protection service and enable
finch trial (a.k.a 50% on Canary only)

Also, a minor bug fixing in handling user gesture.

BUG=639467, 667784 

Review-Url: https://codereview.chromium.org/2578363002
Cr-Commit-Position: refs/heads/master@{#440162}

[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/download_protection_service.h
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_navigation_observer.h
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/4e3c4b4536b96f914132d4c53f70b65fadeaf87d/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment