New issue
Advanced search Search tips

Issue 667781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Disable WebVR presentation in multi-window.

Project Member Reported by mthiesse@chromium.org, Nov 22 2016

Issue description

Multi-window and VR don't interact well and cause a ton of bugs. For now let's disable webVR presentation when in multi-window.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f212bb93309c374d4ff6c3c4c8a1a1e160eddece

commit f212bb93309c374d4ff6c3c4c8a1a1e160eddece
Author: mthiesse <mthiesse@chromium.org>
Date: Tue Nov 22 17:25:36 2016

Disable WebVR Presentation when in MultiWindow mode.

BUG= 667781 

Review-Url: https://codereview.chromium.org/2523583004
Cr-Commit-Position: refs/heads/master@{#433900}

[modify] https://crrev.com/f212bb93309c374d4ff6c3c4c8a1a1e160eddece/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8f0dac15139997e0572038cbd555ad9a2d6ab9

commit ff8f0dac15139997e0572038cbd555ad9a2d6ab9
Author: bshe <bshe@chromium.org>
Date: Wed Nov 30 19:37:45 2016

Disable WebVR Presentation when in MultiWindow mode.

BUG= 667781 

Review-Url: https://codereview.chromium.org/2523583004
Cr-Commit-Position: refs/heads/master@{#433900}
(cherry picked from commit f212bb93309c374d4ff6c3c4c8a1a1e160eddece)

Review URL: https://codereview.chromium.org/2541633004 .

Cr-Commit-Position: refs/branch-heads/2924@{#203}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/ff8f0dac15139997e0572038cbd555ad9a2d6ab9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Proj-VR-Daydream
Status: Fixed (was: Assigned)

Sign in to add a comment