Use a translateable string for the section title in the Physical Web Page provider |
|||||||||
Issue descriptionCurrently it is hardcoded, but it should not be.
,
Nov 22 2016
Updating the title, since I was confused where a non-hardcoded string would come from :)
,
Nov 28 2016
,
Nov 28 2016
,
Nov 28 2016
So which title do we show? "Nearby" ? Which text we show when the section is empty? "You nearby suggestions appear here" ?
,
Dec 5 2016
Both SGTM
,
Dec 6 2016
,
Jan 3 2017
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c68f6585d9e6e195838d95334c63f42a5936a6a4 commit c68f6585d9e6e195838d95334c63f42a5936a6a4 Author: vitaliii <vitaliii@chromium.org> Date: Tue Jan 03 14:35:22 2017 [NTP] Translateable strings for recent tabs and physical web sections. BUG= 667764 Review-Url: https://codereview.chromium.org/2532783003 Cr-Commit-Position: refs/heads/master@{#441121} [modify] https://crrev.com/c68f6585d9e6e195838d95334c63f42a5936a6a4/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc [modify] https://crrev.com/c68f6585d9e6e195838d95334c63f42a5936a6a4/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc [modify] https://crrev.com/c68f6585d9e6e195838d95334c63f42a5936a6a4/components/ntp_snippets_strings.grdp
,
Jan 3 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vitaliii@chromium.org
, Nov 22 2016