New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667752 link

Starred by 2 users
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Feb 2017
Cc:
█ nepper@chromium.org
treib@chromium.org
fi...@chromium.org
fhorschig@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 665796


Sign in to add a comment

Remove the NTPSuggestionsFetchMore feature flag

Project Member Reported by dgn@chromium.org, Nov 22 2016 
Once the feature is approved and sticks, remove the flag.

Also, in the category info, merge has_reload_action and has_more_action, since they would become the same thing.

Comment 1 by fi...@chromium.org, Nov 22 2016

Labels: M-57 zine-triaged

Comment 2 by dgn@chromium.org, Jan 26 2017

Cc: nepper@chromium.org fi...@chromium.org
Labels: -M-57 zine-pm zine-17-01-30 M-58
The feature was enabled by default on M56 without any related Finch config for holdback etc. As M56 is going to stable soon, I plan to remove the flag in M58

+nepper@, finkm@ for FYI
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6270c784225d5a230201f41866c99caf6c00a2e

commit d6270c784225d5a230201f41866c99caf6c00a2e
Author: dgn <dgn@chromium.org>
Date: Wed Feb 01 18:22:31 2017

[NTP Client] Merge the has_fetch_more and has_reload actions

These 2 action types are redudnant now that fetch more is not behind
a flag. This patch consolidates one in a single property of
category_info.

BUG= 667752 

Review-Url: https://codereview.chromium.org/2663313002
Cr-Commit-Position: refs/heads/master@{#447556}

[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/category_info.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/category_info.h
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/content_suggestions_service_unittest.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/mock_content_suggestions_provider.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/d6270c784225d5a230201f41866c99caf6c00a2e/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Comment 5 by dgn@chromium.org, Feb 2 2017

Status: Fixed (was: Available)
►

Sign in to add a comment