Some GN circular dependencies problems may arise with ImageFetcher. We should move it to its own target to prevent it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03a0e8dd06380453b181d345f85422314fb0522b commit 03a0e8dd06380453b181d345f85422314fb0522b Author: gambard <gambard@chromium.org> Date: Fri Dec 02 09:11:05 2016 Move iOS ImageFetcher to ios/web/public This CL moves and renames the RawImageFetcher getting the data from the url. It moves it to ios/web/public, in order to be able to use it from ios/web and ios/chrome. BUG= 667747 Review-Url: https://codereview.chromium.org/2526773002 Cr-Commit-Position: refs/heads/master@{#435892} [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/BUILD.gn [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/net/BUILD.gn [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/net/image_fetcher.mm [delete] https://crrev.com/794dfc37a3b32cbd266762b51823e1de791b35df/ios/chrome/browser/net/image_fetcher_unittest.mm [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/suggestions/BUILD.gn [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/suggestions/image_fetcher_impl.h [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/suggestions/image_fetcher_impl.mm [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/chrome/browser/suggestions/ios_image_decoder_impl.mm [delete] https://crrev.com/794dfc37a3b32cbd266762b51823e1de791b35df/ios/chrome/browser/webp_transcode/README [modify] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/BUILD.gn [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/BUILD.gn [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/DEPS [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/OWNERS [add] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/image_data_fetcher.h [add] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/image_data_fetcher.mm [add] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/image_data_fetcher_unittest.mm [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/webp_decoder.h [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/webp_decoder.mm [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/image_fetcher/webp_decoder_unittest.mm [add] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/test/mock_image_data_fetcher.h [add] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/public/test/mock_image_data_fetcher.mm [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/OWNERS [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test.jpg [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test.webp [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test_alpha.png [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test_alpha.webp [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test_small.tiff [rename] https://crrev.com/03a0e8dd06380453b181d345f85422314fb0522b/ios/web/test/data/webp_transcode/test_small.webp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c792d25642914be34365507e93e0f4378b2eb9 commit d4c792d25642914be34365507e93e0f4378b2eb9 Author: gambard <gambard@chromium.org> Date: Mon Dec 05 12:56:38 2016 Remove the old image fetcher This CL removes the old image fetcher as it has been moved to ImageDataFetcher. BUG= 667747 Review-Url: https://codereview.chromium.org/2520373002 Cr-Commit-Position: refs/heads/master@{#436271} [modify] https://crrev.com/d4c792d25642914be34365507e93e0f4378b2eb9/ios/chrome/browser/native_app_launcher/BUILD.gn [modify] https://crrev.com/d4c792d25642914be34365507e93e0f4378b2eb9/ios/chrome/browser/net/BUILD.gn [delete] https://crrev.com/82f74b025438d88016d67f1d27b7ffca1d149dac/ios/chrome/browser/net/image_fetcher.h [delete] https://crrev.com/82f74b025438d88016d67f1d27b7ffca1d149dac/ios/chrome/browser/net/image_fetcher.mm [delete] https://crrev.com/82f74b025438d88016d67f1d27b7ffca1d149dac/ios/chrome/browser/net/mock_image_fetcher.h [delete] https://crrev.com/82f74b025438d88016d67f1d27b7ffca1d149dac/ios/chrome/browser/net/mock_image_fetcher.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/266a9c59f8c54faa3921c151a32e8149d3923714 commit 266a9c59f8c54faa3921c151a32e8149d3923714 Author: gambard <gambard@google.com> Date: Mon Dec 05 13:35:41 2016
Comment 1 by bugdroid1@chromium.org
, Dec 2 2016