New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667739 link

Starred by 0 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 2016
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In dev tools color picker window does not close after hitting 'Esc' key.

Reported by rk...@etouch.net, Nov 22 2016 
Chrome Version: 57.0.2926.3 Revision aa0b97dd3d2b29400934fa27320022b222610387-refs/branch-heads/2926@{#3}
OS: Windows(7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, go to NTP or any webpage, open 'DevTools' and click to open colorPicker window in 'Styles' section.
2. Now in color picker window click on "+" sign ("add to palette")under 'Custom' palette option..
3. Now hitt the 'Esc' key and observe.

Actual: Color picker window does not close after hitting 'Esc' key.

Expected: Color picker window should close after hitting 'Esc' key.

This is a regression issue,broken in 'M-57',will soon update other info:

Good Build: 56.0.2924.0
Bad Build: 57.0.2926.0
Actual_Devtools.mp4
870 KB View Download
Expected_Devtools.mp4
485 KB View Download

Comment 1 by hdodda@chromium.org, Nov 22 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 56.0.2924.0 (Revision:433059)
Bad Build: 57.0.2926.0 (Revision:433437)

You are probably looking for a change made after 433381 (known good), but no later than 433382 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/b734e93680a145f78d3a1a8502916cda3d1025fa..0384ce04d25ba97446b20e7ca2d423cec10c2ffd

From the CL above, assigning the issue to the concern owner 

@luoe - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2510883002

Thanks!

Comment 2 by l...@chromium.org, Nov 22 2016

Labels: -M-57 M-56
Thank you for the quick report.  This due to my change.  I've reverted my CL and will work on a fix for both of the bugs.

Comment 3 by msrchandra@chromium.org, Nov 25 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent regression. Please remove if not required.
Thank You.

Comment 4 by tkonch...@chromium.org, Nov 30 2016

Labels: Needs-Feedback
Unable to reproduce the issue on win10 chrome version 57.0.2936.0

Seems the issue got fixed in latest canary

rkote@, Could you please recheck the same on latest version and update the thread.

Comment 5 by l...@chromium.org, Nov 30 2016

Labels: -Needs-Feedback -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
Thank you for the verification.  This bug was introduced in #433382 (https://codereview.chromium.org/2510883002/), but was fixed when the CL was reverted.

Removing RBS label and marking as fixed.
Project Member

Comment 6 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Nov 30 2016

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by l...@chromium.org, Nov 30 2016

Labels: -Merge-TBD
According to Omahaproxy, M56's branch base commit is #433059.  The original bug was introduced in #433382 (https://codereview.chromium.org/2510883002/), which came after the branch point.  Therefore, a merge should not be needed.
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 16 2016

Labels: Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 16 2016 

This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by dimu@google.com, Dec 16 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review
►

Sign in to add a comment